Fix onboarding status performance issues (#6512)

Updated the onboardingStatus computation to improve performances

---------

Co-authored-by: Charles Bochet <charles@twenty.com>

packages/twenty-server/src/engine/core-modules/auth/auth.module.ts

@@ -32,6 +32,7 @@ import { CalendarChannelWorkspaceEntity } from 'src/modules/calendar/common/stan
 import { ConnectedAccountModule } from 'src/modules/connected-account/connected-account.module';
 import { ConnectedAccountWorkspaceEntity } from 'src/modules/connected-account/standard-objects/connected-account.workspace-entity';
 import { MessageChannelWorkspaceEntity } from 'src/modules/messaging/common/standard-objects/message-channel.workspace-entity';
+import { UserVarsModule } from 'src/engine/core-modules/user/user-vars/user-vars.module';
 
 import { AuthResolver } from './auth.resolver';
 

packages/twenty-server/src/engine/core-modules/auth/controllers/google-apis-auth.controller.ts

@@ -9,14 +9,14 @@ import {
 
 import { Response } from 'express';
 
+import { GoogleAPIsOauthExchangeCodeForTokenGuard } from 'src/engine/core-modules/auth/guards/google-apis-oauth-exchange-code-for-token.guard';
 import { GoogleAPIsOauthRequestCodeGuard } from 'src/engine/core-modules/auth/guards/google-apis-oauth-request-code.guard';
 import { GoogleAPIsService } from 'src/engine/core-modules/auth/services/google-apis.service';
 import { TokenService } from 'src/engine/core-modules/auth/services/token.service';
-import { EnvironmentService } from 'src/engine/integrations/environment/environment.service';
-import { OnboardingService } from 'src/engine/core-modules/onboarding/onboarding.service';
-import { LoadServiceWithWorkspaceContext } from 'src/engine/twenty-orm/context/load-service-with-workspace.context';
-import { GoogleAPIsOauthExchangeCodeForTokenGuard } from 'src/engine/core-modules/auth/guards/google-apis-oauth-exchange-code-for-token.guard';
 import { GoogleAPIsRequest } from 'src/engine/core-modules/auth/types/google-api-request.type';
+import { OnboardingService } from 'src/engine/core-modules/onboarding/onboarding.service';
+import { EnvironmentService } from 'src/engine/integrations/environment/environment.service';
+import { LoadServiceWithWorkspaceContext } from 'src/engine/twenty-orm/context/load-service-with-workspace.context';
 
 @Controller('auth/google-apis')
 export class GoogleAPIsAuthController {
@@ -93,10 +93,11 @@ export class GoogleAPIsAuthController {
           workspaceId,
         );
 
-      await onboardingServiceInstance.skipSyncEmailOnboardingStep(
+      await onboardingServiceInstance.toggleOnboardingConnectAccountCompletion({
         userId,
         workspaceId,
-      );
+        value: true,
+      });
     }
 
     return res.redirect(

packages/twenty-server/src/engine/core-modules/auth/services/sign-in-up.service.spec.ts

@@ -9,6 +9,7 @@ import { SignInUpService } from 'src/engine/core-modules/auth/services/sign-in-u
 import { FileUploadService } from 'src/engine/core-modules/file/file-upload/services/file-upload.service';
 import { UserWorkspaceService } from 'src/engine/core-modules/user-workspace/user-workspace.service';
 import { WorkspaceService } from 'src/engine/core-modules/workspace/services/workspace.service';
+import { OnboardingService } from 'src/engine/core-modules/onboarding/onboarding.service';
 
 describe('SignInUpService', () => {
   let service: SignInUpService;
@@ -21,10 +22,6 @@ describe('SignInUpService', () => {
           provide: FileUploadService,
           useValue: {},
         },
-        {
-          provide: UserWorkspaceService,
-          useValue: {},
-        },
         {
           provide: getRepositoryToken(Workspace, 'core'),
           useValue: {},
@@ -34,7 +31,11 @@ describe('SignInUpService', () => {
           useValue: {},
         },
         {
-          provide: EnvironmentService,
+          provide: UserWorkspaceService,
+          useValue: {},
+        },
+        {
+          provide: OnboardingService,
           useValue: {},
         },
         {
@@ -42,7 +43,7 @@ describe('SignInUpService', () => {
           useValue: {},
         },
         {
-          provide: WorkspaceService,
+          provide: EnvironmentService,
           useValue: {},
         },
       ],

packages/twenty-server/src/engine/core-modules/auth/services/sign-in-up.service.ts

@@ -18,9 +18,9 @@ import {
   hashPassword,
 } from 'src/engine/core-modules/auth/auth.util';
 import { FileUploadService } from 'src/engine/core-modules/file/file-upload/services/file-upload.service';
+import { OnboardingService } from 'src/engine/core-modules/onboarding/onboarding.service';
 import { UserWorkspaceService } from 'src/engine/core-modules/user-workspace/user-workspace.service';
 import { User } from 'src/engine/core-modules/user/user.entity';
-import { WorkspaceService } from 'src/engine/core-modules/workspace/services/workspace.service';
 import {
   Workspace,
   WorkspaceActivationStatus,
@@ -40,6 +40,7 @@ export type SignInUpServiceInput = {
 };
 
 @Injectable()
+// eslint-disable-next-line @nx/workspace-inject-workspace-repository
 export class SignInUpService {
   constructor(
     private readonly fileUploadService: FileUploadService,
@@ -48,7 +49,7 @@ export class SignInUpService {
     @InjectRepository(User, 'core')
     private readonly userRepository: Repository<User>,
     private readonly userWorkspaceService: UserWorkspaceService,
-    private readonly workspaceService: WorkspaceService,
+    private readonly onboardingService: OnboardingService,
     private readonly httpService: HttpService,
     private readonly environmentService: EnvironmentService,
   ) {}
@@ -221,6 +222,14 @@ export class SignInUpService {
 
     await this.userWorkspaceService.create(user.id, workspace.id);
 
+    if (user.firstName !== '' || user.lastName === '') {
+      await this.onboardingService.toggleOnboardingCreateProfileCompletion({
+        userId: user.id,
+        workspaceId: workspace.id,
+        value: true,
+      });
+    }
+
     return user;
   }