From 7e291f3cff23e468125cc7ce91c718ca5ffac786 Mon Sep 17 00:00:00 2001 From: martmull Date: Thu, 13 Mar 2025 11:02:59 +0100 Subject: [PATCH] Fix close right drawer error (#10841) fixes https://discord.com/channels/1130383047699738754/1349485390871924796 --- .../components/WorkflowDiagramCanvasEditableEffect.tsx | 6 +++++- .../components/WorkflowDiagramCanvasReadonlyEffect.tsx | 6 +++++- .../components/WorkflowRunDiagramCanvasEffect.tsx | 6 +++++- 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/packages/twenty-front/src/modules/workflow/workflow-diagram/components/WorkflowDiagramCanvasEditableEffect.tsx b/packages/twenty-front/src/modules/workflow/workflow-diagram/components/WorkflowDiagramCanvasEditableEffect.tsx index 520b63e08..51fc67c47 100644 --- a/packages/twenty-front/src/modules/workflow/workflow-diagram/components/WorkflowDiagramCanvasEditableEffect.tsx +++ b/packages/twenty-front/src/modules/workflow/workflow-diagram/components/WorkflowDiagramCanvasEditableEffect.tsx @@ -41,12 +41,16 @@ export const WorkflowDiagramCanvasEditableEffect = () => { const handleSelectionChange = useCallback( ({ nodes }: OnSelectionChangeParams) => { - const selectedNode = nodes[0] as WorkflowDiagramNode; + const selectedNode = nodes[0] as WorkflowDiagramNode | undefined; if (!isInRightDrawer) { setCommandMenuNavigationStack([]); } + if (!isDefined(selectedNode)) { + return; + } + const isEmptyTriggerNode = selectedNode.type === EMPTY_TRIGGER_STEP_ID; if (isEmptyTriggerNode) { if (isDefined(workflowId)) { diff --git a/packages/twenty-front/src/modules/workflow/workflow-diagram/components/WorkflowDiagramCanvasReadonlyEffect.tsx b/packages/twenty-front/src/modules/workflow/workflow-diagram/components/WorkflowDiagramCanvasReadonlyEffect.tsx index 1bb9ef28c..f29a8c9be 100644 --- a/packages/twenty-front/src/modules/workflow/workflow-diagram/components/WorkflowDiagramCanvasReadonlyEffect.tsx +++ b/packages/twenty-front/src/modules/workflow/workflow-diagram/components/WorkflowDiagramCanvasReadonlyEffect.tsx @@ -22,7 +22,11 @@ export const WorkflowDiagramCanvasReadonlyEffect = () => { const handleSelectionChange = useCallback( ({ nodes }: OnSelectionChangeParams) => { - const selectedNode = nodes[0] as WorkflowDiagramNode; + const selectedNode = nodes[0] as WorkflowDiagramNode | undefined; + + if (!isDefined(selectedNode)) { + return; + } setWorkflowSelectedNode(selectedNode.id); diff --git a/packages/twenty-front/src/modules/workflow/workflow-diagram/components/WorkflowRunDiagramCanvasEffect.tsx b/packages/twenty-front/src/modules/workflow/workflow-diagram/components/WorkflowRunDiagramCanvasEffect.tsx index dc0b45b8f..a26e5c053 100644 --- a/packages/twenty-front/src/modules/workflow/workflow-diagram/components/WorkflowRunDiagramCanvasEffect.tsx +++ b/packages/twenty-front/src/modules/workflow/workflow-diagram/components/WorkflowRunDiagramCanvasEffect.tsx @@ -49,7 +49,11 @@ export const WorkflowRunDiagramCanvasEffect = () => { const handleSelectionChange = useCallback( ({ nodes }: OnSelectionChangeParams) => { - const selectedNode = nodes[0] as WorkflowDiagramNode; + const selectedNode = nodes[0] as WorkflowDiagramNode | undefined; + + if (!isDefined(selectedNode)) { + return; + } setWorkflowSelectedNode(selectedNode.id);