feat (improvement): update the createOneObjectMetaItem (#5673)
# This PR - Fix #5278 - Updates the implementation of the `createOneObjectMataItem` hook to reduce the number of api calls - Users can now navigate to the newly created object first and the graphql api calls to cache data are happening in the background - this will improve the user experience and reduce the create object api call time by >2 <img width="1508" alt="Screenshot 2024-05-30 at 12 00 15" src="https://github.com/twentyhq/twenty/assets/61581306/46513fd1-d46e-40bc-a036-07e3acdf2870"> In the issue description, it also suggested to have a loading indicator while creating the object, it seems like on #5352 we adopted to disable it while creating the object - which looks good to me and it works, let me know if we still need the loading indicator instead @Bonapara Looking forward to getting your feedback cc: @charlesBochet --------- Co-authored-by: Thomas Trompette <thomas.trompette@sfr.fr>
This commit is contained in:
committed by
GitHub
parent
52864889da
commit
7fa05bf539
@ -38,15 +38,18 @@ export const useCreateOneObjectMetadataItem = () => {
|
|||||||
refetchQueries: [getOperationName(FIND_MANY_OBJECT_METADATA_ITEMS) ?? ''],
|
refetchQueries: [getOperationName(FIND_MANY_OBJECT_METADATA_ITEMS) ?? ''],
|
||||||
});
|
});
|
||||||
|
|
||||||
|
return createdObjectMetadata;
|
||||||
|
};
|
||||||
|
|
||||||
|
const findManyRecordsCache = async () => {
|
||||||
await apolloClient.query({
|
await apolloClient.query({
|
||||||
query: findManyRecordsQuery,
|
query: findManyRecordsQuery,
|
||||||
fetchPolicy: 'network-only',
|
fetchPolicy: 'network-only',
|
||||||
});
|
});
|
||||||
|
|
||||||
return createdObjectMetadata;
|
|
||||||
};
|
};
|
||||||
|
|
||||||
return {
|
return {
|
||||||
createOneObjectMetadataItem,
|
createOneObjectMetadataItem,
|
||||||
|
findManyRecordsCache,
|
||||||
};
|
};
|
||||||
};
|
};
|
||||||
|
|||||||
@ -30,7 +30,8 @@ export const SettingsNewObject = () => {
|
|||||||
const navigate = useNavigate();
|
const navigate = useNavigate();
|
||||||
const { enqueueSnackBar } = useSnackBar();
|
const { enqueueSnackBar } = useSnackBar();
|
||||||
|
|
||||||
const { createOneObjectMetadataItem } = useCreateOneObjectMetadataItem();
|
const { createOneObjectMetadataItem, findManyRecordsCache } =
|
||||||
|
useCreateOneObjectMetadataItem();
|
||||||
|
|
||||||
const settingsObjectsPagePath = getSettingsPagePath(SettingsPath.Objects);
|
const settingsObjectsPagePath = getSettingsPagePath(SettingsPath.Objects);
|
||||||
|
|
||||||
@ -57,6 +58,8 @@ export const SettingsNewObject = () => {
|
|||||||
)}`
|
)}`
|
||||||
: settingsObjectsPagePath,
|
: settingsObjectsPagePath,
|
||||||
);
|
);
|
||||||
|
|
||||||
|
await findManyRecordsCache();
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
enqueueSnackBar((error as Error).message, {
|
enqueueSnackBar((error as Error).message, {
|
||||||
variant: SnackBarVariant.Error,
|
variant: SnackBarVariant.Error,
|
||||||
|
|||||||
Reference in New Issue
Block a user