[CHORE] Avoid isDefined duplicated reference, move it to twenty-shared (#9967)

# Introduction
Avoid having multiple `isDefined` definition across our pacakges
Also avoid importing `isDefined` from `twenty-ui` which exposes a huge
barrel for a such little util function

## In a nutshell
Removed own `isDefined.ts` definition from `twenty-ui` `twenty-front`
and `twenty-server` to move it to `twenty-shared`.
Updated imports for each packages, and added explicit dependencies to
`twenty-shared` if not already in place

Related PR https://github.com/twentyhq/twenty/pull/9941

packages/twenty-front/src/modules/settings/accounts/components/SettingsAccountsConnectedAccountsListCard.tsx

@@ -7,8 +7,8 @@ import { SettingsPath } from '@/types/SettingsPath';
 import { currentWorkspaceState } from '@/auth/states/currentWorkspaceState';
 import { SettingsAccountsConnectedAccountsRowRightContainer } from '@/settings/accounts/components/SettingsAccountsConnectedAccountsRowRightContainer';
 import { useRecoilValue } from 'recoil';
+import { isDefined } from 'twenty-shared';
 import { useNavigateSettings } from '~/hooks/useNavigateSettings';
-import { isDefined } from '~/utils/isDefined';
 import { SettingsListCard } from '../../components/SettingsListCard';
 
 const ProviderIcons: { [k: string]: IconComponent } = {

packages/twenty-front/src/modules/settings/admin-panel/components/SettingsAdminContent.tsx

@@ -14,7 +14,7 @@ import styled from '@emotion/styled';
 import { isNonEmptyString } from '@sniptt/guards';
 import { useState } from 'react';
 import { useRecoilValue } from 'recoil';
-import { getImageAbsoluteURI } from 'twenty-shared';
+import { getImageAbsoluteURI, isDefined } from 'twenty-shared';
 import {
   Button,
   H1Title,
@@ -22,7 +22,6 @@ import {
   H2Title,
   IconSearch,
   IconUser,
-  isDefined,
   Section,
   Toggle,
 } from 'twenty-ui';

packages/twenty-front/src/modules/settings/admin-panel/hooks/useFeatureFlagsManagement.ts

@@ -1,10 +1,10 @@
 import { UserLookup } from '@/settings/admin-panel/types/UserLookup';
 import { useState } from 'react';
-import { isDefined } from 'twenty-ui';
+import { isDefined } from 'twenty-shared';
 import {
+  FeatureFlagKey,
   useUpdateWorkspaceFeatureFlagMutation,
   useUserLookupAdminPanelMutation,
-  FeatureFlagKey,
 } from '~/generated/graphql';
 
 export const useFeatureFlagsManagement = () => {

packages/twenty-front/src/modules/settings/admin-panel/hooks/useImpersonate.ts

@@ -6,8 +6,8 @@ import { isAppWaitingForFreshObjectMetadataState } from '@/object-metadata/state
 import { AppPath } from '@/types/AppPath';
 import { useState } from 'react';
 import { useRecoilState, useRecoilValue, useSetRecoilState } from 'recoil';
+import { isDefined } from 'twenty-shared';
 import { useImpersonateMutation } from '~/generated/graphql';
-import { isDefined } from '~/utils/isDefined';
 
 export const useImpersonate = () => {
   const [currentUser] = useRecoilState(currentUserState);

packages/twenty-front/src/modules/settings/components/SettingsPageContainer.tsx

@@ -3,7 +3,7 @@ import { useIsMobile } from '@/ui/utilities/responsive/hooks/useIsMobile';
 import { ScrollWrapper } from '@/ui/utilities/scroll/components/ScrollWrapper';
 import styled from '@emotion/styled';
 import { ReactNode } from 'react';
-import { isDefined } from '~/utils/isDefined';
+import { isDefined } from 'twenty-shared';
 
 const StyledSettingsPageContainer = styled.div<{
   width?: number;

packages/twenty-front/src/modules/settings/data-model/components/SettingsDataModelNewFieldBreadcrumbDropDown.tsx

@@ -7,7 +7,8 @@ import { useDropdown } from '@/ui/layout/dropdown/hooks/useDropdown';
 import { useTheme } from '@emotion/react';
 import styled from '@emotion/styled';
 import { useLocation, useParams, useSearchParams } from 'react-router-dom';
-import { Button, IconChevronDown, isDefined, MenuItem } from 'twenty-ui';
+import { isDefined } from 'twenty-shared';
+import { Button, IconChevronDown, MenuItem } from 'twenty-ui';
 import { useNavigateSettings } from '~/hooks/useNavigateSettings';
 
 const StyledContainer = styled.div`

packages/twenty-front/src/modules/settings/data-model/fields/forms/components/SettingsDataModelFieldIconLabelForm.tsx

@@ -12,12 +12,12 @@ import { IconPicker } from '@/ui/input/components/IconPicker';
 import { TextInput } from '@/ui/input/components/TextInput';
 import { useTheme } from '@emotion/react';
 import { useLingui } from '@lingui/react/macro';
+import { isDefined } from 'twenty-shared';
 import {
   AppTooltip,
   Card,
   IconInfoCircle,
   IconRefresh,
-  isDefined,
   TooltipDelay,
 } from 'twenty-ui';
 import { computeMetadataNameFromLabel } from '~/pages/settings/data-model/utils/compute-metadata-name-from-label.utils';

packages/twenty-front/src/modules/settings/data-model/fields/preview/components/SettingsDataModelSetFieldValueEffect.tsx

@@ -4,7 +4,7 @@ import { recordStoreFamilySelector } from '@/object-record/record-store/states/s
 import { settingsPreviewRecordIdState } from '@/settings/data-model/fields/preview/states/settingsPreviewRecordIdState';
 import { useEffect } from 'react';
 import { useRecoilValue, useSetRecoilState } from 'recoil';
-import { isDefined } from '~/utils/isDefined';
+import { isDefined } from 'twenty-shared';
 
 type SettingsDataModelSetFieldValueEffectProps = {
   recordId: string;

packages/twenty-front/src/modules/settings/data-model/fields/preview/hooks/usePreviewRecord.ts

@@ -4,8 +4,8 @@ import { useFindManyRecords } from '@/object-record/hooks/useFindManyRecords';
 import { isFieldValueEmpty } from '@/object-record/record-field/utils/isFieldValueEmpty';
 import { ObjectRecord } from '@/object-record/types/ObjectRecord';
 import { getFieldPreviewValue } from '@/settings/data-model/fields/preview/utils/getFieldPreviewValue';
+import { isDefined } from 'twenty-shared';
 import { FieldMetadataType } from '~/generated-metadata/graphql';
-import { isDefined } from '~/utils/isDefined';
 import { pascalCase } from '~/utils/string/pascalCase';
 
 type UsePreviewRecordParams = {

packages/twenty-front/src/modules/settings/data-model/fields/preview/utils/getFieldPreviewValue.ts

@@ -3,7 +3,7 @@ import { isFieldValueEmpty } from '@/object-record/record-field/utils/isFieldVal
 import { generateDefaultFieldValue } from '@/object-record/utils/generateDefaultFieldValue';
 import { getSettingsFieldTypeConfig } from '@/settings/data-model/utils/getSettingsFieldTypeConfig';
 import { isFieldTypeSupportedInSettings } from '@/settings/data-model/utils/isFieldTypeSupportedInSettings';
-import { isDefined } from '~/utils/isDefined';
+import { isDefined } from 'twenty-shared';
 
 export const getFieldPreviewValue = ({
   fieldMetadataItem,

packages/twenty-front/src/modules/settings/data-model/fields/preview/utils/getMultiSelectFieldPreviewValue.ts

@@ -4,8 +4,8 @@ import { isNonEmptyString } from '@sniptt/guards';
 import { FieldMetadataItem } from '@/object-metadata/types/FieldMetadataItem';
 import { FieldMultiSelectValue } from '@/object-record/record-field/types/FieldMetadata';
 import { multiSelectFieldDefaultValueSchema } from '@/object-record/record-field/validation-schemas/multiSelectFieldDefaultValueSchema';
+import { isDefined } from 'twenty-shared';
 import { FieldMetadataType } from '~/generated-metadata/graphql';
-import { isDefined } from '~/utils/isDefined';
 import { stripSimpleQuotesFromString } from '~/utils/string/stripSimpleQuotesFromString';
 
 export const getMultiSelectFieldPreviewValue = ({

packages/twenty-front/src/modules/settings/data-model/fields/preview/utils/getSelectFieldPreviewValue.ts

@@ -3,8 +3,8 @@ import { isNonEmptyString } from '@sniptt/guards';
 import { FieldMetadataItem } from '@/object-metadata/types/FieldMetadataItem';
 import { FieldSelectValue } from '@/object-record/record-field/types/FieldMetadata';
 import { selectFieldDefaultValueSchema } from '@/object-record/record-field/validation-schemas/selectFieldDefaultValueSchema';
+import { isDefined } from 'twenty-shared';
 import { FieldMetadataType } from '~/generated-metadata/graphql';
-import { isDefined } from '~/utils/isDefined';
 import { stripSimpleQuotesFromString } from '~/utils/string/stripSimpleQuotesFromString';
 
 export const getSelectFieldPreviewValue = ({

packages/twenty-front/src/modules/settings/data-model/graph-overview/components/SettingsDataModelOverview.tsx

@@ -20,6 +20,7 @@ import {
   useReactFlow,
 } from '@xyflow/react';
 import { useCallback, useState } from 'react';
+import { isDefined } from 'twenty-shared';
 import {
   Button,
   IconButtonGroup,
@@ -30,7 +31,6 @@ import {
   IconPlus,
   IconX,
 } from 'twenty-ui';
-import { isDefined } from '~/utils/isDefined';
 
 const nodeTypes: NodeTypes = {
   object: SettingsDataModelOverviewObject,

packages/twenty-front/src/modules/settings/data-model/graph-overview/components/SettingsDataModelOverviewEffect.tsx

@@ -5,7 +5,7 @@ import { useEffect } from 'react';
 import { useRecoilValue } from 'recoil';
 
 import { objectMetadataItemsState } from '@/object-metadata/states/objectMetadataItemsState';
-import { isDefined } from '~/utils/isDefined';
+import { isDefined } from 'twenty-shared';
 import { isUndefinedOrNull } from '~/utils/isUndefinedOrNull';
 
 type SettingsDataModelOverviewEffectProps = {

packages/twenty-front/src/modules/settings/data-model/object-details/components/SettingsObjectFieldItemTableRow.tsx

@@ -21,12 +21,12 @@ import { useTheme } from '@emotion/react';
 import styled from '@emotion/styled';
 import { useMemo } from 'react';
 import { useRecoilState } from 'recoil';
+import { isDefined } from 'twenty-shared';
 import {
   IconMinus,
   IconPlus,
   LightIconButton,
   UndecoratedLink,
-  isDefined,
   useIcons,
 } from 'twenty-ui';
 import { RelationDefinitionType } from '~/generated-metadata/graphql';

packages/twenty-front/src/modules/settings/data-model/objects/forms/components/SettingsDataModelObjectAboutForm.tsx

@@ -10,6 +10,7 @@ import { useTheme } from '@emotion/react';
 import styled from '@emotion/styled';
 import { plural } from 'pluralize';
 import { Controller, useFormContext } from 'react-hook-form';
+import { isDefined } from 'twenty-shared';
 import {
   AppTooltip,
   Card,
@@ -19,7 +20,6 @@ import {
 } from 'twenty-ui';
 import { z } from 'zod';
 import { computeMetadataNameFromLabel } from '~/pages/settings/data-model/utils/compute-metadata-name-from-label.utils';
-import { isDefined } from '~/utils/isDefined';
 
 export const settingsDataModelObjectAboutFormSchema = objectMetadataItemSchema
   .pick({

packages/twenty-front/src/modules/settings/developers/components/ApiKeyNameInput.tsx

@@ -1,12 +1,12 @@
-import { useCallback, useEffect } from 'react';
 import styled from '@emotion/styled';
+import { useCallback, useEffect } from 'react';
 import { useDebouncedCallback } from 'use-debounce';
 
 import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
 import { useUpdateOneRecord } from '@/object-record/hooks/useUpdateOneRecord';
 import { ApiKey } from '@/settings/developers/types/api-key/ApiKey';
 import { TextInput } from '@/ui/input/components/TextInput';
-import { isDefined } from '~/utils/isDefined';
+import { isDefined } from 'twenty-shared';
 
 const StyledComboInputContainer = styled.div`
   display: flex;

packages/twenty-front/src/modules/settings/integrations/components/SettingsIntegrationComponent.tsx

@@ -12,7 +12,7 @@ import {
 import { SettingsIntegration } from '@/settings/integrations/types/SettingsIntegration';
 import { Link } from 'react-router-dom';
 
-import { isDefined } from '~/utils/isDefined';
+import { isDefined } from 'twenty-shared';
 
 interface SettingsIntegrationComponentProps {
   integration: SettingsIntegration;

packages/twenty-front/src/modules/settings/integrations/database-connection/components/SettingsIntegrationDatabaseConnectionSyncStatus.tsx

@@ -1,7 +1,7 @@
 import { useGetDatabaseConnectionTables } from '@/databases/hooks/useGetDatabaseConnectionTables';
+import { isDefined } from 'twenty-shared';
 import { Status } from 'twenty-ui';
 import { RemoteTableStatus } from '~/generated-metadata/graphql';
-import { isDefined } from '~/utils/isDefined';
 
 type SettingsIntegrationDatabaseConnectionSyncStatusProps = {
   connectionId: string;

packages/twenty-front/src/modules/settings/lab/hooks/useLabPublicFeatureFlags.ts

@@ -2,7 +2,7 @@ import { currentWorkspaceState } from '@/auth/states/currentWorkspaceState';
 import { labPublicFeatureFlagsState } from '@/client-config/states/labPublicFeatureFlagsState';
 import { useState } from 'react';
 import { useRecoilState, useRecoilValue } from 'recoil';
-import { isDefined } from 'twenty-ui';
+import { isDefined } from 'twenty-shared';
 import {
   FeatureFlagKey,
   useUpdateLabPublicFeatureFlagMutation,

packages/twenty-front/src/modules/settings/profile/components/ProfilePictureUploader.tsx

@@ -5,8 +5,8 @@ import { currentWorkspaceMemberState } from '@/auth/states/currentWorkspaceMembe
 import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
 import { useUpdateOneRecord } from '@/object-record/hooks/useUpdateOneRecord';
 import { ImageInput } from '@/ui/input/components/ImageInput';
+import { isDefined } from 'twenty-shared';
 import { useUploadProfilePictureMutation } from '~/generated/graphql';
-import { isDefined } from '~/utils/isDefined';
 import { isUndefinedOrNull } from '~/utils/isUndefinedOrNull';
 
 export const ProfilePictureUploader = () => {

packages/twenty-front/src/modules/settings/security/components/SettingsSSOSAMLForm.tsx

@@ -8,6 +8,7 @@ import { useTheme } from '@emotion/react';
 import styled from '@emotion/styled';
 import { ChangeEvent, useRef } from 'react';
 import { useFormContext } from 'react-hook-form';
+import { isDefined } from 'twenty-shared';
 import {
   Button,
   H2Title,
@@ -19,7 +20,6 @@ import {
   Section,
 } from 'twenty-ui';
 import { REACT_APP_SERVER_BASE_URL } from '~/config';
-import { isDefined } from '~/utils/isDefined';
 
 const StyledUploadFileContainer = styled.div`
   align-items: center;

packages/twenty-front/src/modules/settings/security/components/SettingsSecuritySSORowDropdownMenu.tsx

@@ -17,8 +17,8 @@ import { Dropdown } from '@/ui/layout/dropdown/components/Dropdown';
 import { DropdownMenuItemsContainer } from '@/ui/layout/dropdown/components/DropdownMenuItemsContainer';
 import { useDropdown } from '@/ui/layout/dropdown/hooks/useDropdown';
 import { UnwrapRecoilValue } from 'recoil';
+import { isDefined } from 'twenty-shared';
 import { SsoIdentityProviderStatus } from '~/generated/graphql';
-import { isDefined } from '~/utils/isDefined';
 
 type SettingsSecuritySSORowDropdownMenuProps = {
   SSOIdp: UnwrapRecoilValue<typeof SSOIdentitiesProvidersState>[0];

packages/twenty-front/src/modules/settings/serverless-functions/components/SettingsServerlessFunctionCodeEditor.tsx

@@ -3,9 +3,9 @@ import { EditorProps, Monaco } from '@monaco-editor/react';
 import dotenv from 'dotenv';
 import { editor, MarkerSeverity } from 'monaco-editor';
 import { AutoTypings } from 'monaco-editor-auto-typings';
-import { CodeEditor } from 'twenty-ui';
-import { isDefined } from '~/utils/isDefined';
 import { useParams } from 'react-router-dom';
+import { isDefined } from 'twenty-shared';
+import { CodeEditor } from 'twenty-ui';
 
 export type File = {
   language: string;

packages/twenty-front/src/modules/settings/workspace/components/NameField.tsx

@@ -7,8 +7,8 @@ import { currentWorkspaceState } from '@/auth/states/currentWorkspaceState';
 import { TextInput } from '@/ui/input/components/TextInput';
 import { useLingui } from '@lingui/react/macro';
 import isEmpty from 'lodash.isempty';
+import { isDefined } from 'twenty-shared';
 import { useUpdateWorkspaceMutation } from '~/generated/graphql';
-import { isDefined } from '~/utils/isDefined';
 import { isUndefinedOrNull } from '~/utils/isUndefinedOrNull';
 import { logError } from '~/utils/logError';