[CHORE] Avoid isDefined duplicated reference, move it to twenty-shared (#9967)
# Introduction Avoid having multiple `isDefined` definition across our pacakges Also avoid importing `isDefined` from `twenty-ui` which exposes a huge barrel for a such little util function ## In a nutshell Removed own `isDefined.ts` definition from `twenty-ui` `twenty-front` and `twenty-server` to move it to `twenty-shared`. Updated imports for each packages, and added explicit dependencies to `twenty-shared` if not already in place Related PR https://github.com/twentyhq/twenty/pull/9941
This commit is contained in:
@ -1,12 +1,12 @@
|
||||
import { Profiler, ProfilerOnRenderCallback } from 'react';
|
||||
import { useRecoilCallback } from 'recoil';
|
||||
|
||||
import { isDefined } from 'twenty-shared';
|
||||
import { profilingQueueState } from '~/testing/profiling/states/profilingQueueState';
|
||||
import { profilingSessionDataPointsState } from '~/testing/profiling/states/profilingSessionDataPointsState';
|
||||
import { profilingSessionState } from '~/testing/profiling/states/profilingSessionState';
|
||||
import { ProfilingDataPoint } from '~/testing/profiling/types/ProfilingDataPoint';
|
||||
import { getProfilingQueueIdentifier } from '~/testing/profiling/utils/getProfilingQueueIdentifier';
|
||||
import { isDefined } from '~/utils/isDefined';
|
||||
|
||||
export const ProfilerWrapper = ({
|
||||
profilingId,
|
||||
|
||||
@ -1,9 +1,9 @@
|
||||
import { isNonEmptyString } from '@sniptt/guards';
|
||||
|
||||
import { isDefined } from 'twenty-shared';
|
||||
import { PROFILING_REPORTER_DIV_ID } from '~/testing/profiling/constants/ProfilingReporterDivId';
|
||||
import { ProfilingReport } from '~/testing/profiling/types/ProfilingReportByRun';
|
||||
import { parseProfilingReportString } from '~/testing/profiling/utils/parseProfilingReportString';
|
||||
import { isDefined } from '~/utils/isDefined';
|
||||
|
||||
export const getProfilingReportFromDocument = (
|
||||
documentElement: Element,
|
||||
|
||||
@ -1,9 +1,9 @@
|
||||
import { StoryObj } from '@storybook/react';
|
||||
import { expect, findByTestId } from '@storybook/test';
|
||||
|
||||
import { isDefined } from 'twenty-shared';
|
||||
import { ProfilerDecorator } from '~/testing/decorators/ProfilerDecorator';
|
||||
import { getProfilingReportFromDocument } from '~/testing/profiling/utils/getProfilingReportFromDocument';
|
||||
import { isDefined } from '~/utils/isDefined';
|
||||
|
||||
export const getProfilingStory = ({
|
||||
componentName,
|
||||
|
||||
Reference in New Issue
Block a user