[CHORE] Avoid isDefined duplicated reference, move it to twenty-shared (#9967)

# Introduction
Avoid having multiple `isDefined` definition across our pacakges
Also avoid importing `isDefined` from `twenty-ui` which exposes a huge
barrel for a such little util function

## In a nutshell
Removed own `isDefined.ts` definition from `twenty-ui` `twenty-front`
and `twenty-server` to move it to `twenty-shared`.
Updated imports for each packages, and added explicit dependencies to
`twenty-shared` if not already in place

Related PR https://github.com/twentyhq/twenty/pull/9941

packages/twenty-front/src/utils/__tests__/isDefined.test.ts

@@ -1,15 +0,0 @@
-import { isDefined } from '~/utils/isDefined';
-
-describe('isDefined', () => {
-  it('returns true if value is not undefined nor null', () => {
-    expect(isDefined('')).toBe(true);
-  });
-
-  it('returns false if value is null', () => {
-    expect(isDefined(null)).toBe(false);
-  });
-
-  it('returns false if value is undefined', () => {
-    expect(isDefined(undefined)).toBe(false);
-  });
-});

packages/twenty-front/src/utils/combineRefs.ts

@@ -1,6 +1,6 @@
 import { isFunction } from '@sniptt/guards';
 import { MutableRefObject, Ref } from 'react';
-import { isDefined } from '~/utils/isDefined';
+import { isDefined } from 'twenty-shared';
 
 export const combineRefs = <T>(...refs: (Ref<T> | undefined)[]) => {
   return (node: T) => {

packages/twenty-front/src/utils/date-utils.ts

@@ -4,7 +4,7 @@ import { differenceInCalendarDays, formatDistanceToNow } from 'date-fns';
 import { DateTime } from 'luxon';
 import moize from 'moize';
 
-import { isDefined } from '~/utils/isDefined';
+import { isDefined } from 'twenty-shared';
 
 import { logError } from './logError';
 

packages/twenty-front/src/utils/getDisplayValueByUrlType.ts

@@ -1,5 +1,5 @@
+import { isDefined } from 'twenty-shared';
 import { LinkType } from 'twenty-ui';
-import { isDefined } from './isDefined';
 
 type getUrlDisplayValueByUrlTypeProps = {
   type: LinkType;

packages/twenty-front/src/utils/is-domain.ts

@@ -1,4 +1,4 @@
-import { isDefined } from './isDefined';
+import { isDefined } from 'twenty-shared';
 
 export const isDomain = (url: string | undefined | null) =>
   isDefined(url) &&

packages/twenty-front/src/utils/isDefined.ts

@@ -1,4 +0,0 @@
-import { isNull, isUndefined } from '@sniptt/guards';
-
-export const isDefined = <T>(value: T | null | undefined): value is T =>
-  !isUndefined(value) && !isNull(value);

packages/twenty-front/src/utils/navigation/getAppPath.ts

@@ -1,7 +1,7 @@
 import { AppPath } from '@/types/AppPath';
 import qs from 'qs';
 import { generatePath, PathParam } from 'react-router-dom';
-import { isDefined } from 'twenty-ui';
+import { isDefined } from 'twenty-shared';
 
 export const getAppPath = <T extends AppPath>(
   to: T,

packages/twenty-front/src/utils/navigation/getSettingsPath.ts

@@ -2,7 +2,7 @@ import { AppPath } from '@/types/AppPath';
 import { SettingsPath } from '@/types/SettingsPath';
 import qs from 'qs';
 import { generatePath, PathParam } from 'react-router-dom';
-import { isDefined } from 'twenty-ui';
+import { isDefined } from 'twenty-shared';
 
 export const getSettingsPath = <T extends SettingsPath>(
   to: T,

packages/twenty-front/src/utils/parseJson.ts

@@ -1,4 +1,4 @@
-import { isDefined } from 'twenty-ui';
+import { isDefined } from 'twenty-shared';
 
 export const parseJson = <T>(json: string | undefined | null) => {
   if (!isDefined(json)) {

packages/twenty-front/src/utils/recoil-effects.ts

@@ -1,11 +1,10 @@
-import { AtomEffect } from 'recoil';
 import omit from 'lodash.omit';
+import { AtomEffect } from 'recoil';
 import { z } from 'zod';
 
+import { isDefined } from 'twenty-shared';
 import { cookieStorage } from '~/utils/cookie-storage';
 
-import { isDefined } from './isDefined';
-
 export const localStorageEffect =
   <T>(key?: string): AtomEffect<T> =>
   ({ setSelf, onSet, node }) => {