[CHORE] Avoid isDefined duplicated reference, move it to twenty-shared (#9967)

# Introduction
Avoid having multiple `isDefined` definition across our pacakges
Also avoid importing `isDefined` from `twenty-ui` which exposes a huge
barrel for a such little util function

## In a nutshell
Removed own `isDefined.ts` definition from `twenty-ui` `twenty-front`
and `twenty-server` to move it to `twenty-shared`.
Updated imports for each packages, and added explicit dependencies to
`twenty-shared` if not already in place

Related PR https://github.com/twentyhq/twenty/pull/9941

packages/twenty-server/src/engine/core-modules/domain-manager/services/domain-manager.service.ts

@@ -1,21 +1,21 @@
 import { Injectable, Logger } from '@nestjs/common';
 import { InjectRepository } from '@nestjs/typeorm';
 
-import { Repository } from 'typeorm';
 import Cloudflare from 'cloudflare';
+import { Repository } from 'typeorm';
+import { isDefined } from 'twenty-shared';
 
-import { EnvironmentService } from 'src/engine/core-modules/environment/environment.service';
-import { Workspace } from 'src/engine/core-modules/workspace/workspace.entity';
-import { isDefined } from 'src/utils/is-defined';
-import { domainManagerValidator } from 'src/engine/core-modules/domain-manager/validator/cloudflare.validate';
 import {
   DomainManagerException,
   DomainManagerExceptionCode,
 } from 'src/engine/core-modules/domain-manager/domain-manager.exception';
-import { generateRandomSubdomain } from 'src/engine/core-modules/domain-manager/utils/generate-random-subdomain';
-import { getSubdomainNameFromDisplayName } from 'src/engine/core-modules/domain-manager/utils/get-subdomain-name-from-display-name';
-import { getSubdomainFromEmail } from 'src/engine/core-modules/domain-manager/utils/get-subdomain-from-email';
 import { CustomHostnameDetails } from 'src/engine/core-modules/domain-manager/dtos/custom-hostname-details';
+import { generateRandomSubdomain } from 'src/engine/core-modules/domain-manager/utils/generate-random-subdomain';
+import { getSubdomainFromEmail } from 'src/engine/core-modules/domain-manager/utils/get-subdomain-from-email';
+import { getSubdomainNameFromDisplayName } from 'src/engine/core-modules/domain-manager/utils/get-subdomain-name-from-display-name';
+import { domainManagerValidator } from 'src/engine/core-modules/domain-manager/validator/cloudflare.validate';
+import { EnvironmentService } from 'src/engine/core-modules/environment/environment.service';
+import { Workspace } from 'src/engine/core-modules/workspace/workspace.entity';
 
 @Injectable()
 export class DomainManagerService {

packages/twenty-server/src/engine/core-modules/domain-manager/utils/get-subdomain-from-email.ts

@@ -1,6 +1,7 @@
-import { isDefined } from 'src/utils/is-defined';
-import { isWorkEmail } from 'src/utils/is-work-email';
+import { isDefined } from 'twenty-shared';
+
 import { getDomainNameByEmail } from 'src/utils/get-domain-name-by-email';
+import { isWorkEmail } from 'src/utils/is-work-email';
 
 export const getSubdomainFromEmail = (email?: string) => {
   if (!isDefined(email) || !isWorkEmail(email)) return;

packages/twenty-server/src/engine/core-modules/domain-manager/utils/get-subdomain-name-from-display-name.ts

@@ -1,4 +1,4 @@
-import { isDefined } from 'src/utils/is-defined';
+import { isDefined } from 'twenty-shared';
 
 export const getSubdomainNameFromDisplayName = (displayName?: string) => {
   if (!isDefined(displayName)) return;

packages/twenty-server/src/engine/core-modules/feature-flag/validates/feature-flag.validate.ts

@@ -1,6 +1,7 @@
+import { isDefined } from 'twenty-shared';
+
 import { FeatureFlagKey } from 'src/engine/core-modules/feature-flag/enums/feature-flag-key.enum';
 import { CustomException } from 'src/utils/custom-exception';
-import { isDefined } from 'src/utils/is-defined';
 
 const assertIsFeatureFlagKey = (
   featureFlagKey: string,

packages/twenty-server/src/engine/core-modules/file-storage/drivers/s3.driver.ts

@@ -1,7 +1,7 @@
-import { Readable } from 'stream';
 import fs from 'fs';
 import { mkdir } from 'fs/promises';
 import { join } from 'path';
+import { Readable } from 'stream';
 import { pipeline } from 'stream/promises';
 
 import {
@@ -18,14 +18,13 @@ import {
   S3,
   S3ClientConfig,
 } from '@aws-sdk/client-s3';
+import { isDefined } from 'twenty-shared';
 
+import { StorageDriver } from 'src/engine/core-modules/file-storage/drivers/interfaces/storage-driver.interface';
 import {
   FileStorageException,
   FileStorageExceptionCode,
 } from 'src/engine/core-modules/file-storage/interfaces/file-storage-exception';
-import { StorageDriver } from 'src/engine/core-modules/file-storage/drivers/interfaces/storage-driver.interface';
-
-import { isDefined } from 'src/utils/is-defined';
 
 export interface S3DriverOptions extends S3ClientConfig {
   bucketName: string;

packages/twenty-server/src/engine/core-modules/jwt/services/jwt-wrapper.service.ts

@@ -4,13 +4,13 @@ import { JwtService, JwtSignOptions, JwtVerifyOptions } from '@nestjs/jwt';
 import { createHash } from 'crypto';
 
 import * as jwt from 'jsonwebtoken';
+import { isDefined } from 'twenty-shared';
 
 import {
   AuthException,
   AuthExceptionCode,
 } from 'src/engine/core-modules/auth/auth.exception';
 import { EnvironmentService } from 'src/engine/core-modules/environment/environment.service';
-import { isDefined } from 'src/utils/is-defined';
 
 export type WorkspaceTokenType =
   | 'ACCESS'

packages/twenty-server/src/engine/core-modules/serverless/drivers/lambda.driver.ts

@@ -1,7 +1,6 @@
 import * as fs from 'fs/promises';
 import { join } from 'path';
 
-import dotenv from 'dotenv';
 import {
   CreateFunctionCommand,
   DeleteFunctionCommand,
@@ -10,49 +9,50 @@ import {
   InvokeCommandInput,
   Lambda,
   LambdaClientConfig,
+  ListLayerVersionsCommand,
+  ListLayerVersionsCommandInput,
   PublishLayerVersionCommand,
   PublishLayerVersionCommandInput,
   PublishVersionCommand,
   PublishVersionCommandInput,
   ResourceNotFoundException,
   UpdateFunctionCodeCommand,
-  waitUntilFunctionUpdatedV2,
-  ListLayerVersionsCommandInput,
-  ListLayerVersionsCommand,
   UpdateFunctionConfigurationCommand,
   UpdateFunctionConfigurationCommandInput,
+  waitUntilFunctionUpdatedV2,
 } from '@aws-sdk/client-lambda';
 import { CreateFunctionCommandInput } from '@aws-sdk/client-lambda/dist-types/commands/CreateFunctionCommand';
 import { UpdateFunctionCodeCommandInput } from '@aws-sdk/client-lambda/dist-types/commands/UpdateFunctionCodeCommand';
+import dotenv from 'dotenv';
+import { isDefined } from 'twenty-shared';
 
 import {
   ServerlessDriver,
   ServerlessExecuteResult,
 } from 'src/engine/core-modules/serverless/drivers/interfaces/serverless-driver.interface';
 
+import { FileStorageService } from 'src/engine/core-modules/file-storage/file-storage.service';
+import { COMMON_LAYER_NAME } from 'src/engine/core-modules/serverless/drivers/constants/common-layer-name';
+import { ENV_FILE_NAME } from 'src/engine/core-modules/serverless/drivers/constants/env-file-name';
+import { OUTDIR_FOLDER } from 'src/engine/core-modules/serverless/drivers/constants/outdir-folder';
+import { SERVERLESS_TMPDIR_FOLDER } from 'src/engine/core-modules/serverless/drivers/constants/serverless-tmpdir-folder';
+import { compileTypescript } from 'src/engine/core-modules/serverless/drivers/utils/compile-typescript';
+import { copyAndBuildDependencies } from 'src/engine/core-modules/serverless/drivers/utils/copy-and-build-dependencies';
+import { createZipFile } from 'src/engine/core-modules/serverless/drivers/utils/create-zip-file';
+import {
+  LambdaBuildDirectoryManager,
+  NODE_LAYER_SUBFOLDER,
+} from 'src/engine/core-modules/serverless/drivers/utils/lambda-build-directory-manager';
+import { getServerlessFolder } from 'src/engine/core-modules/serverless/utils/serverless-get-folder.utils';
+import { ServerlessFunctionExecutionStatus } from 'src/engine/metadata-modules/serverless-function/dtos/serverless-function-execution-result.dto';
 import {
   ServerlessFunctionEntity,
   ServerlessFunctionRuntime,
 } from 'src/engine/metadata-modules/serverless-function/serverless-function.entity';
-import {
-  LambdaBuildDirectoryManager,
-  NODE_LAYER_SUBFOLDER,
-} from 'src/engine/core-modules/serverless/drivers/utils/lambda-build-directory-manager';
-import { FileStorageService } from 'src/engine/core-modules/file-storage/file-storage.service';
-import { createZipFile } from 'src/engine/core-modules/serverless/drivers/utils/create-zip-file';
-import { ServerlessFunctionExecutionStatus } from 'src/engine/metadata-modules/serverless-function/dtos/serverless-function-execution-result.dto';
 import {
   ServerlessFunctionException,
   ServerlessFunctionExceptionCode,
 } from 'src/engine/metadata-modules/serverless-function/serverless-function.exception';
-import { isDefined } from 'src/utils/is-defined';
-import { COMMON_LAYER_NAME } from 'src/engine/core-modules/serverless/drivers/constants/common-layer-name';
-import { copyAndBuildDependencies } from 'src/engine/core-modules/serverless/drivers/utils/copy-and-build-dependencies';
-import { getServerlessFolder } from 'src/engine/core-modules/serverless/utils/serverless-get-folder.utils';
-import { SERVERLESS_TMPDIR_FOLDER } from 'src/engine/core-modules/serverless/drivers/constants/serverless-tmpdir-folder';
-import { compileTypescript } from 'src/engine/core-modules/serverless/drivers/utils/compile-typescript';
-import { ENV_FILE_NAME } from 'src/engine/core-modules/serverless/drivers/constants/env-file-name';
-import { OUTDIR_FOLDER } from 'src/engine/core-modules/serverless/drivers/constants/outdir-folder';
 
 const UPDATE_FUNCTION_DURATION_TIMEOUT_IN_SECONDS = 60;
 

packages/twenty-server/src/engine/core-modules/user/user.validate.ts

@@ -1,10 +1,11 @@
+import { isDefined } from 'twenty-shared';
+
 import { User } from 'src/engine/core-modules/user/user.entity';
-import { CustomException } from 'src/utils/custom-exception';
-import { isDefined } from 'src/utils/is-defined';
 import {
   UserException,
   UserExceptionCode,
 } from 'src/engine/core-modules/user/user.exception';
+import { CustomException } from 'src/utils/custom-exception';
 
 const assertIsDefinedOrThrow = (
   user: User | undefined | null,

packages/twenty-server/src/engine/core-modules/workspace/services/workspace.service.ts

@@ -4,11 +4,12 @@ import { InjectRepository } from '@nestjs/typeorm';
 import assert from 'assert';
 
 import { TypeOrmQueryService } from '@ptc-org/nestjs-query-typeorm';
-import { WorkspaceActivationStatus } from 'twenty-shared';
+import { WorkspaceActivationStatus, isDefined } from 'twenty-shared';
 import { Repository } from 'typeorm';
 
 import { BillingSubscriptionService } from 'src/engine/core-modules/billing/services/billing-subscription.service';
 import { BillingService } from 'src/engine/core-modules/billing/services/billing.service';
+import { DomainManagerService } from 'src/engine/core-modules/domain-manager/services/domain-manager.service';
 import { EnvironmentService } from 'src/engine/core-modules/environment/environment.service';
 import { FeatureFlagService } from 'src/engine/core-modules/feature-flag/services/feature-flag.service';
 import { UserWorkspace } from 'src/engine/core-modules/user-workspace/user-workspace.entity';
@@ -23,8 +24,6 @@ import {
 import { workspaceValidator } from 'src/engine/core-modules/workspace/workspace.validate';
 import { WorkspaceManagerService } from 'src/engine/workspace-manager/workspace-manager.service';
 import { DEFAULT_FEATURE_FLAGS } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/default-feature-flags';
-import { isDefined } from 'src/utils/is-defined';
-import { DomainManagerService } from 'src/engine/core-modules/domain-manager/services/domain-manager.service';
 
 @Injectable()
 // eslint-disable-next-line @nx/workspace-inject-workspace-repository

packages/twenty-server/src/engine/core-modules/workspace/utils/get-auth-providers-by-workspace.util.ts

@@ -1,7 +1,8 @@
+import { isDefined } from 'twenty-shared';
+
 import { SSOIdentityProviderStatus } from 'src/engine/core-modules/sso/workspace-sso-identity-provider.entity';
 import { AuthProviders } from 'src/engine/core-modules/workspace/dtos/public-workspace-data-output';
 import { Workspace } from 'src/engine/core-modules/workspace/workspace.entity';
-import { isDefined } from 'src/utils/is-defined';
 
 export const getAuthProvidersByWorkspace = ({
   workspace,

packages/twenty-server/src/engine/core-modules/workspace/workspace.resolver.ts

@@ -11,11 +11,13 @@ import { InjectRepository } from '@nestjs/typeorm';
 
 import { FileUpload, GraphQLUpload } from 'graphql-upload';
 import { Repository } from 'typeorm';
+import { isDefined } from 'twenty-shared';
 
 import { FileFolder } from 'src/engine/core-modules/file/interfaces/file-folder.interface';
 
 import { BillingSubscription } from 'src/engine/core-modules/billing/entities/billing-subscription.entity';
 import { BillingSubscriptionService } from 'src/engine/core-modules/billing/services/billing-subscription.service';
+import { CustomHostnameDetails } from 'src/engine/core-modules/domain-manager/dtos/custom-hostname-details';
 import { DomainManagerService } from 'src/engine/core-modules/domain-manager/services/domain-manager.service';
 import { EnvironmentService } from 'src/engine/core-modules/environment/environment.service';
 import { FeatureFlagKey } from 'src/engine/core-modules/feature-flag/enums/feature-flag-key.enum';
@@ -42,9 +44,7 @@ import { UserAuthGuard } from 'src/engine/guards/user-auth.guard';
 import { WorkspaceAuthGuard } from 'src/engine/guards/workspace-auth.guard';
 import { GraphqlValidationExceptionFilter } from 'src/filters/graphql-validation-exception.filter';
 import { assert } from 'src/utils/assert';
-import { isDefined } from 'src/utils/is-defined';
 import { streamToBuffer } from 'src/utils/stream-to-buffer';
-import { CustomHostnameDetails } from 'src/engine/core-modules/domain-manager/dtos/custom-hostname-details';
 
 import { Workspace } from './workspace.entity';