[CHORE] Avoid isDefined duplicated reference, move it to twenty-shared (#9967)
# Introduction Avoid having multiple `isDefined` definition across our pacakges Also avoid importing `isDefined` from `twenty-ui` which exposes a huge barrel for a such little util function ## In a nutshell Removed own `isDefined.ts` definition from `twenty-ui` `twenty-front` and `twenty-server` to move it to `twenty-shared`. Updated imports for each packages, and added explicit dependencies to `twenty-shared` if not already in place Related PR https://github.com/twentyhq/twenty/pull/9941
This commit is contained in:
@ -1,6 +1,6 @@
|
||||
import styled from '@emotion/styled';
|
||||
import { isDefined } from '@ui/utilities';
|
||||
import { ReactNode, useLayoutEffect, useRef, useState } from 'react';
|
||||
import { isDefined } from 'twenty-shared';
|
||||
|
||||
type ComputeNodeDimensionsProps = {
|
||||
children: (
|
||||
|
||||
@ -10,7 +10,6 @@ export * from './device/getOsControlSymbol';
|
||||
export * from './device/getOsShortcutSeparator';
|
||||
export * from './device/getUserDevice';
|
||||
export * from './dimensions/components/ComputeNodeDimensions';
|
||||
export * from './isDefined';
|
||||
export * from './responsive/hooks/useIsMobile';
|
||||
export * from './screen-size/hooks/useScreenSize';
|
||||
export * from './state/utils/createState';
|
||||
|
||||
@ -1,4 +0,0 @@
|
||||
import { isNull, isUndefined } from '@sniptt/guards';
|
||||
|
||||
export const isDefined = <T>(value: T | null | undefined): value is T =>
|
||||
!isUndefined(value) && !isNull(value);
|
||||
@ -1,5 +1,5 @@
|
||||
import { LinkType } from '@ui/navigation/link';
|
||||
import { isDefined } from '../isDefined';
|
||||
import { isDefined } from 'twenty-shared';
|
||||
|
||||
type getUrlDisplayValueByUrlTypeProps = {
|
||||
type: LinkType;
|
||||
|
||||
Reference in New Issue
Block a user