admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

quick fix for positionInViewFilterGroup (#9223)

Browse Source 
fix 9206

In the future, we should have a look at the column naming
"positionInViewFilterGroup"
because it breaks the SQL queries in `record-position-query.factory.ts`
for viewFilter tablenames
This commit is contained in:
Guillim
2024-12-24 11:49:50 +01:00
committed by GitHub
parent b52c23bb66
commit 801bf7c016
2 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/twenty-server/src/engine/api/graphql/workspace-query-runner/factories/__tests__/query-runner-args.factory.spec.ts
View File

@ -22,34 +22,34 @@ describe('QueryRunnerArgsFactory', () => {
{ {
type: FieldMetadataType.POSITION, type: FieldMetadataType.POSITION,
isCustom: true, isCustom: true,
nameSingular: 'position', name: 'position',
}, },
{ {
type: FieldMetadataType.NUMBER, type: FieldMetadataType.NUMBER,
isCustom: true, isCustom: true,
nameSingular: 'testNumber', name: 'testNumber',
}, },
{ {
type: FieldMetadataType.TEXT, type: FieldMetadataType.TEXT,
isCustom: true, isCustom: true,
nameSingular: 'otherField', name: 'otherField',
}, },
], ],
fieldsByName: { fieldsByName: {
position: { position: {
type: FieldMetadataType.POSITION, type: FieldMetadataType.POSITION,
isCustom: true, isCustom: true,
nameSingular: 'position', name: 'position',
}, },
testNumber: { testNumber: {
type: FieldMetadataType.NUMBER, type: FieldMetadataType.NUMBER,
isCustom: true, isCustom: true,
nameSingular: 'testNumber', name: 'testNumber',
}, },
otherField: { otherField: {
type: FieldMetadataType.TEXT, type: FieldMetadataType.TEXT,
isCustom: true, isCustom: true,
nameSingular: 'otherField', name: 'otherField',
}, },
} as unknown as FieldMetadataMap, } as unknown as FieldMetadataMap,
}, },

4
packages/twenty-server/src/engine/api/graphql/workspace-query-runner/factories/query-runner-args.factory.ts
View File

@ -40,7 +40,9 @@ export class QueryRunnerArgsFactory {
const shouldBackfillPosition = const shouldBackfillPosition =
options.objectMetadataItemWithFieldMaps.fields.some( options.objectMetadataItemWithFieldMaps.fields.some(
(field) => field.type === FieldMetadataType.POSITION, (field) =>
field.type === FieldMetadataType.POSITION &&
field.name === 'position',
); );
switch (resolverArgsType) { switch (resolverArgsType) {