follow up #12033

in #12033, SettingsDataModelFieldRelationForm I changed the the use of
objectMetadataItems to activeObjectMetadataItems, which filtered out
system objects. The naming was one factor for this confusion
Renaming it everywhere to specify that they don't include system objects

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
This commit is contained in:
nitin
2025-05-21 15:15:33 +05:30
committed by GitHub
parent c29ed1c0c9
commit 819b3c6c0d
21 changed files with 116 additions and 107 deletions

View File

@ -10,10 +10,10 @@ import { useLingui } from '@lingui/react/macro';
export const NavigationDrawerOpenedSection = () => {
const { t } = useLingui();
const { activeObjectMetadataItems } = useFilteredObjectMetadataItems();
const filteredActiveObjectMetadataItems = activeObjectMetadataItems.filter(
(item) => !item.isRemote,
);
const { activeNonSystemObjectMetadataItems } =
useFilteredObjectMetadataItems();
const filteredActiveNonSystemObjectMetadataItems =
activeNonSystemObjectMetadataItems.filter((item) => !item.isRemote);
const loading = useIsPrefetchLoading();
@ -28,7 +28,7 @@ export const NavigationDrawerOpenedSection = () => {
return;
}
const objectMetadataItem = filteredActiveObjectMetadataItems.find(
const objectMetadataItem = filteredActiveNonSystemObjectMetadataItems.find(
(item) =>
item.namePlural === currentObjectNamePlural ||
item.nameSingular === currentObjectNameSingular,

View File

@ -10,10 +10,10 @@ import { isDefined } from 'twenty-shared/utils';
export const RemoteNavigationDrawerSection = () => {
const currentUser = useRecoilValue(currentUserState);
const { activeObjectMetadataItems } = useFilteredObjectMetadataItems();
const filteredActiveObjectMetadataItems = activeObjectMetadataItems.filter(
(item) => item.isRemote,
);
const { activeNonSystemObjectMetadataItems } =
useFilteredObjectMetadataItems();
const filteredActiveNonSystemObjectMetadataItems =
activeNonSystemObjectMetadataItems.filter((item) => item.isRemote);
const loading = useIsPrefetchLoading();
if (loading && isDefined(currentUser)) {
@ -23,7 +23,7 @@ export const RemoteNavigationDrawerSection = () => {
return (
<NavigationDrawerSectionForObjectMetadataItems
sectionTitle={'Remote'}
objectMetadataItems={filteredActiveObjectMetadataItems}
objectMetadataItems={filteredActiveNonSystemObjectMetadataItems}
isRemote={true}
/>
);