admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix table fetchMore flakyness (#12702)

Browse Source 
Remove useless debounce + using cacheFirst for fetchMore as fetchingMore
will trigger initial fetch if not already performed
This commit is contained in:
Charles Bochet
2025-06-18 15:37:22 +02:00
committed by GitHub
parent 56d934872d
commit 82876bb7d1
2 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/twenty-front/src/modules/object-record/hooks/useLazyFindManyRecords.ts
View File

@ -65,7 +65,7 @@ export const useLazyFindManyRecords = <T extends ObjectRecord = ObjectRecord>({
limit, limit,
orderBy, orderBy,
}, },
fetchPolicy: 'network-only', fetchPolicy: 'cache-first',
onCompleted: handleFindManyRecordsCompleted, onCompleted: handleFindManyRecordsCompleted,
onError: handleFindManyRecordsError, onError: handleFindManyRecordsError,
}); });

7
packages/twenty-front/src/modules/object-record/record-table/record-table-body/components/RecordTableBodyFetchMoreLoader.tsx
View File

@ -9,7 +9,6 @@ import { isFetchingMoreRecordsFamilyState } from '@/object-record/states/isFetch
import { useScrollWrapperElement } from '@/ui/utilities/scroll/hooks/useScrollWrapperElement'; import { useScrollWrapperElement } from '@/ui/utilities/scroll/hooks/useScrollWrapperElement';
import { useRecoilComponentValueV2 } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValueV2'; import { useRecoilComponentValueV2 } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValueV2';
import { GRAY_SCALE } from 'twenty-ui/theme'; import { GRAY_SCALE } from 'twenty-ui/theme';
import { useDebouncedCallback } from 'use-debounce';
const StyledText = styled.div` const StyledText = styled.div`
align-items: center; align-items: center;
@ -38,10 +37,6 @@ export const RecordTableBodyFetchMoreLoader = () => {
); );
const showLoadingMoreRow = !hasRecordTableFetchedAllRecordsComponents; const showLoadingMoreRow = !hasRecordTableFetchedAllRecordsComponents;
const debouncedFetchMoreRecordsLazy = useDebouncedCallback(
fetchMoreRecordsLazy,
100,
);
const { ref: tbodyRef } = useInView({ const { ref: tbodyRef } = useInView({
onChange: async (inView) => { onChange: async (inView) => {
@ -50,7 +45,7 @@ export const RecordTableBodyFetchMoreLoader = () => {
} }
setIsFetchingMoreRecords(true); setIsFetchingMoreRecords(true);
await debouncedFetchMoreRecordsLazy(); await fetchMoreRecordsLazy();
setIsFetchingMoreRecords(false); setIsFetchingMoreRecords(false);
}, },
delay: 1000, delay: 1000,