From 85a17a54b36faa50c5fa5e93bcd2dabf9f9dee33 Mon Sep 17 00:00:00 2001 From: Paul Rastoin <45004772+prastoin@users.noreply.github.com> Date: Wed, 21 May 2025 16:01:03 +0200 Subject: [PATCH] Do not upgrade if no migrate (#12187) --- .../upgrade-version-command/upgrade.command.ts | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/upgrade.command.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/upgrade.command.ts index 102cc5466..a52637914 100644 --- a/packages/twenty-server/src/database/commands/upgrade-version-command/upgrade.command.ts +++ b/packages/twenty-server/src/database/commands/upgrade-version-command/upgrade.command.ts @@ -4,6 +4,7 @@ import { InjectRepository } from '@nestjs/typeorm'; import { exec } from 'child_process'; import { promisify } from 'util'; +import chalk from 'chalk'; import { Command } from 'nest-commander'; import { WorkspaceActivationStatus } from 'twenty-shared/workspace'; import { In, Repository } from 'typeorm'; @@ -278,17 +279,18 @@ export class UpgradeCommand extends UpgradeCommandRunner { passedParams: string[], options: ActiveOrSuspendedWorkspacesMigrationCommandOptions, ): Promise { - // Only run migrations if we have at least one workspace on version 0.53 const shouldRunMigrateAsPartOfUpgrade = await this.databaseMigrationService.shouldRunMigrationsIfAllWorkspaceAreAboveVersion0_53(); - if (shouldRunMigrateAsPartOfUpgrade) { - await this.databaseMigrationService.runMigrations(); - } else { - this.logger.log('Skipping database migrations.'); + if (!shouldRunMigrateAsPartOfUpgrade) { + this.logger.log( + chalk.red( + 'Not able to run migrate command, aborting the whole migrate-upgrade operation', + ), + ); + throw new Error('Could not run migration aborting'); } - // Continue with the regular upgrade process await super.runMigrationCommand(passedParams, options); } }