Fix API key not displayed (#9766)

Fixes #9761

Instead of cleaning RecoilState we should keep the api key visible as
long as the user didn't refresh/leave the app, it's better from a UX
perspective and the code is also more elegant, removing a useEffect


Note: the root cause of the bug was a missing "/settings" path in
isMatchingLocation in useCleaningRecoilState (due to the recent
refactoring) ; but I think this fix is better
This commit is contained in:
Félix Malfait
2025-01-21 14:18:22 +01:00
committed by GitHub
parent 8e0467e2e4
commit 86b0a7952b
25 changed files with 363 additions and 377 deletions

View File

@ -17,7 +17,7 @@ msgstr ""
#~ msgid "{0}"
#~ msgstr "{0}"
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:163
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:174
msgid "{apiKeyName} API Key"
msgstr "{apiKeyName} API Key"
@ -118,8 +118,8 @@ msgstr "An optional description"
msgid "API & Webhooks"
msgstr "API & Webhooks"
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:171
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:182
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:190
msgid "API Key"
msgstr "API Key"
@ -301,9 +301,13 @@ msgstr "Copilot"
msgid "Copy invitation link"
msgstr "Copy invitation link"
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:183
msgid "Copy this key as it will not be visible again"
msgstr "Copy this key as it will not be visible again"
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:172
msgid "Copy this key as it will only be visible this one time"
msgstr "Copy this key as it will only be visible this one time"
#~ msgid "Copy this key as it will only be visible this one time"
#~ msgstr "Copy this key as it will only be visible this one time"
#: src/pages/settings/developers/SettingsDevelopers.tsx:56
msgid "Create API key"
@ -334,7 +338,7 @@ msgid "Customize your workspace security"
msgstr "Customize your workspace security"
#: src/pages/settings/developers/webhooks/components/SettingsDevelopersWebhookDetail.tsx:341
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:229
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:237
#: src/pages/settings/data-model/SettingsObjectFieldEdit.tsx:250
#: src/modules/settings/profile/components/DeleteWorkspace.tsx:30
#: src/modules/settings/profile/components/DeleteAccount.tsx:29
@ -367,7 +371,7 @@ msgid "Define the name and description of your object"
msgstr "Define the name and description of your object"
#: src/pages/settings/developers/webhooks/components/SettingsDevelopersWebhookDetail.tsx:347
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:235
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:243
msgid "Delete"
msgstr "Delete"
@ -381,12 +385,12 @@ msgstr "Delete account"
msgid "Delete account and all the associated data"
msgstr "Delete account and all the associated data"
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:248
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:256
msgid "Delete API key"
msgstr "Delete API key"
#: src/pages/settings/developers/webhooks/components/SettingsDevelopersWebhookDetail.tsx:342
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:230
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:238
msgid "Delete this integration"
msgstr "Delete this integration"
@ -414,8 +418,8 @@ msgstr "Description"
#: src/pages/settings/developers/SettingsDevelopers.tsx:42
#: src/pages/settings/developers/webhooks/components/SettingsDevelopersWebhooksNew.tsx:78
#: src/pages/settings/developers/webhooks/components/SettingsDevelopersWebhookDetail.tsx:220
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeysNew.tsx:78
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:160
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeysNew.tsx:89
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:171
msgid "Developers"
msgstr "Developers"
@ -430,8 +434,8 @@ msgstr "Display as relative date"
msgid "Domain"
msgstr "Domain"
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeysNew.tsx:97
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:217
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeysNew.tsx:108
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:225
msgid "E.g. backoffice integration"
msgstr "E.g. backoffice integration"
@ -492,11 +496,11 @@ msgstr "Enjoy a {withCreditCardTrialPeriodDuration}-days free trial"
msgid "Enterprise"
msgstr "Enterprise"
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:87
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:98
msgid "Error deleting api key: {err}"
msgstr "Error deleting api key: {err}"
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:139
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:150
msgid "Error regenerating api key: {err}"
msgstr "Error regenerating api key: {err}"
@ -534,11 +538,11 @@ msgstr "Exit Settings"
msgid "Experience"
msgstr "Experience"
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:213
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:221
msgid "Expiration"
msgstr "Expiration"
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeysNew.tsx:115
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeysNew.tsx:126
msgid "Expiration Date"
msgstr "Expiration Date"
@ -607,7 +611,7 @@ msgstr "Grant Twenty support temporary access to your workspace so we can troubl
msgid "Icon and Name"
msgstr "Icon and Name"
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:267
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:275
msgid "If youve lost this key, you can regenerate it, but be aware that any script using this key will need to be updated. Please type\"{confirmationValue}\" to confirm."
msgstr "If youve lost this key, you can regenerate it, but be aware that any script using this key will need to be updated. Please type\"{confirmationValue}\" to confirm."
@ -717,14 +721,14 @@ msgstr "Members"
#: src/pages/settings/SettingsWorkspaceMembers.tsx:177
#: src/pages/settings/SettingsWorkspace.tsx:44
#: src/pages/settings/SettingsProfile.tsx:35
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeysNew.tsx:95
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:203
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeysNew.tsx:106
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:211
#: src/modules/settings/workspace/components/NameField.tsx:91
msgid "Name"
msgstr "Name"
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeysNew.tsx:95
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:203
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeysNew.tsx:106
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:211
msgid "Name of your API key"
msgstr "Name of your API key"
@ -744,11 +748,11 @@ msgstr "New"
msgid "New account"
msgstr "New account"
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeysNew.tsx:71
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeysNew.tsx:82
msgid "New key"
msgstr "New key"
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeysNew.tsx:81
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeysNew.tsx:92
msgid "New Key"
msgstr "New Key"
@ -832,7 +836,7 @@ msgstr "Picture"
msgid "Please enter a valid URL"
msgstr "Please enter a valid URL"
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:250
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:258
msgid "Please type \"{confirmationValue}\" to confirm you want to delete this API Key. Be aware that any script using this key will stop working."
msgstr "Please type \"{confirmationValue}\" to confirm you want to delete this API Key. Be aware that any script using this key will stop working."
@ -871,16 +875,16 @@ msgstr "Receive an email containing password update link"
msgid "Record Selection"
msgstr "Record Selection"
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:183
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:265
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:191
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:273
msgid "Regenerate an API key"
msgstr "Regenerate an API key"
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:274
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:282
msgid "Regenerate key"
msgstr "Regenerate key"
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:187
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:195
msgid "Regenerate Key"
msgstr "Regenerate Key"
@ -1163,11 +1167,11 @@ msgstr "Webhook"
msgid "Webhooks"
msgstr "Webhooks"
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeysNew.tsx:116
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeysNew.tsx:127
msgid "When the API key will expire."
msgstr "When the API key will expire."
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:214
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:222
msgid "When the key will be disabled"
msgstr "When the key will be disabled"
@ -1189,8 +1193,8 @@ msgstr "Workflows"
#: src/pages/settings/developers/SettingsDevelopers.tsx:39
#: src/pages/settings/developers/webhooks/components/SettingsDevelopersWebhooksNew.tsx:74
#: src/pages/settings/developers/webhooks/components/SettingsDevelopersWebhookDetail.tsx:216
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeysNew.tsx:74
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:156
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeysNew.tsx:85
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:167
#: src/pages/settings/data-model/SettingsObjects.tsx:157
#: src/pages/settings/data-model/SettingsObjectFieldEdit.tsx:175
#: src/pages/settings/data-model/SettingsNewObject.tsx:72
@ -1209,7 +1213,7 @@ msgid "Write a description"
msgstr "Write a description"
#: src/pages/settings/developers/webhooks/components/SettingsDevelopersWebhookDetail.tsx:209
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:147
#: src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx:158
msgid "yes"
msgstr "yes"