admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Introduce ComponentState (#4386)

Browse Source 
* Proof of concept ComponentState

* Migrate to createState and createFamilyState

* Refactor

* Fix

* Fix tests

* Fix lint

* Fix tests

* Re-enable coverage
This commit is contained in:
Charles Bochet
2024-03-09 11:31:00 +01:00
committed by GitHub
parent 17511be0cf
commit 86c0f311f5
451 changed files with 1718 additions and 2557 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/twenty-front/src/modules/activities/components/ActivityBodyEditor.tsx
View File

@ -118,7 +118,7 @@ export const ActivityBodyEditor = ({
);
const [canCreateActivity, setCanCreateActivity] = useRecoilState(
canCreateActivityState,
canCreateActivityState(),
);
const slashMenuItems = getSlashMenu();

2
packages/twenty-front/src/modules/activities/components/ActivityComments.tsx
View File

@ -61,7 +61,7 @@ export const ActivityComments = ({
objectNameSingular: CoreObjectNameSingular.Comment,
});
const currentWorkspaceMember = useRecoilValue(currentWorkspaceMemberState);
const currentWorkspaceMember = useRecoilValue(currentWorkspaceMemberState());
const { records: comments } = useFindManyRecords({
objectNameSingular: CoreObjectNameSingular.Comment,

8
packages/twenty-front/src/modules/activities/components/ActivityEditorEffect.tsx
View File

@ -29,15 +29,15 @@ export const ActivityEditorEffect = ({
({ snapshot, set }) =>
() => {
const isUpsertingActivityInDB = snapshot
.getLoadable(isUpsertingActivityInDBState)
.getLoadable(isUpsertingActivityInDBState())
.getValue();
const canCreateActivity = snapshot
.getLoadable(canCreateActivityState)
.getLoadable(canCreateActivityState())
.getValue();
const isActivityInCreateMode = snapshot
.getLoadable(isActivityInCreateModeState)
.getLoadable(isActivityInCreateModeState())
.getValue();
const activityFromStore = snapshot
@ -71,7 +71,7 @@ export const ActivityEditorEffect = ({
deleteActivityFromCache(activity);
}
set(isActivityInCreateModeState, false);
set(isActivityInCreateModeState(), false);
} else if (isNonNullable(activity)) {
if (
activity.title !== activityTitle ||

2
packages/twenty-front/src/modules/activities/components/ActivityTitle.tsx
View File

@ -71,7 +71,7 @@ export const ActivityTitle = ({ activityId }: ActivityTitleProps) => {
const activity = activityInStore as Activity;
const [canCreateActivity, setCanCreateActivity] = useRecoilState(
canCreateActivityState,
canCreateActivityState(),
);
const { upsertActivity } = useUpsertActivity();