feat: disable atomic operation on nestjs graphql models (#751)

* feat: no atomic

* feat: update front not atomic operations

* feat: optional fields for person model & use proper gql type

* Fix bug display name

* Fix bug update user

* Fixed bug avatar URL

* Fixed display name on people cell

* Fix lint

* Fixed storybook display name

* Fix storybook requests

---------

Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>

front/src/testing/graphqlMocks.ts

@@ -4,7 +4,7 @@ import { graphql } from 'msw';
 import { CREATE_EVENT } from '@/analytics/queries';
 import { GET_CLIENT_CONFIG } from '@/client-config/queries';
 import { GET_COMPANIES } from '@/companies/queries';
-import { GET_PEOPLE, GET_PERSON, UPDATE_PERSON } from '@/people/queries';
+import { GET_PEOPLE, GET_PERSON, UPDATE_ONE_PERSON } from '@/people/queries';
 import { GET_PIPELINE_PROGRESS, GET_PIPELINES } from '@/pipeline/queries';
 import {
   SEARCH_COMPANY_QUERY,
@@ -134,17 +134,20 @@ export const graphqlMocks = [
       }),
     );
   }),
-  graphql.mutation(getOperationName(UPDATE_PERSON) ?? '', (req, res, ctx) => {
-    return res(
-      ctx.data({
-        updateOnePerson: updateOneFromData(
-          mockedPeopleData,
-          req.variables.id,
-          req.variables,
-        ),
-      }),
-    );
-  }),
+  graphql.mutation(
+    getOperationName(UPDATE_ONE_PERSON) ?? '',
+    (req, res, ctx) => {
+      return res(
+        ctx.data({
+          updateOnePerson: updateOneFromData(
+            mockedPeopleData,
+            req.variables.where.id,
+            req.variables,
+          ),
+        }),
+      );
+    },
+  ),
   graphql.query(getOperationName(GET_PIPELINES) ?? '', (req, res, ctx) => {
     return res(
       ctx.data({

front/src/testing/mock-data/comment-threads.ts

@@ -22,6 +22,7 @@ type MockedCommentThread = Pick<
     id: string;
     firstName: string;
     lastName: string;
+    displayName: string;
   };
   comments: Array<Pick<Comment, 'body'>>;
   commentThreadTargets: Array<
@@ -50,6 +51,7 @@ export const mockedCommentThreads: Array<MockedCommentThread> = [
       id: '374fe3a5-df1e-4119-afe0-2a62a2ba481e',
       firstName: 'Charles',
       lastName: 'Test',
+      displayName: 'Charles Test',
     },
     authorId: '374fe3a5-df1e-4119-afe0-2a62a2ba481e',
     comments: [],
@@ -96,6 +98,7 @@ export const mockedCommentThreads: Array<MockedCommentThread> = [
       id: '374fe3a5-df1e-4119-afe0-2a62a2ba481e',
       firstName: 'Charles',
       lastName: 'Test',
+      displayName: 'Charles Test',
     },
     authorId: '374fe3a5-df1e-4119-afe0-2a62a2ba481e',
     comments: [],

front/src/testing/mock-data/index.ts

@@ -7,6 +7,8 @@ import {
   UserOrderByWithRelationInput,
 } from '~/generated/graphql';
 
+import { isDefined } from '../../utils/isDefined';
+
 function filterData<DataT>(
   data: Array<DataT>,
   where: Record<string, any>,
@@ -135,15 +137,28 @@ export function fetchOneFromData<DataT extends { id: string }>(
   data: Array<DataT>,
   id: string,
 ): DataT | undefined {
+  if (!isDefined(id)) {
+    throw new Error(
+      `id is not defined in updateOneFromData, check that you provided where.id if needed.`,
+    );
+  }
+
   return data.filter((item) => item.id === id)[0];
 }
 
 export function updateOneFromData<DataT extends { id: string }>(
   data: Array<DataT>,
-  id: string,
+  id: string | undefined,
   payload: GraphQLVariables,
 ): DataT | undefined {
+  if (!isDefined(id)) {
+    throw new Error(
+      `id is not defined in updateOneFromData, check that you provided where.id if needed.`,
+    );
+  }
+
   const object = data.filter((item) => item.id === id)[0];
+
   const newObject = Object.assign(object, payload);
 
   return newObject;

front/src/testing/mock-data/people.ts

@@ -1,22 +1,28 @@
 import { Company, Person } from '~/generated/graphql';
 
-type MockedPerson = Pick<
-  Person,
-  | 'id'
-  | 'firstName'
-  | 'lastName'
-  | 'displayName'
-  | 'email'
-  | '__typename'
-  | 'phone'
-  | 'city'
-  | '_commentThreadCount'
-  | 'createdAt'
-> & {
-  company: Pick<Company, 'id' | 'name' | 'domainName' | '__typename'>;
+type RequiredAndNotNull<T> = {
+  [P in keyof T]-?: Exclude<T[P], null | undefined>;
 };
 
-export const mockedPeopleData: Array<MockedPerson> = [
+type MockedPerson = RequiredAndNotNull<
+  Pick<
+    Person,
+    | 'id'
+    | 'firstName'
+    | 'lastName'
+    | 'displayName'
+    | 'email'
+    | '__typename'
+    | 'phone'
+    | 'city'
+    | '_commentThreadCount'
+    | 'createdAt'
+  > & {
+    company: Pick<Company, 'id' | 'name' | 'domainName' | '__typename'>;
+  }
+>;
+
+export const mockedPeopleData: MockedPerson[] = [
   {
     id: '7dfbc3f7-6e5e-4128-957e-8d86808cdf6b',
     __typename: 'Person',