[ESLint rule]: recoil value and setter should be named after their at… (#1402)

* Override unwanted changes

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>
Co-authored-by: Rafael Toledo <87545086+Toledodev@users.noreply.github.com>

* Fix the tests

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>
Co-authored-by: Rafael Toledo <87545086+Toledodev@users.noreply.github.com>

---------

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>
Co-authored-by: Rafael Toledo <87545086+Toledodev@users.noreply.github.com>
Co-authored-by: Charles Bochet <charlesBochet@users.noreply.github.com>
This commit is contained in:
gitstart-twenty
2023-09-05 11:34:11 +03:00
committed by GitHub
parent 0ec4b78aee
commit 878302dd31
52 changed files with 400 additions and 281 deletions

View File

@ -14,12 +14,11 @@ export type OwnProps = {
};
export function CompanyPicker({ companyId, onSubmit, onCancel }: OwnProps) {
const [searchFilter, setSearchFilter] = useRecoilScopedState(
relationPickerSearchFilterScopedState,
);
const [relationPickerSearchFilter, setRelationPickerSearchFilter] =
useRecoilScopedState(relationPickerSearchFilterScopedState);
const companies = useFilteredSearchCompanyQuery({
searchFilter,
searchFilter: relationPickerSearchFilter,
selectedIds: companyId ? [companyId] : [],
});
@ -30,8 +29,8 @@ export function CompanyPicker({ companyId, onSubmit, onCancel }: OwnProps) {
}
useEffect(() => {
setSearchFilter('');
}, [setSearchFilter]);
setRelationPickerSearchFilter('');
}, [setRelationPickerSearchFilter]);
return (
<SingleEntitySelect

View File

@ -29,20 +29,20 @@ export function CompanyPickerCell({
createModeEnabled,
width,
}: OwnProps) {
const [isCreating, setIsCreating] = useRecoilScopedState(
const [isCreateMode, setIsCreateMode] = useRecoilScopedState(
isCreateModeScopedState,
);
const [insertCompany] = useInsertOneCompanyMutation();
const [searchFilter] = useRecoilScopedState(
const [relationPickerSearchFilter] = useRecoilScopedState(
relationPickerSearchFilterScopedState,
);
const setHotkeyScope = useSetHotkeyScope();
const companies = useFilteredSearchCompanyQuery({
searchFilter,
searchFilter: relationPickerSearchFilter,
selectedIds: [companyId ?? ''],
});
@ -53,7 +53,7 @@ export function CompanyPickerCell({
}
function handleStartCreation() {
setIsCreating(true);
setIsCreateMode(true);
setHotkeyScope(TableHotkeyScope.CellDoubleTextInput);
}
@ -75,7 +75,7 @@ export function CompanyPickerCell({
entityType: Entity.Company,
domainName: companyCreated.domainName,
});
setIsCreating(false);
setIsCreateMode(false);
}
const noCompany: CompanyPickerSelectedCompany = {
entityType: Entity.Company,
@ -85,9 +85,9 @@ export function CompanyPickerCell({
domainName: '',
avatarUrl: '',
};
return isCreating ? (
return isCreateMode ? (
<DoubleTextCellEdit
firstValue={searchFilter}
firstValue={relationPickerSearchFilter}
secondValue={''}
firstValuePlaceholder={'Name'}
secondValuePlaceholder={'Url'}

View File

@ -12,11 +12,9 @@ import { turnFilterIntoWhereClause } from '@/ui/filter-n-sort/utils/turnFilterIn
import { useRecoilScopedState } from '@/ui/utilities/recoil-scope/hooks/useRecoilScopedState';
import { useRecoilScopedValue } from '@/ui/utilities/recoil-scope/hooks/useRecoilScopedValue';
import {
Pipeline,
PipelineProgressableType,
PipelineProgressOrderByWithRelationInput as PipelineProgresses_Order_By,
} from '~/generated/graphql';
import {
Pipeline,
useGetCompaniesQuery,
useGetPipelineProgressQuery,
useGetPipelinesQuery,

View File

@ -53,10 +53,12 @@ export function NewCompanyProgressButton() {
setIsCreatingCard(false);
}
const [searchFilter] = useRecoilScopedState(
const [relationPickerSearchFilter] = useRecoilScopedState(
relationPickerSearchFilterScopedState,
);
const companies = useFilteredSearchCompanyQuery({ searchFilter });
const companies = useFilteredSearchCompanyQuery({
searchFilter: relationPickerSearchFilter,
});
return (
<RecoilScope>