[messaging] add better logs to messaging sync jobs (#4245)

packages/twenty-server/src/workspace/messaging/repositories/connected-account/connected-account.service.ts

@@ -60,7 +60,9 @@ export class ConnectedAccountService {
       );
 
     if (!connectedAccounts || connectedAccounts.length === 0) {
-      throw new NotFoundException('No connected account found');
+      throw new NotFoundException(
+        `No connected account found for id ${connectedAccountId} in workspace ${workspaceId}`,
+      );
     }
 
     return connectedAccounts[0];

packages/twenty-server/src/workspace/messaging/repositories/message-channel/message-channel.service.ts

@@ -38,7 +38,9 @@ export class MessageChannelService {
     );
 
     if (!messageChannels || messageChannels.length === 0) {
-      throw new Error('No message channel found');
+      throw new Error(
+        `No message channel found for connected account ${connectedAccountId} in workspace ${workspaceId}`,
+      );
     }
 
     return messageChannels[0];

packages/twenty-server/src/workspace/messaging/repositories/workspace-member/workspace-member.service.ts

@@ -44,7 +44,9 @@ export class WorkspaceMemberService {
       );
 
     if (!workspaceMembers || workspaceMembers.length === 0) {
-      throw new NotFoundException('No workspace member found');
+      throw new NotFoundException(
+        `No workspace member found for user ${userId} in workspace ${workspaceId}`,
+      );
     }
 
     return workspaceMembers[0];

packages/twenty-server/src/workspace/messaging/services/gmail-full-sync.service.ts

@@ -47,7 +47,9 @@ export class GmailFullSyncService {
     const workspaceMemberId = connectedAccount.accountOwnerId;
 
     if (!refreshToken) {
-      throw new Error('No refresh token found');
+      throw new Error(
+        `No refresh token found for connected account ${connectedAccountId} in workspace ${workspaceId} during full-sync`,
+      );
     }
 
     const gmailMessageChannel =
@@ -149,33 +151,36 @@ export class GmailFullSyncService {
       }ms.`,
     );
 
-    if (messagesToSave.length === 0) {
+    if (messagesToSave.length > 0) {
-      if (errors.length) throw new Error('Error fetching messages');
+      this.saveMessagesAndCreateContactsService.saveMessagesAndCreateContacts(
-
+        messagesToSave,
+        connectedAccount,
+        workspaceId,
+        gmailMessageChannelId,
+        'gmail full-sync',
+      );
+    } else {
       this.logger.log(
         `gmail full-sync for workspace ${workspaceId} and account ${connectedAccountId} done with nothing to import.`,
       );
-
-      return;
     }
 
-    this.saveMessagesAndCreateContactsService.saveMessagesAndCreateContacts(
+    if (errors.length) {
-      messagesToSave,
+      throw new Error(
-      connectedAccount,
+        `Error fetching messages for ${connectedAccountId} in workspace ${workspaceId} during full-sync`,
-      workspaceId,
+      );
-      gmailMessageChannelId,
+    }
-      'gmail full-sync',
-    );
-
-    if (errors.length) throw new Error('Error fetching messages');
-
     const lastModifiedMessageId = messagesToFetch[0];
 
     const historyId = messagesToSave.find(
       (message) => message.externalId === lastModifiedMessageId,
     )?.historyId;
 
-    if (!historyId) throw new Error('No history id found');
+    if (!historyId) {
+      throw new Error(
+        `No historyId found for ${connectedAccountId} in workspace ${workspaceId} during full-sync`,
+      );
+    }
 
     startTime = Date.now();
 

packages/twenty-server/src/workspace/messaging/services/gmail-partial-sync.service.ts

@@ -61,7 +61,9 @@ export class GmailPartialSyncService {
     const refreshToken = connectedAccount.refreshToken;
 
     if (!refreshToken) {
-      throw new Error('No refresh token found');
+      throw new Error(
+        `No refresh token found for connected account ${connectedAccountId} in workspace ${workspaceId} during partial-sync`,
+      );
     }
 
     let startTime = Date.now();
@@ -96,7 +98,9 @@ export class GmailPartialSyncService {
     }
 
     if (!historyId) {
-      throw new Error('No history id found');
+      throw new Error(
+        `No historyId found for ${connectedAccountId} in workspace ${workspaceId} during partial-sync`,
+      );
     }
 
     if (historyId === lastSyncHistoryId || !history?.length) {
@@ -173,8 +177,11 @@ export class GmailPartialSyncService {
       );
     }
 
-    if (errors.length) throw new Error('Error fetching messages');
+    if (errors.length) {
-
+      throw new Error(
+        `Error fetching messages for ${connectedAccountId} in workspace ${workspaceId} during partial-sync`,
+      );
+    }
     startTime = Date.now();
 
     await this.connectedAccountService.updateLastSyncHistoryId(

packages/twenty-server/src/workspace/messaging/services/gmail-refresh-access-token.service.ts

@@ -24,7 +24,9 @@ export class GmailRefreshAccessTokenService {
     const refreshToken = connectedAccount.refreshToken;
 
     if (!refreshToken) {
-      throw new Error('No refresh token found');
+      throw new Error(
+        `No refresh token found for connected account ${connectedAccountId} in workspace ${workspaceId}`,
+      );
     }
 
     const accessToken = await this.refreshAccessToken(refreshToken);