admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Refactor fast follow on column move feature (#1665)

Browse Source 
* Refactor fast follow on column move feature

* Fix lint
This commit is contained in:
Charles Bochet
2023-09-19 16:42:11 -07:00
committed by GitHub
parent cb05b1fbc9
commit 8c21dc8bba
12 changed files with 66 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
front/src/modules/views/hooks/useTableViewFields.ts
View File

@ -164,6 +164,7 @@ export const useTableViewFields = ({
(column) =>
savedTableColumnsByKey[column.key] &&
(savedTableColumnsByKey[column.key].size !== column.size ||
savedTableColumnsByKey[column.key].index !== column.index ||
savedTableColumnsByKey[column.key].isVisible !== column.isVisible),
);
await updateViewFields(viewFieldsToUpdate);
@ -178,5 +179,5 @@ export const useTableViewFields = ({
updateViewFields,
]);
return { createViewFields, persistColumns, updateViewFields };
return { createViewFields, persistColumns };
};

12
front/src/modules/views/hooks/useTableViews.ts
View File

@ -41,12 +41,11 @@ export const useTableViews = ({
type: ViewType.Table,
RecoilScopeContext: TableRecoilScopeContext,
});
const { createViewFields, persistColumns, updateViewFields } =
useTableViewFields({
objectId,
columnDefinitions,
skipFetch: isFetchingViews,
});
const { createViewFields, persistColumns } = useTableViewFields({
objectId,
columnDefinitions,
skipFetch: isFetchingViews,
});
const { createViewFilters, persistFilters } = useViewFilters({
RecoilScopeContext: TableRecoilScopeContext,
@ -62,7 +61,6 @@ export const useTableViews = ({
await persistColumns();
await persistFilters();
await persistSorts();
await updateViewFields(tableColumns);
};
return { createView, deleteView, submitCurrentView, updateView };