From 91b7d2855ea1ce2809c33f853cc60439e12bc4ec Mon Sep 17 00:00:00 2001 From: Mohammed Abdul Razak Wahab <60781022+mdrazak2001@users.noreply.github.com> Date: Mon, 17 Feb 2025 18:58:28 +0530 Subject: [PATCH] Fix: Ensure First Click on Spreadsheet Import 'Select File' Button Triggers File picker (#10205) Fixes #10154 ### What was happening: 1. Click "Import" in dropdown -> Dropdown stays open 2. Click "Select file" button -> Two events occur: - Button tries to open file dialog - Click event bubbles up, reaches dropdown, dropdown tries to close 3. These competing actions cause the first click to fail ### Fix By closing the dropdown immediately when clicking "Import": No competing event handlers are active The dropdown is fully closed before any file selector interactions The open() function from useDropzone can work without interference --- .../components/ObjectOptionsDropdownMenuContent.tsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/twenty-front/src/modules/object-record/object-options-dropdown/components/ObjectOptionsDropdownMenuContent.tsx b/packages/twenty-front/src/modules/object-record/object-options-dropdown/components/ObjectOptionsDropdownMenuContent.tsx index 41f3e4587..a2fb4c574 100644 --- a/packages/twenty-front/src/modules/object-record/object-options-dropdown/components/ObjectOptionsDropdownMenuContent.tsx +++ b/packages/twenty-front/src/modules/object-record/object-options-dropdown/components/ObjectOptionsDropdownMenuContent.tsx @@ -165,7 +165,10 @@ export const ObjectOptionsDropdownMenuContent = () => { text={displayedExportProgress(progress)} /> openObjectRecordsSpreasheetImportDialog()} + onClick={() => { + openObjectRecordsSpreasheetImportDialog(); + closeDropdown(); + }} LeftIcon={IconFileImport} text="Import" />