Remove timelineActivity featureFlag (#5856)

This commit is contained in:
Weiko
2024-06-13 17:39:31 +02:00
committed by GitHub
parent 21dbd6441a
commit 93c17a8a5b
6 changed files with 18 additions and 42 deletions

View File

@ -43,6 +43,7 @@ const StyledItemTitleDate = styled.div`
gap: ${({ theme }) => theme.spacing(2)};
justify-content: flex-end;
margin-left: auto;
align-self: baseline;
`;
const StyledVerticalLineContainer = styled.div`

View File

@ -38,6 +38,7 @@ export const useTimelineActivities = (
workspaceMember: true,
person: true,
},
fetchPolicy: 'cache-and-network',
});
return {

View File

@ -1,4 +1,5 @@
import styled from '@emotion/styled';
import { useRecoilState } from 'recoil';
import { useOpenActivityRightDrawer } from '@/activities/hooks/useOpenActivityRightDrawer';
import {
@ -6,6 +7,7 @@ import {
StyledEventRowItemAction,
StyledEventRowItemColumn,
} from '@/activities/timelineActivities/rows/components/EventRowDynamicComponent';
import { recordStoreFamilyState } from '@/object-record/record-store/states/recordStoreFamilyState';
type EventRowActivityProps = EventRowDynamicComponentProps;
@ -26,15 +28,23 @@ export const EventRowActivity = ({
throw new Error('Could not find linked record id for event');
}
const [activityInStore] = useRecoilState(
recordStoreFamilyState(event.linkedRecordId),
);
return (
<>
<StyledEventRowItemColumn>{authorFullName}</StyledEventRowItemColumn>
<StyledEventRowItemAction>{eventAction}</StyledEventRowItemAction>
<StyledLinkedActivity
onClick={() => openActivityRightDrawer(event.linkedRecordId)}
>
{event.linkedRecordCachedName}
</StyledLinkedActivity>
{activityInStore ? (
<StyledLinkedActivity
onClick={() => openActivityRightDrawer(event.linkedRecordId)}
>
{event.linkedRecordCachedName}
</StyledLinkedActivity>
) : (
<span>{event.linkedRecordCachedName}</span>
)}
</>
);
};

View File

@ -15,8 +15,6 @@ import { EmailThreads } from '@/activities/emails/components/EmailThreads';
import { Attachments } from '@/activities/files/components/Attachments';
import { Notes } from '@/activities/notes/components/Notes';
import { ObjectTasks } from '@/activities/tasks/components/ObjectTasks';
import { Timeline } from '@/activities/timeline/components/Timeline';
import { TimelineQueryEffect } from '@/activities/timeline/components/TimelineQueryEffect';
import { TimelineActivities } from '@/activities/timelineActivities/components/TimelineActivities';
import { TimelineActivitiesQueryEffect } from '@/activities/timelineActivities/components/TimelineActivitiesQueryEffect';
import { ActivityTargetableObject } from '@/activities/types/ActivityTargetableEntity';
@ -24,7 +22,6 @@ import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSi
import { TabList } from '@/ui/layout/tab/components/TabList';
import { useTabList } from '@/ui/layout/tab/hooks/useTabList';
import { useIsMobile } from '@/ui/utilities/responsive/hooks/useIsMobile';
import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled';
const StyledShowPageRightContainer = styled.div<{ isMobile: boolean }>`
display: flex;
@ -84,7 +81,6 @@ export const ShowPageRightContainer = ({
].includes(targetObjectNameSingular);
const shouldDisplayCalendarTab = isCompanyOrPerson;
const shouldDisplayLogTab = useIsFeatureEnabled('IS_EVENT_OBJECT_ENABLED');
const shouldDisplayEmailsTab = emails && isCompanyOrPerson;
const isMobile = useIsMobile() || isRightDrawer;
@ -122,18 +118,13 @@ export const ShowPageRightContainer = ({
const renderActiveTabContent = () => {
switch (activeTabId) {
case 'timeline':
return shouldDisplayLogTab ? (
return (
<>
<TimelineActivitiesQueryEffect
targetableObject={targetableObject}
/>
<TimelineActivities targetableObject={targetableObject} />
</>
) : (
<>
<TimelineQueryEffect targetableObject={targetableObject} />
<Timeline loading={loading} targetableObject={targetableObject} />
</>
);
case 'summary':
return summary;