From 9567103d5fb0c263564d78e3a1c101e455b8b7b6 Mon Sep 17 00:00:00 2001
From: Thomas Trompette <thomas.trompette@sfr.fr>
Date: Thu, 6 Jun 2024 11:00:46 +0200
Subject: [PATCH] Remove check unique position (#5760)

Currently position can be the same for records displayed in a board
view.
Removing unicity check until we find a new startegy.
---
 .../__tests__/record-position.factory.spec.ts      |  9 +--------
 .../factories/record-position.factory.ts           | 14 --------------
 2 files changed, 1 insertion(+), 22 deletions(-)

diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-query-runner/factories/__tests__/record-position.factory.spec.ts b/packages/twenty-server/src/engine/api/graphql/workspace-query-runner/factories/__tests__/record-position.factory.spec.ts
index 272309a01..8a22aaea0 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-query-runner/factories/__tests__/record-position.factory.spec.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-query-runner/factories/__tests__/record-position.factory.spec.ts
@@ -46,25 +46,18 @@ describe('RecordPositionFactory', () => {
     it('should return the value when value is a number', async () => {
       const value = 1;
 
-      workspaceDataSourceService.executeRawQuery.mockResolvedValue([]);
-
       const result = await factory.create(value, objectMetadata, workspaceId);
 
       expect(result).toEqual(value);
     });
-    it('should throw an error when position is not unique', async () => {
-      const value = 1;
 
-      await expect(
-        factory.create(value, objectMetadata, workspaceId),
-      ).rejects.toThrow('Position is not unique');
-    });
     it('should return the existing position -1 when value is first', async () => {
       const value = 'first';
       const result = await factory.create(value, objectMetadata, workspaceId);
 
       expect(result).toEqual(0);
     });
+
     it('should return the existing position + 1 when value is last', async () => {
       const value = 'last';
       const result = await factory.create(value, objectMetadata, workspaceId);
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-query-runner/factories/record-position.factory.ts b/packages/twenty-server/src/engine/api/graphql/workspace-query-runner/factories/record-position.factory.ts
index 1b9cc5bb8..1cde2b797 100644
--- a/packages/twenty-server/src/engine/api/graphql/workspace-query-runner/factories/record-position.factory.ts
+++ b/packages/twenty-server/src/engine/api/graphql/workspace-query-runner/factories/record-position.factory.ts
@@ -26,20 +26,6 @@ export class RecordPositionFactory {
       this.workspaceDataSourceService.getSchemaName(workspaceId);
 
     if (typeof value === 'number') {
-      const recordWithSamePosition = await this.findRecordPosition(
-        {
-          recordPositionQueryType: RecordPositionQueryType.FIND_BY_POSITION,
-          positionValue: value,
-        },
-        objectMetadata,
-        dataSourceSchema,
-        workspaceId,
-      );
-
-      if (recordWithSamePosition) {
-        throw new Error('Position is not unique');
-      }
-
       return value;
     }