Move settings data model refreshMetadata to sync calls (#9046)

In this PR, I'm
- removing setting up the isAppWaitingForFreshMetadata boolean state in
PageChangeEffect navigate (not robust) to some precise synchronous
places, improving the control we have on when the app considers it's
ready to be rendered based on fresh metadata
- fixing tests

packages/twenty-front/src/modules/object-metadata/hooks/useRefreshObjectMetadataItem.ts

@@ -1,5 +1,6 @@
 import { FIND_MANY_OBJECT_METADATA_ITEMS } from '@/object-metadata/graphql/queries';
 import { useApolloMetadataClient } from '@/object-metadata/hooks/useApolloMetadataClient';
+import { isAppWaitingForFreshObjectMetadataState } from '@/object-metadata/states/isAppWaitingForFreshObjectMetadataState';
 import { objectMetadataItemsState } from '@/object-metadata/states/objectMetadataItemsState';
 import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem';
 import { mapPaginatedObjectMetadataItemsToObjectMetadataItems } from '@/object-metadata/utils/mapPaginatedObjectMetadataItemsToObjectMetadataItems';
@@ -7,13 +8,18 @@ import { useRecoilCallback } from 'recoil';
 import { ObjectMetadataItemsQuery } from '~/generated-metadata/graphql';
 import { isDeeplyEqual } from '~/utils/isDeeplyEqual';
 
-export const useRefreshObjectMetadataItems = () => {
+type FetchPolicy = 'network-only' | 'cache-first';
+
+export const useRefreshObjectMetadataItems = (
+  fetchPolicy: FetchPolicy = 'cache-first',
+) => {
   const client = useApolloMetadataClient();
 
   const refreshObjectMetadataItems = async () => {
     const result = await client.query<ObjectMetadataItemsQuery>({
       query: FIND_MANY_OBJECT_METADATA_ITEMS,
       variables: {},
+      fetchPolicy,
     });
 
     const objectMetadataItems =
@@ -34,6 +40,7 @@ export const useRefreshObjectMetadataItems = () => {
           )
         ) {
           set(objectMetadataItemsState, toSetObjectMetadataItems);
+          set(isAppWaitingForFreshObjectMetadataState, false);
         }
       },
     [],