From 965a6b7c57bce9f9a0285bcd833e888f5ec311a5 Mon Sep 17 00:00:00 2001
From: Ayush Agrawal <54364088+AyushAgrawal-A2@users.noreply.github.com>
Date: Mon, 2 Oct 2023 20:53:30 +0530
Subject: [PATCH] Fix: Table / Board createView bug (#1782)

* fix createView for tables and board page

* removed residual console.log from InlineCell component
---
 front/src/modules/ui/board/components/BoardHeader.tsx        | 1 -
 .../src/modules/ui/editable-field/components/InlineCell.tsx  | 1 -
 .../modules/ui/table/table-header/components/TableHeader.tsx | 1 -
 front/src/modules/views/hooks/useBoardViews.ts               | 5 +++++
 front/src/modules/views/hooks/useTableViews.ts               | 5 +++++
 5 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/front/src/modules/ui/board/components/BoardHeader.tsx b/front/src/modules/ui/board/components/BoardHeader.tsx
index 8c03e0676..c9d10cc5c 100644
--- a/front/src/modules/ui/board/components/BoardHeader.tsx
+++ b/front/src/modules/ui/board/components/BoardHeader.tsx
@@ -109,7 +109,6 @@ export const BoardHeader = ({ className, onStageAdd }: BoardHeaderProps) => {
           onCurrentViewSubmit: handleCurrentViewSubmit,
           onViewBarReset: handleViewBarReset,
           onViewSelect: handleViewSelect,
-          onViewCreate: (view) => setSearchParams({ view: view.id }),
         }}
       >
         <ViewBar
diff --git a/front/src/modules/ui/editable-field/components/InlineCell.tsx b/front/src/modules/ui/editable-field/components/InlineCell.tsx
index 65a9fe881..a41f1f598 100644
--- a/front/src/modules/ui/editable-field/components/InlineCell.tsx
+++ b/front/src/modules/ui/editable-field/components/InlineCell.tsx
@@ -54,7 +54,6 @@ export const InlineCell = () => {
     persistField();
     closeInlineCell();
   };
-  console.log(JSON.stringify({ fieldDefinition }));
 
   return (
     <InlineCellContainer
diff --git a/front/src/modules/ui/table/table-header/components/TableHeader.tsx b/front/src/modules/ui/table/table-header/components/TableHeader.tsx
index 4c7ae91b8..fa5a30581 100644
--- a/front/src/modules/ui/table/table-header/components/TableHeader.tsx
+++ b/front/src/modules/ui/table/table-header/components/TableHeader.tsx
@@ -40,7 +40,6 @@ export const TableHeader = () => {
           ...viewBarContextProps,
           onCurrentViewSubmit,
           onViewSelect: handleViewSelect,
-          onViewCreate: (view) => setSearchParams({ view: view.id }),
         }}
       >
         <ViewBar
diff --git a/front/src/modules/views/hooks/useBoardViews.ts b/front/src/modules/views/hooks/useBoardViews.ts
index f1bef626c..125c4a76e 100644
--- a/front/src/modules/views/hooks/useBoardViews.ts
+++ b/front/src/modules/views/hooks/useBoardViews.ts
@@ -1,3 +1,5 @@
+import { useSearchParams } from 'react-router-dom';
+
 import { RecoilScopeContext } from '@/types/RecoilScopeContext';
 import { useBoardColumns } from '@/ui/board/hooks/useBoardColumns';
 import { boardCardFieldsScopedState } from '@/ui/board/states/boardCardFieldsScopedState';
@@ -29,10 +31,13 @@ export const useBoardViews = ({
   const filters = useRecoilScopedValue(filtersScopedState, RecoilScopeContext);
   const sorts = useRecoilScopedValue(sortsScopedState, RecoilScopeContext);
 
+  const [_, setSearchParams] = useSearchParams();
+
   const handleViewCreate = async (viewId: string) => {
     await createViewFields(boardCardFields, viewId);
     await createViewFilters(filters, viewId);
     await createViewSorts(sorts, viewId);
+    setSearchParams({ view: viewId });
   };
 
   const { createView, deleteView, isFetchingViews, updateView } = useViews({
diff --git a/front/src/modules/views/hooks/useTableViews.ts b/front/src/modules/views/hooks/useTableViews.ts
index bed52c5a5..91f3e7d42 100644
--- a/front/src/modules/views/hooks/useTableViews.ts
+++ b/front/src/modules/views/hooks/useTableViews.ts
@@ -1,3 +1,5 @@
+import { useSearchParams } from 'react-router-dom';
+
 import { FieldMetadata } from '@/ui/field/types/FieldMetadata';
 import { TableRecoilScopeContext } from '@/ui/table/states/recoil-scope-contexts/TableRecoilScopeContext';
 import { tableColumnsScopedState } from '@/ui/table/states/tableColumnsScopedState';
@@ -29,10 +31,13 @@ export const useTableViews = ({
   );
   const sorts = useRecoilScopedValue(sortsScopedState, TableRecoilScopeContext);
 
+  const [_, setSearchParams] = useSearchParams();
+
   const handleViewCreate = async (viewId: string) => {
     await createViewFields(tableColumns, viewId);
     await createViewFilters(filters, viewId);
     await createViewSorts(sorts, viewId);
+    setSearchParams({ view: viewId });
   };
 
   const { createView, deleteView, isFetchingViews, updateView } = useViews({