From 9681815cb316ef3b49d725a213c545788d3472e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tha=C3=AFs?= Date: Fri, 27 Oct 2023 17:49:14 +0200 Subject: [PATCH] test: fix SettingsObjectDisabledMenuDropDown storybook tests (#2257) * test: fix SettingsObjectDisabledMenuDropDown storybook tests * fix: fix BoardOptionsDropdownContent lint error --- ...ttingsObjectDisabledMenuDropDown.stories.tsx | 17 +++++++++++------ .../components/BoardOptionsDropdownContent.tsx | 2 +- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/front/src/modules/settings/data-model/objects/__stories__/SettingsObjectDisabledMenuDropDown.stories.tsx b/front/src/modules/settings/data-model/objects/__stories__/SettingsObjectDisabledMenuDropDown.stories.tsx index b3344c548..e8ab51949 100644 --- a/front/src/modules/settings/data-model/objects/__stories__/SettingsObjectDisabledMenuDropDown.stories.tsx +++ b/front/src/modules/settings/data-model/objects/__stories__/SettingsObjectDisabledMenuDropDown.stories.tsx @@ -37,11 +37,11 @@ type Story = StoryObj; export const Default: Story = {}; -export const WithOpen: Story = { +export const Open: Story = { play: async ({ canvasElement }) => { const canvas = within(canvasElement); - const dropdownButton = await canvas.findByRole('button'); + const dropdownButton = await canvas.getByRole('button'); await userEvent.click(dropdownButton); }, @@ -51,34 +51,39 @@ export const WithActivate: Story = { play: async ({ canvasElement }) => { const canvas = within(canvasElement); - const dropdownButton = await canvas.findByRole('button'); + const dropdownButton = await canvas.getByRole('button'); await userEvent.click(dropdownButton); await expect(handleActivateMockFunction).toHaveBeenCalledTimes(0); - const activateMenuItem = await canvas.findByText('Activate'); + const activateMenuItem = await canvas.getByText('Activate'); await userEvent.click(activateMenuItem); await expect(handleActivateMockFunction).toHaveBeenCalledTimes(1); + + await userEvent.click(dropdownButton); }, }; export const WithErase: Story = { + args: { isCustomObject: true }, play: async ({ canvasElement }) => { const canvas = within(canvasElement); - const dropdownButton = await canvas.findByRole('button'); + const dropdownButton = await canvas.getByRole('button'); await userEvent.click(dropdownButton); await expect(handleEraseMockFunction).toHaveBeenCalledTimes(0); - const eraseMenuItem = await canvas.findByText('Erase'); + const eraseMenuItem = await canvas.getByText('Erase'); await userEvent.click(eraseMenuItem); await expect(handleEraseMockFunction).toHaveBeenCalledTimes(1); + + await userEvent.click(dropdownButton); }, }; diff --git a/front/src/modules/ui/layout/board/components/BoardOptionsDropdownContent.tsx b/front/src/modules/ui/layout/board/components/BoardOptionsDropdownContent.tsx index 419b73167..c01d56f55 100644 --- a/front/src/modules/ui/layout/board/components/BoardOptionsDropdownContent.tsx +++ b/front/src/modules/ui/layout/board/components/BoardOptionsDropdownContent.tsx @@ -110,7 +110,7 @@ export const BoardOptionsDropdownContent = ({ const viewEditMode = snapshot .getLoadable(viewEditModeScopedState({ scopeId: boardRecoilScopeId })) .getValue(); - + if (!viewEditMode) { return; }