[NITPICK] From args list to record args RecordPositionFactory (#10215)

# Introduction
Just some nitpicking while debugging a bug that wasn't one

packages/twenty-server/src/engine/api/graphql/workspace-query-runner/factories/__tests__/query-runner-args.factory.spec.ts

@@ -6,7 +6,10 @@ import { WorkspaceQueryRunnerOptions } from 'src/engine/api/graphql/workspace-qu
 import { ResolverArgsType } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
 
 import { QueryRunnerArgsFactory } from 'src/engine/api/graphql/workspace-query-runner/factories/query-runner-args.factory';
-import { RecordPositionFactory } from 'src/engine/api/graphql/workspace-query-runner/factories/record-position.factory';
+import {
+  RecordPositionFactory,
+  RecordPositionFactoryCreateArgs,
+} from 'src/engine/api/graphql/workspace-query-runner/factories/record-position.factory';
 import { FieldMetadataMap } from 'src/engine/metadata-modules/types/field-metadata-map';
 
 describe('QueryRunnerArgsFactory', () => {
@@ -104,12 +107,14 @@ describe('QueryRunnerArgsFactory', () => {
         ResolverArgsType.CreateMany,
       );
 
-      expect(recordPositionFactory.create).toHaveBeenCalledWith(
+      const expectedArgs: RecordPositionFactoryCreateArgs = {
-        'last',
+        value: 'last',
-        { isCustom: true, nameSingular: 'testNumber' },
+        objectMetadata: { isCustom: true, nameSingular: 'testNumber' },
         workspaceId,
-        0,
+        index: 0,
-      );
+      };
+
+      expect(recordPositionFactory.create).toHaveBeenCalledWith(expectedArgs);
       expect(result).toEqual({
         id: 'uuid',
         data: [{ position: 2, testNumber: 1 }],
@@ -128,12 +133,14 @@ describe('QueryRunnerArgsFactory', () => {
         ResolverArgsType.CreateMany,
       );
 
-      expect(recordPositionFactory.create).toHaveBeenCalledWith(
+      const expectedArgs: RecordPositionFactoryCreateArgs = {
-        'first',
+        value: 'first',
-        { isCustom: true, nameSingular: 'testNumber' },
+        objectMetadata: { isCustom: true, nameSingular: 'testNumber' },
         workspaceId,
-        0,
+        index: 0,
-      );
+      };
+
+      expect(recordPositionFactory.create).toHaveBeenCalledWith(expectedArgs);
       expect(result).toEqual({
         id: 'uuid',
         data: [{ position: 2, testNumber: 1 }],

packages/twenty-server/src/engine/api/graphql/workspace-query-runner/factories/__tests__/record-position.factory.spec.ts

@@ -46,21 +46,33 @@ describe('RecordPositionFactory', () => {
     it('should return the value when value is a number', async () => {
       const value = 1;
 
-      const result = await factory.create(value, objectMetadata, workspaceId);
+      const result = await factory.create({
+        value,
+        objectMetadata,
+        workspaceId,
+      });
 
       expect(result).toEqual(value);
     });
 
     it('should return the existing position -1 when value is first', async () => {
       const value = 'first';
-      const result = await factory.create(value, objectMetadata, workspaceId);
+      const result = await factory.create({
+        value,
+        objectMetadata,
+        workspaceId,
+      });
 
       expect(result).toEqual(0);
     });
 
     it('should return the existing position + 1 when value is last', async () => {
       const value = 'last';
-      const result = await factory.create(value, objectMetadata, workspaceId);
+      const result = await factory.create({
+        value,
+        objectMetadata,
+        workspaceId,
+      });
 
       expect(result).toEqual(2);
     });

packages/twenty-server/src/engine/api/graphql/workspace-query-runner/factories/query-runner-args.factory.ts

@@ -177,6 +177,7 @@ export class QueryRunnerArgsFactory {
       return Promise.resolve({});
     }
 
+    const workspaceId = options.authContext.workspace.id;
     let isFieldPositionPresent = false;
 
     const createArgByArgKeyPromises: Promise<[string, any]>[] = Object.entries(
@@ -192,16 +193,16 @@ export class QueryRunnerArgsFactory {
         case FieldMetadataType.POSITION: {
           isFieldPositionPresent = true;
 
-          const newValue = await this.recordPositionFactory.create(
+          const newValue = await this.recordPositionFactory.create({
             value,
-            {
+            workspaceId,
+            objectMetadata: {
               isCustom: options.objectMetadataItemWithFieldMaps.isCustom,
               nameSingular:
                 options.objectMetadataItemWithFieldMaps.nameSingular,
             },
-            options.authContext.workspace.id,
+            index: argPositionBackfillInput.argIndex,
-            argPositionBackfillInput.argIndex,
+          });
-          );
 
           return [key, newValue];
         }
@@ -248,16 +249,16 @@ export class QueryRunnerArgsFactory {
         ...newArgEntries,
         [
           'position',
-          await this.recordPositionFactory.create(
+          await this.recordPositionFactory.create({
-            'first',
+            value: 'first',
-            {
+            workspaceId,
+            objectMetadata: {
               isCustom: options.objectMetadataItemWithFieldMaps.isCustom,
               nameSingular:
                 options.objectMetadataItemWithFieldMaps.nameSingular,
             },
-            options.authContext.workspace.id,
+            index: argPositionBackfillInput.argIndex,
-            argPositionBackfillInput.argIndex,
+          }),
-          ),
         ],
       ]);
     }

packages/twenty-server/src/engine/api/graphql/workspace-query-runner/factories/record-position.factory.ts

@@ -9,6 +9,12 @@ import {
 } from 'src/engine/api/graphql/workspace-query-builder/factories/record-position-query.factory';
 import { WorkspaceDataSourceService } from 'src/engine/workspace-datasource/workspace-datasource.service';
 
+export type RecordPositionFactoryCreateArgs = {
+  value: number | 'first' | 'last';
+  objectMetadata: { isCustom: boolean; nameSingular: string };
+  workspaceId: string;
+  index?: number;
+};
 @Injectable()
 export class RecordPositionFactory {
   constructor(
@@ -16,12 +22,12 @@ export class RecordPositionFactory {
     private readonly recordPositionQueryFactory: RecordPositionQueryFactory,
   ) {}
 
-  async create(
+  async create({
-    value: number | 'first' | 'last',
+    objectMetadata,
-    objectMetadata: { isCustom: boolean; nameSingular: string },
+    value,
-    workspaceId: string,
+    workspaceId,
     index = 0,
-  ): Promise<number> {
+  }: RecordPositionFactoryCreateArgs): Promise<number> {
     const dataSourceSchema =
       this.workspaceDataSourceService.getSchemaName(workspaceId);
 

packages/twenty-server/src/engine/api/graphql/workspace-query-runner/services/record-position-backfill-service.ts

@@ -2,8 +2,8 @@ import { Injectable, Logger } from '@nestjs/common';
 import { InjectRepository } from '@nestjs/typeorm';
 
 import { isDefined } from 'class-validator';
-import { Repository } from 'typeorm';
 import { FieldMetadataType } from 'twenty-shared';
+import { Repository } from 'typeorm';
 
 import {
   RecordPositionQueryFactory,
@@ -73,14 +73,14 @@ export class RecordPositionBackfillService {
         continue;
       }
 
-      const position = await this.recordPositionFactory.create(
+      const position = await this.recordPositionFactory.create({
-        'last',
+        objectMetadata: {
-        {
           isCustom: objectMetadata.isCustom,
           nameSingular: objectMetadata.nameSingular,
         },
+        value: 'last',
         workspaceId,
-      );
+      });
 
       for (
         let recordIndex = 0;