Fix and enhance storybook:pages tests (#3085)

* Fix and enhance storybook:pages tests Co-authored-by: gitstart-app[bot] <57568882+gitstart-app[bot]@users.noreply.github.com> * Fix and enhance storybook:pages tests Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: gitstart-app[bot] <57568882+gitstart-app[bot]@users.noreply.github.com> * fix SettingsObjectFieldPreview Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: gitstart-app[bot] <57568882+gitstart-app[bot]@users.noreply.github.com> * Fix lint Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: gitstart-app[bot] <57568882+gitstart-app[bot]@users.noreply.github.com> * Fix jest Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: gitstart-app[bot] <57568882+gitstart-app[bot]@users.noreply.github.com> * Add more fixes Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: gitstart-app[bot] <57568882+gitstart-app[bot]@users.noreply.github.com> * Fix App.stories.tsx Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: gitstart-app[bot] <57568882+gitstart-app[bot]@users.noreply.github.com> * Fix tests * Fix according to review --------- Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com> Co-authored-by: gitstart-app[bot] <57568882+gitstart-app[bot]@users.noreply.github.com> Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: Charles Bochet <charles@twenty.com>
2023-12-21 01:36:58 +08:00
parent 6c30556d00
commit 984fc76b94
27 changed files with 6935 additions and 917 deletions
--- a/packages/twenty-front/src/modules/activities/types/Activity.ts
+++ b/packages/twenty-front/src/modules/activities/types/Activity.ts
@ -10,6 +10,7 @@ export type Activity = {
  createdAt: string;
  updatedAt: string;
  completedAt: string | null;
+  reminderAt: string | null;
  dueAt: string | null;
  activityTargets: ActivityTarget[];
  type: ActivityType;
--- a/packages/twenty-front/src/modules/auth/states/currentWorkspaceMemberState.ts
+++ b/packages/twenty-front/src/modules/auth/states/currentWorkspaceMemberState.ts
@ -2,7 +2,10 @@ import { atom } from 'recoil';

 import { WorkspaceMember } from '@/workspace-member/types/WorkspaceMember';

-export const currentWorkspaceMemberState = atom<WorkspaceMember | null>({
+export const currentWorkspaceMemberState = atom<Omit<
+  WorkspaceMember,
+  'createdAt' | 'updatedAt' | 'userId'
+> | null>({
  key: 'currentWorkspaceMemberState',
  default: null,
 });
--- a/packages/twenty-front/src/modules/auth/utils/getOnboardingStatus.ts
+++ b/packages/twenty-front/src/modules/auth/utils/getOnboardingStatus.ts
@ -17,7 +17,10 @@ export const getOnboardingStatus = ({
  isBillingEnabled,
 }: {
  isLoggedIn: boolean;
-  currentWorkspaceMember: WorkspaceMember | null;
+  currentWorkspaceMember: Omit<
+    WorkspaceMember,
+    'createdAt' | 'updatedAt' | 'userId'
+  > | null;
  currentWorkspace: CurrentWorkspace | null;
  isBillingEnabled?: boolean;
 }) => {
--- a/packages/twenty-front/src/modules/command-menu/components/stories/CommandMenu.stories.tsx
+++ b/packages/twenty-front/src/modules/command-menu/components/stories/CommandMenu.stories.tsx
@ -1,14 +1,17 @@
 import { useEffect } from 'react';
 import { Meta, StoryObj } from '@storybook/react';
 import { expect, userEvent, within } from '@storybook/test';
+import { RecoilRoot, useSetRecoilState } from 'recoil';

+import { currentWorkspaceState } from '@/auth/states/currentWorkspaceState';
 import { useCommandMenu } from '@/command-menu/hooks/useCommandMenu';
 import { CommandType } from '@/command-menu/types/Command';
 import { IconCheckbox, IconNotes } from '@/ui/display/icon';
+import { SnackBarProviderScope } from '@/ui/feedback/snack-bar-manager/scopes/SnackBarProviderScope';
 import { ComponentWithRouterDecorator } from '~/testing/decorators/ComponentWithRouterDecorator';
 import { ObjectMetadataItemsDecorator } from '~/testing/decorators/ObjectMetadataItemsDecorator';
-import { SnackBarDecorator } from '~/testing/decorators/SnackBarDecorator';
 import { graphqlMocks } from '~/testing/graphqlMocks';
+import { mockDefaultWorkspace } from '~/testing/mock-data/users';
 import { sleep } from '~/testing/sleep';

 import { CommandMenu } from '../CommandMenu';
@ -20,11 +23,13 @@ const meta: Meta<typeof CommandMenu> = {
  component: CommandMenu,
  decorators: [
    ObjectMetadataItemsDecorator,
-    ComponentWithRouterDecorator,
    (Story) => {
+      const setCurrentWorkspace = useSetRecoilState(currentWorkspaceState);
      const { addToCommandMenu, setToIntitialCommandMenu, toggleCommandMenu } =
        useCommandMenu();

+      setCurrentWorkspace(mockDefaultWorkspace);
+
      useEffect(() => {
        setToIntitialCommandMenu();
        addToCommandMenu([
@ -50,7 +55,14 @@ const meta: Meta<typeof CommandMenu> = {

      return <Story />;
    },
-    SnackBarDecorator,
+    (Story) => (
+      <RecoilRoot>
+        <SnackBarProviderScope snackBarManagerScopeId="snack-bar-manager">
+          <Story />
+        </SnackBarProviderScope>
+      </RecoilRoot>
+    ),
+    ComponentWithRouterDecorator,
  ],
  parameters: {
    msw: graphqlMocks,
--- a/packages/twenty-front/src/modules/companies/types/Company.ts
+++ b/packages/twenty-front/src/modules/companies/types/Company.ts
@ -7,8 +7,8 @@ export type Company = {
  domainName: string;
  address: string;
  accountOwnerId: string | null;
-  linkedinUrl: { url: string; label: string };
-  xUrl: { url: string; label: string };
+  linkedinLink: { url: string; label: string };
+  xLink: { url: string; label: string };
  annualRecurringRevenue: { amountMicros: number | null; currencyCode: string };
  employees: number | null;
  idealCustomerProfile: boolean;
--- a/packages/twenty-front/src/modules/pipeline/types/PipelineStep.ts
+++ b/packages/twenty-front/src/modules/pipeline/types/PipelineStep.ts
@ -3,4 +3,6 @@ export type PipelineStep = {
  name: string;
  color: string;
  position: number;
+  createdAt: string;
+  updatedAt: string;
 };
--- a/packages/twenty-front/src/modules/settings/data-model/components/stories/SettingsObjectFieldPreview.stories.tsx
+++ b/packages/twenty-front/src/modules/settings/data-model/components/stories/SettingsObjectFieldPreview.stories.tsx
@ -1,15 +1,16 @@
 import { MemoryRouter } from 'react-router-dom';
 import { Meta, StoryObj } from '@storybook/react';
+import { RecoilRoot } from 'recoil';

-import { ObjectMetadataItemsProvider } from '@/object-metadata/components/ObjectMetadataItemsProvider';
+import { RelationPickerScope } from '@/object-record/relation-picker/scopes/RelationPickerScope';
 import { SnackBarProviderScope } from '@/ui/feedback/snack-bar-manager/scopes/SnackBarProviderScope';
 import { Field, FieldMetadataType } from '~/generated-metadata/graphql';
 import { ComponentDecorator } from '~/testing/decorators/ComponentDecorator';
+import { ObjectMetadataItemsDecorator } from '~/testing/decorators/ObjectMetadataItemsDecorator';
 import { graphqlMocks } from '~/testing/graphqlMocks';
 import {
  mockedCompaniesMetadata,
  mockedPeopleMetadata,
-  mockedWorkspacesMetadata,
 } from '~/testing/mock-data/metadata';

 import { SettingsObjectFieldPreview } from '../SettingsObjectFieldPreview';
@ -19,18 +20,21 @@ const meta: Meta<typeof SettingsObjectFieldPreview> = {
  component: SettingsObjectFieldPreview,
  decorators: [
    ComponentDecorator,
+    ObjectMetadataItemsDecorator,
    (Story) => (
-      <SnackBarProviderScope snackBarManagerScopeId="snack-bar-manager">
-        <ObjectMetadataItemsProvider>
-          <Story />
-        </ObjectMetadataItemsProvider>
-      </SnackBarProviderScope>
+      <RecoilRoot>
+        <RelationPickerScope relationPickerScopeId="relation-picker">
+          <SnackBarProviderScope snackBarManagerScopeId="snack-bar-manager">
+            <Story />
+          </SnackBarProviderScope>
+        </RelationPickerScope>
+      </RecoilRoot>
    ),
  ],
  args: {
    fieldMetadata: mockedCompaniesMetadata.node.fields.edges.find(
      ({ node }) => node.type === FieldMetadataType.Text,
-    )?.node,
+    )?.node as Field,
    objectMetadataId: mockedCompaniesMetadata.node.id,
  },
  parameters: {
@ -119,9 +123,9 @@ export const Relation: Story = {

 export const CustomObject: Story = {
  args: {
-    fieldMetadata: mockedWorkspacesMetadata.node.fields.edges.find(
-      ({ node }) => node.type === FieldMetadataType.Text,
+    fieldMetadata: mockedCompaniesMetadata.node.fields.edges.find(
+      ({ node }) => node.isCustom,
    )?.node as Field,
-    objectMetadataId: mockedWorkspacesMetadata.node.id,
+    objectMetadataId: mockedCompaniesMetadata.node.id,
  },
 };
--- a/packages/twenty-front/src/modules/settings/data-model/components/stories/SettingsObjectFieldTypeSelectSection.stories.tsx
+++ b/packages/twenty-front/src/modules/settings/data-model/components/stories/SettingsObjectFieldTypeSelectSection.stories.tsx
@ -2,13 +2,14 @@ import { MemoryRouter } from 'react-router-dom';
 import { Meta, StoryObj } from '@storybook/react';
 import { userEvent, within } from '@storybook/test';

-import { ObjectMetadataItemsProvider } from '@/object-metadata/components/ObjectMetadataItemsProvider';
+import { RelationPickerScope } from '@/object-record/relation-picker/scopes/RelationPickerScope';
 import { SnackBarProviderScope } from '@/ui/feedback/snack-bar-manager/scopes/SnackBarProviderScope';
 import {
  FieldMetadataType,
  RelationMetadataType,
 } from '~/generated-metadata/graphql';
 import { ComponentDecorator } from '~/testing/decorators/ComponentDecorator';
+import { ObjectMetadataItemsDecorator } from '~/testing/decorators/ObjectMetadataItemsDecorator';
 import { graphqlMocks } from '~/testing/graphqlMocks';
 import {
  mockedCompaniesMetadata,
@ -31,12 +32,13 @@ const meta: Meta<typeof SettingsObjectFieldTypeSelectSection> = {
  component: SettingsObjectFieldTypeSelectSection,
  decorators: [
    ComponentDecorator,
+    ObjectMetadataItemsDecorator,
    (Story) => (
-      <SnackBarProviderScope snackBarManagerScopeId="snack-bar-manager">
-        <ObjectMetadataItemsProvider>
+      <RelationPickerScope relationPickerScopeId="relation-picker">
+        <SnackBarProviderScope snackBarManagerScopeId="snack-bar-manager">
          <Story />
-        </ObjectMetadataItemsProvider>
-      </SnackBarProviderScope>
+        </SnackBarProviderScope>
+      </RelationPickerScope>
    ),
  ],
  args: {
--- a/packages/twenty-front/src/modules/workspace-member/types/WorkspaceMember.ts
+++ b/packages/twenty-front/src/modules/workspace-member/types/WorkspaceMember.ts
@ -9,4 +9,7 @@ export type WorkspaceMember = {
  avatarUrl?: string | null;
  locale: string;
  colorScheme?: ColorScheme;
+  createdAt: string;
+  updatedAt: string;
+  userId: string;
 };