Remove the heart icon button to add the view as a favorite from the top bar (#8769)

closes #8546 

@Bonapara please check the behaviour, if this is what you were looking
for! ;)
This commit is contained in:
nitin
2024-12-03 18:19:00 +05:30
committed by GitHub
parent 3c7805c6d0
commit 9a65e80566
11 changed files with 233 additions and 112 deletions

View File

@ -1,6 +1,7 @@
import { SelectHotkeyScope } from '@/ui/input/types/SelectHotkeyScope';
import { Dropdown } from '@/ui/layout/dropdown/components/Dropdown';
import { useTheme } from '@emotion/react';
import { Placement } from '@floating-ui/react';
import { FunctionComponent, MouseEvent, ReactElement, ReactNode } from 'react';
import {
IconChevronRight,
@ -36,6 +37,7 @@ export type MenuItemWithOptionDropdownProps = {
testId?: string;
text: ReactNode;
hasSubMenu?: boolean;
dropdownPlacement?: Placement;
};
// TODO: refactor this
@ -53,6 +55,7 @@ export const MenuItemWithOptionDropdown = ({
testId,
text,
hasSubMenu = false,
dropdownPlacement = 'bottom-end',
}: MenuItemWithOptionDropdownProps) => {
const theme = useTheme();
@ -86,6 +89,7 @@ export const MenuItemWithOptionDropdown = ({
accent="tertiary"
/>
}
dropdownPlacement={dropdownPlacement}
dropdownComponents={dropdownContent}
dropdownId={dropdownId}
dropdownHotkeyScope={{ scope: SelectHotkeyScope.Select }}