From 9ba24b3654b358db964cb16a9e9c12a150d9d8b9 Mon Sep 17 00:00:00 2001
From: Weiko <corentin@twenty.com>
Date: Tue, 20 May 2025 12:14:19 +0200
Subject: [PATCH] Fix: Editing a task assignee relation from the list opens
 both the command menu and the multi item picker (#12138)

Fixes https://github.com/twentyhq/twenty/issues/12129

To fix this, we need to stop the click event from propagating up from
the ActivityTargetsInlineCell

---------

Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>
---
 .../activities/tasks/components/TaskRow.tsx   | 21 +++++++++++--------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/packages/twenty-front/src/modules/activities/tasks/components/TaskRow.tsx b/packages/twenty-front/src/modules/activities/tasks/components/TaskRow.tsx
index 0d14eafbf..21be4617c 100644
--- a/packages/twenty-front/src/modules/activities/tasks/components/TaskRow.tsx
+++ b/packages/twenty-front/src/modules/activities/tasks/components/TaskRow.tsx
@@ -9,10 +9,11 @@ import { ActivityRow } from '@/activities/components/ActivityRow';
 import { Task } from '@/activities/types/Task';
 import { useOpenRecordInCommandMenu } from '@/command-menu/hooks/useOpenRecordInCommandMenu';
 import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
+import { StopPropagationContainer } from '@/object-record/record-board/record-board-card/components/StopPropagationContainer';
 import { FieldContextProvider } from '@/object-record/record-field/components/FieldContextProvider';
-import { useCompleteTask } from '../hooks/useCompleteTask';
-import { Checkbox, CheckboxShape } from 'twenty-ui/input';
 import { IconCalendar, OverflowingTextWithTooltip } from 'twenty-ui/display';
+import { Checkbox, CheckboxShape } from 'twenty-ui/input';
+import { useCompleteTask } from '../hooks/useCompleteTask';
 
 const StyledTaskBody = styled.div`
   color: ${({ theme }) => theme.font.color.tertiary};
@@ -124,13 +125,15 @@ export const TaskRow = ({ task }: { task: Task }) => {
             fieldMetadataName={'taskTargets'}
             fieldPosition={0}
           >
-            <ActivityTargetsInlineCell
-              activityObjectNameSingular={CoreObjectNameSingular.Task}
-              activityRecordId={task.id}
-              showLabel={false}
-              maxWidth={200}
-              componentInstanceId={`task-row-targets-${task.id}`}
-            />
+            <StopPropagationContainer>
+              <ActivityTargetsInlineCell
+                activityObjectNameSingular={CoreObjectNameSingular.Task}
+                activityRecordId={task.id}
+                showLabel={false}
+                maxWidth={200}
+                componentInstanceId={`task-row-targets-${task.id}`}
+              />
+            </StopPropagationContainer>
           </FieldContextProvider>
         }
       </StyledRightSideContainer>