admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix missing New Note / New Task button (#12513)

Browse Source 
New Note button was missing because of the wrong condition being applied
to display it
<img width="492" alt="Capture d’écran 2025-06-10 à 10 26 57"
src="https://github.com/user-attachments/assets/dafd10e3-b3a8-497c-9a00-c395f20cecbb"
/>
This commit is contained in:
Marie
2025-06-10 11:12:41 +02:00
committed by GitHub
parent 3cbd3427a1
commit 9cfabd81cb
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/twenty-front/src/modules/activities/files/components/Attachments.tsx
View File

@ -129,7 +129,7 @@ export const Attachments = ({
title="All" title="All"
attachments={attachments ?? []} attachments={attachments ?? []}
button={ button={
!hasObjectUpdatePermissions && ( hasObjectUpdatePermissions && (
<Button <Button
Icon={IconPlus} Icon={IconPlus}
size="small" size="small"

2
packages/twenty-front/src/modules/activities/notes/components/Notes.tsx
View File

@ -68,7 +68,7 @@ export const Notes = ({
There are no associated notes with this record. There are no associated notes with this record.
</AnimatedPlaceholderEmptySubTitle> </AnimatedPlaceholderEmptySubTitle>
</AnimatedPlaceholderEmptyTextContainer> </AnimatedPlaceholderEmptyTextContainer>
{!hasObjectUpdatePermissions && ( {hasObjectUpdatePermissions && (
<Button <Button
Icon={IconPlus} Icon={IconPlus}
title="New note" title="New note"

4
packages/twenty-front/src/modules/activities/tasks/components/TaskGroups.tsx
View File

@ -7,6 +7,7 @@ import { ActivityTargetableObject } from '@/activities/types/ActivityTargetableE
import { Task } from '@/activities/types/Task'; import { Task } from '@/activities/types/Task';
import { useObjectMetadataItem } from '@/object-metadata/hooks/useObjectMetadataItem'; import { useObjectMetadataItem } from '@/object-metadata/hooks/useObjectMetadataItem';
import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular'; import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
import { useObjectPermissionsForObject } from '@/object-record/hooks/useObjectPermissionsForObject';
import { activeTabIdComponentState } from '@/ui/layout/tab-list/states/activeTabIdComponentState'; import { activeTabIdComponentState } from '@/ui/layout/tab-list/states/activeTabIdComponentState';
import { useRecoilComponentValueV2 } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValueV2'; import { useRecoilComponentValueV2 } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValueV2';
import groupBy from 'lodash.groupby'; import groupBy from 'lodash.groupby';
@ -22,7 +23,6 @@ import {
} from 'twenty-ui/layout'; } from 'twenty-ui/layout';
import { AddTaskButton } from './AddTaskButton'; import { AddTaskButton } from './AddTaskButton';
import { TaskList } from './TaskList'; import { TaskList } from './TaskList';
import { useObjectPermissionsForObject } from '@/object-record/hooks/useObjectPermissionsForObject';
const StyledContainer = styled.div` const StyledContainer = styled.div`
display: flex; display: flex;
@ -83,7 +83,7 @@ export const TaskGroups = ({ targetableObject }: TaskGroupsProps) => {
All tasks addressed. Maintain the momentum. All tasks addressed. Maintain the momentum.
</AnimatedPlaceholderEmptySubTitle> </AnimatedPlaceholderEmptySubTitle>
</AnimatedPlaceholderEmptyTextContainer> </AnimatedPlaceholderEmptyTextContainer>
{!hasObjectUpdatePermissions && ( {hasObjectUpdatePermissions && (
<Button <Button
Icon={IconPlus} Icon={IconPlus}
title="New task" title="New task"