Fix KeyboardShortcut menu, person upload picture (#2669)

* Fix KeyboardShortcut menu, person upload picture

* Fixes
This commit is contained in:
Charles Bochet
2023-11-23 13:44:54 +01:00
committed by GitHub
parent 9c4f402102
commit 9dabe44d0f
16 changed files with 168 additions and 35 deletions

View File

@ -92,17 +92,16 @@ export const ShowPageSummaryCard = ({
if (e.target.files) onUploadPicture?.(e.target.files[0]);
};
// Todo - add back in when we have the ability to upload a picture
// const handleAvatarClick = () => {
// inputFileRef?.current?.click?.();
// };
const handleAvatarClick = () => {
inputFileRef?.current?.click?.();
};
return (
<StyledShowPageSummaryCard>
<StyledAvatarWrapper>
<Avatar
avatarUrl={logoOrAvatar}
// onClick={onUploadPicture ? handleAvatarClick : undefined}
onClick={onUploadPicture ? handleAvatarClick : undefined}
size="xl"
colorId={id}
placeholder={title}

View File

@ -284,7 +284,10 @@ export const useRecordTable = (props?: useRecordTableProps) => {
useScopedHotkeys(
[Key.Escape],
() => {
setHotkeyScope(TableHotkeyScope.Table, { goto: true });
setHotkeyScope(TableHotkeyScope.Table, {
goto: true,
keyboardShortcutMenu: true,
});
disableSoftFocus();
},
TableHotkeyScope.TableSoftFocus,

View File

@ -5,7 +5,7 @@ import { HotkeyScope } from '../types/HotkeyScope';
export const DEFAULT_HOTKEYS_SCOPE_CUSTOM_SCOPES: CustomHotkeyScopes = {
commandMenu: true,
goto: false,
keyboardShortcutMenu: true,
keyboardShortcutMenu: false,
};
export const INITIAL_HOTKEYS_SCOPE: HotkeyScope = {

View File

@ -55,7 +55,7 @@ export const useSetHotkeyScope = () =>
customScopes: {
commandMenu: customScopes?.commandMenu ?? true,
goto: customScopes?.goto ?? false,
keyboardShortcutMenu: customScopes?.keyboardShortcutMenu ?? true,
keyboardShortcutMenu: customScopes?.keyboardShortcutMenu ?? false,
},
};