feat: better server lint (#2850)

* feat: add stylistic eslint plugin

* feat: add missing line return

* feat: secure line-break style

* feat: disallow break before else

* feat: line between class members

* feat: better new line lint rule

server/src/core/auth/auth.resolver.ts

@@ -47,6 +47,7 @@ export class AuthResolver {
     const { exists } = await this.authService.checkUserExists(
       checkUserExistsInput.email,
     );
+
     return { exists };
   }
 

server/src/core/auth/guards/google-provider-enabled.guard.ts

@@ -8,12 +8,14 @@ import { GoogleStrategy } from 'src/core/auth/strategies/google.auth.strategy';
 @Injectable()
 export class GoogleProviderEnabledGuard implements CanActivate {
   constructor(private readonly environmentService: EnvironmentService) {}
+
   canActivate(): boolean | Promise<boolean> | Observable<boolean> {
     if (!this.environmentService.isAuthGoogleEnabled()) {
       throw new NotFoundException('Google auth is not enabled');
     }
 
     new GoogleStrategy(this.environmentService);
+
     return true;
   }
 }

server/src/core/auth/services/auth.service.ts

@@ -89,10 +89,12 @@ export class AuthService {
     const existingUser = await this.userRepository.findOneBy({
       email: email,
     });
+
     assert(!existingUser, 'This user already exists', ForbiddenException);
 
     if (password) {
       const isPasswordValid = PASSWORD_REGEX.test(password);
+
       assert(isPasswordValid, 'Password too weak', BadRequestException);
     }
 
@@ -115,6 +117,7 @@ export class AuthService {
         domainName: '',
         inviteHash: v4(),
       });
+
       workspace = await this.workspaceRepository.save(workspaceToCreate);
       await this.workspaceManagerService.init(workspace.id);
     }

server/src/core/auth/services/token.service.ts

@@ -34,6 +34,7 @@ export class TokenService {
 
   async generateAccessToken(userId: string): Promise<AuthToken> {
     const expiresIn = this.environmentService.getAccessTokenExpiresIn();
+
     assert(expiresIn, '', InternalServerErrorException);
     const expiresAt = addMilliseconds(new Date().getTime(), ms(expiresIn));
 
@@ -64,6 +65,7 @@ export class TokenService {
   async generateRefreshToken(userId: string): Promise<AuthToken> {
     const secret = this.environmentService.getRefreshTokenSecret();
     const expiresIn = this.environmentService.getRefreshTokenExpiresIn();
+
     assert(expiresIn, '', InternalServerErrorException);
     const expiresAt = addMilliseconds(new Date().getTime(), ms(expiresIn));
 
@@ -94,6 +96,7 @@ export class TokenService {
   async generateLoginToken(email: string): Promise<AuthToken> {
     const secret = this.environmentService.getLoginTokenSecret();
     const expiresIn = this.environmentService.getLoginTokenExpiresIn();
+
     assert(expiresIn, '', InternalServerErrorException);
     const expiresAt = addMilliseconds(new Date().getTime(), ms(expiresIn));
     const jwtPayload = {
@@ -122,6 +125,7 @@ export class TokenService {
     };
     const secret = this.environmentService.getAccessTokenSecret();
     let expiresIn: string | number;
+
     if (expiresAt) {
       expiresIn = Math.floor(
         (new Date(expiresAt).getTime() - new Date().getTime()) / 1000,
@@ -134,6 +138,7 @@ export class TokenService {
       expiresIn,
       jwtid: apiKeyId,
     });
+
     return { token };
   }
 

server/src/core/auth/strategies/google.auth.strategy.ts

@@ -59,6 +59,7 @@ export class GoogleStrategy extends PassportStrategy(Strategy, 'google') {
       picture: photos?.[0]?.value,
       workspaceInviteHash: state.workspaceInviteHash,
     };
+
     done(null, user);
   }
 }

server/src/core/auth/strategies/jwt.auth.strategy.ts

@@ -41,6 +41,7 @@ export class JwtAuthStrategy extends PassportStrategy(Strategy, 'jwt') {
     const workspace = await this.workspaceRepository.findOneBy({
       id: payload.workspaceId ?? payload.sub,
     });
+
     if (!workspace) {
       throw new UnauthorizedException();
     }
@@ -66,6 +67,7 @@ export class JwtAuthStrategy extends PassportStrategy(Strategy, 'jwt') {
     }
 
     let user;
+
     if (payload.workspaceId) {
       user = await this.userRepository.findOneBy({
         id: payload.sub,