Fix/task page filter (#2682)

* Fixed filter

* Removed console.log
This commit is contained in:
Lucas Bordeau
2023-11-23 23:29:54 +01:00
committed by GitHub
parent de5b86ee66
commit a0478a0a83
3 changed files with 44 additions and 13 deletions

View File

@ -1,3 +1,4 @@
import { isNonEmptyString } from '@sniptt/guards';
import { useRecoilState, useRecoilValue } from 'recoil';
import { Activity, ActivityType } from '@/activities/types/Activity';
@ -47,7 +48,10 @@ export const useOpenCreateActivityDrawer = () => {
const createdActivity = await createOneActivity?.({
authorId: currentWorkspaceMember?.id,
assigneeId: assigneeId ?? currentWorkspaceMember?.id,
assigneeId:
assigneeId ?? isNonEmptyString(currentWorkspaceMember?.id)
? currentWorkspaceMember?.id
: undefined,
type: type,
});

View File

@ -1,3 +1,5 @@
import { isNonEmptyString } from '@sniptt/guards';
import { useOpenCreateActivityDrawer } from '@/activities/hooks/useOpenCreateActivityDrawer';
import { PageAddButton } from '@/ui/layout/page/PageAddButton';
import { useFilter } from '@/ui/object/object-filter-dropdown/hooks/useFilter';
@ -9,7 +11,9 @@ export const PageAddTaskButton = () => {
const handleClick = () => {
openCreateActivity({
type: 'Task',
assigneeId: selectedFilter?.value,
assigneeId: isNonEmptyString(selectedFilter?.value)
? selectedFilter?.value
: undefined,
});
};

View File

@ -1,21 +1,26 @@
import { isNonEmptyString } from '@sniptt/guards';
import { DateTime } from 'luxon';
import { undefined } from 'zod';
import { Activity } from '@/activities/types/Activity';
import { ActivityTargetableEntity } from '@/activities/types/ActivityTargetableEntity';
import { useFindManyObjectRecords } from '@/object-record/hooks/useFindManyObjectRecords';
import { useFilter } from '@/ui/object/object-filter-dropdown/hooks/useFilter';
import { parseDate } from '~/utils/date-utils';
import { isDefined } from '~/utils/isDefined';
export const useTasks = (entity?: ActivityTargetableEntity) => {
const { selectedFilter } = useFilter();
const { objects: activityTargets } = useFindManyObjectRecords({
objectNamePlural: 'activityTargets',
filter: {
[entity?.type === 'Company' ? 'companyId' : 'personId']: {
eq: entity?.id,
},
},
filter: isDefined(entity)
? {
[entity?.type === 'Company' ? 'companyId' : 'personId']: {
eq: entity?.id,
},
}
: undefined,
});
const { objects: completeTasksData } = useFindManyObjectRecords({
@ -23,10 +28,19 @@ export const useTasks = (entity?: ActivityTargetableEntity) => {
skip: !entity && !selectedFilter,
filter: {
completedAt: { is: 'NOT_NULL' },
id: {
in: activityTargets?.map((activityTarget) => activityTarget.activityId),
},
id: isDefined(entity)
? {
in: activityTargets?.map(
(activityTarget) => activityTarget.activityId,
),
}
: undefined,
type: { eq: 'Task' },
assigneeId: isNonEmptyString(selectedFilter?.value)
? {
eq: selectedFilter?.value,
}
: undefined,
},
orderBy: {
createdAt: 'DescNullsFirst',
@ -38,10 +52,19 @@ export const useTasks = (entity?: ActivityTargetableEntity) => {
skip: !entity && !selectedFilter,
filter: {
completedAt: { is: 'NULL' },
id: {
in: activityTargets?.map((activityTarget) => activityTarget.activityId),
},
id: isDefined(entity)
? {
in: activityTargets?.map(
(activityTarget) => activityTarget.activityId,
),
}
: undefined,
type: { eq: 'Task' },
assigneeId: isNonEmptyString(selectedFilter?.value)
? {
eq: selectedFilter?.value,
}
: undefined,
},
orderBy: {
createdAt: 'DescNullsFirst',