admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Chore: Edit button on cells should be guessed by the field's type (#1952)

Browse Source 
* created custom hook to get Icon Component as per field type

* Fix conflicts

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
This commit is contained in:
Ayush Agrawal
2023-10-18 02:12:57 +05:30
committed by GitHub
parent 2c1ad1661a
commit a1a2309140
10 changed files with 40 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
front/src/modules/companies/components/CompanyBoardCard.tsx
View File

@ -169,7 +169,6 @@ export const CompanyBoardCard = () => {
Icon: viewField.Icon,
type: viewField.type,
metadata: viewField.metadata,
buttonIcon: viewField.buttonIcon,
entityChipDisplayMapper: viewField.entityChipDisplayMapper,
},
useUpdateEntityMutation: useUpdateOnePipelineProgressMutation,

8
front/src/modules/companies/constants/companiesAvailableColumnDefinitions.tsx
View File

@ -11,7 +11,6 @@ import {
FieldURLMetadata,
} from '@/ui/data/field/types/FieldMetadata';
import {
IconArrowUpRight,
IconBrandLinkedin,
IconBrandX,
IconBuildingSkyscraper,
@ -19,7 +18,6 @@ import {
IconLink,
IconMap,
IconMoneybag,
IconPencil,
IconTarget,
IconUserCircle,
IconUsers,
@ -43,7 +41,6 @@ export const companiesAvailableColumnDefinitions: ColumnDefinition<FieldMetadata
placeHolder: 'Company Name',
},
isVisible: true,
buttonIcon: IconArrowUpRight,
infoTooltipContent: 'The company name.',
basePathToShowPage: '/companies/',
} satisfies ColumnDefinition<FieldChipMetadata>,
@ -59,7 +56,6 @@ export const companiesAvailableColumnDefinitions: ColumnDefinition<FieldMetadata
placeHolder: 'example.com',
},
isVisible: true,
buttonIcon: IconPencil,
infoTooltipContent:
'The company website URL. We use this url to fetch the company icon.',
} satisfies ColumnDefinition<FieldURLMetadata>,
@ -125,7 +121,6 @@ export const companiesAvailableColumnDefinitions: ColumnDefinition<FieldMetadata
placeHolder: 'LinkedIn URL',
},
isVisible: true,
buttonIcon: IconPencil,
infoTooltipContent: 'The company Linkedin account.',
} satisfies ColumnDefinition<FieldURLMetadata>,
{
@ -182,7 +177,6 @@ export const companiesAvailableColumnDefinitions: ColumnDefinition<FieldMetadata
placeHolder: 'X',
},
isVisible: false,
buttonIcon: IconPencil,
infoTooltipContent: 'The company Twitter account.',
} satisfies ColumnDefinition<FieldURLMetadata>,
];
@ -201,7 +195,6 @@ export const suppliersAvailableColumnDefinitions: ColumnDefinition<FieldMetadata
placeHolder: 'Company Name',
},
isVisible: true,
buttonIcon: IconArrowUpRight,
infoTooltipContent: 'The company name.',
basePathToShowPage: '/companies/',
} satisfies ColumnDefinition<FieldTextMetadata>,
@ -217,7 +210,6 @@ export const suppliersAvailableColumnDefinitions: ColumnDefinition<FieldMetadata
placeHolder: 'Company Name',
},
isVisible: true,
buttonIcon: IconArrowUpRight,
infoTooltipContent: 'The company name.',
basePathToShowPage: '/companies/',
} satisfies ColumnDefinition<FieldTextMetadata>,