From a2004e62200228ec155d520236cbf4da3ae2fbcf Mon Sep 17 00:00:00 2001 From: Charles Bochet Date: Thu, 13 Mar 2025 15:19:20 +0100 Subject: [PATCH] Fix storybook stories (#10853) Small PR to fix flaky stories --- .../__stories__/FormEmailsFieldInput.stories.tsx | 9 ++++++--- .../__stories__/FormTextFieldInput.stories.tsx | 8 +++++--- .../components/__stories__/ExpandableList.stories.tsx | 2 +- .../WorkflowEditActionUpdateRecord.stories.tsx | 7 ++----- .../settings/__stories__/SettingsProfile.stories.tsx | 10 ---------- 5 files changed, 14 insertions(+), 22 deletions(-) diff --git a/packages/twenty-front/src/modules/object-record/record-field/form-types/components/__stories__/FormEmailsFieldInput.stories.tsx b/packages/twenty-front/src/modules/object-record/record-field/form-types/components/__stories__/FormEmailsFieldInput.stories.tsx index d4e432bcc..eb290d2f7 100644 --- a/packages/twenty-front/src/modules/object-record/record-field/form-types/components/__stories__/FormEmailsFieldInput.stories.tsx +++ b/packages/twenty-front/src/modules/object-record/record-field/form-types/components/__stories__/FormEmailsFieldInput.stories.tsx @@ -1,5 +1,5 @@ import { Meta, StoryObj } from '@storybook/react'; -import { expect, fn, userEvent, within } from '@storybook/test'; +import { expect, fn, userEvent, waitFor, within } from '@storybook/test'; import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator'; import { WorkflowStepDecorator } from '~/testing/decorators/WorkflowStepDecorator'; import { MOCKED_STEP_ID } from '~/testing/mock-data/workflow'; @@ -68,8 +68,11 @@ export const Disabled: Story = { play: async ({ canvasElement, args }) => { const canvas = within(canvasElement); - const editor = canvasElement.querySelector('.ProseMirror > p'); - expect(editor).toBeVisible(); + const editor = await waitFor(() => { + const editor = canvasElement.querySelector('.ProseMirror > p'); + expect(editor).toBeVisible(); + return editor; + }); const defaultValue = await canvas.findByText('tim@twenty.com'); expect(defaultValue).toBeVisible(); diff --git a/packages/twenty-front/src/modules/object-record/record-field/form-types/components/__stories__/FormTextFieldInput.stories.tsx b/packages/twenty-front/src/modules/object-record/record-field/form-types/components/__stories__/FormTextFieldInput.stories.tsx index 0ec230a2c..12acf9e9c 100644 --- a/packages/twenty-front/src/modules/object-record/record-field/form-types/components/__stories__/FormTextFieldInput.stories.tsx +++ b/packages/twenty-front/src/modules/object-record/record-field/form-types/components/__stories__/FormTextFieldInput.stories.tsx @@ -185,9 +185,11 @@ export const DisabledWithVariable: Story = { readonly: true, }, play: async ({ canvasElement }) => { - const editor = canvasElement.querySelector('.ProseMirror > p'); - - expect(editor).toBeVisible(); + const editor = await waitFor(() => { + const editor = canvasElement.querySelector('.ProseMirror > p'); + expect(editor).toBeVisible(); + return editor; + }); await waitFor(() => { expect(editor).toHaveTextContent('test Name test'); diff --git a/packages/twenty-front/src/modules/ui/layout/expandable-list/components/__stories__/ExpandableList.stories.tsx b/packages/twenty-front/src/modules/ui/layout/expandable-list/components/__stories__/ExpandableList.stories.tsx index 374cce311..03f2f9222 100644 --- a/packages/twenty-front/src/modules/ui/layout/expandable-list/components/__stories__/ExpandableList.stories.tsx +++ b/packages/twenty-front/src/modules/ui/layout/expandable-list/components/__stories__/ExpandableList.stories.tsx @@ -58,7 +58,7 @@ export const WithExpandedList: Story = { const rootCanvas = within(root); - const chipCount = await rootCanvas.findByText('+3'); + const chipCount = await rootCanvas.findByText('+2'); await userEvent.click(chipCount); diff --git a/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/components/__stories__/WorkflowEditActionUpdateRecord.stories.tsx b/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/components/__stories__/WorkflowEditActionUpdateRecord.stories.tsx index 9264d9e79..759c4a703 100644 --- a/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/components/__stories__/WorkflowEditActionUpdateRecord.stories.tsx +++ b/packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/components/__stories__/WorkflowEditActionUpdateRecord.stories.tsx @@ -159,12 +159,9 @@ export const DisabledWithDefaultStaticValues: Story = { await userEvent.click(objectSelectCurrentValue); - { - const searchInputInSelectDropdown = - canvas.queryByPlaceholderText('Search'); + const searchInputInSelectDropdown = canvas.queryByPlaceholderText('Search'); - expect(searchInputInSelectDropdown).not.toBeInTheDocument(); - } + expect(searchInputInSelectDropdown).not.toBeInTheDocument(); const selectedRecord = await canvas.findByText( `${peopleMock.name.firstName} ${peopleMock.name.lastName}`, diff --git a/packages/twenty-front/src/pages/settings/__stories__/SettingsProfile.stories.tsx b/packages/twenty-front/src/pages/settings/__stories__/SettingsProfile.stories.tsx index 4c674e352..f16591f3a 100644 --- a/packages/twenty-front/src/pages/settings/__stories__/SettingsProfile.stories.tsx +++ b/packages/twenty-front/src/pages/settings/__stories__/SettingsProfile.stories.tsx @@ -1,5 +1,4 @@ import { Meta, StoryObj } from '@storybook/react'; -import { userEvent, within } from '@storybook/test'; import { PageDecorator, @@ -27,12 +26,3 @@ export default meta; export type Story = StoryObj; export const Default: Story = {}; - -export const LogOut: Story = { - play: async ({ canvasElement }) => { - const canvas = within(canvasElement); - const logoutButton = await canvas.findByText('Logout'); - - await userEvent.click(logoutButton); - }, -};