admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Remove deprecated EMAIL, PHONE, LINK (#7551)

Browse Source 
In this PR:
- remove deprecated EMAIL, PHONE, LINK field types (except for Zapier
package as there is another work ongoing)
- remove composite currency filter on currencyCode, actor filter on name
and workspaceMember as the UX is not great yet
This commit is contained in:
Charles Bochet
2024-10-10 14:14:58 +02:00
committed by GitHub
parent a7d5aa933d
commit a58236e6da
87 changed files with 75 additions and 2746 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
packages/twenty-server/src/engine/core-modules/open-api/utils/__tests__/components.utils.spec.ts
View File

@ -1,20 +1,8 @@
import {
fields,
objectMetadataItemMock,
} from 'src/engine/api/__mocks__/object-metadata-item.mock';
import { objectMetadataItemMock } from 'src/engine/api/__mocks__/object-metadata-item.mock';
import { computeSchemaComponents } from 'src/engine/core-modules/open-api/utils/components.utils';
import { FieldMetadataType } from 'src/engine/metadata-modules/field-metadata/field-metadata.entity';
import { ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadata/object-metadata.entity';
describe('computeSchemaComponents', () => {
it('should test all non-deprecated field types', () => {
expect(fields.map((field) => field.type)).toEqual(
Object.keys(FieldMetadataType).filter(
(key) =>
key !== FieldMetadataType.LINK && key !== FieldMetadataType.TS_VECTOR,
),
);
});
it('should compute schema components', () => {
expect(
computeSchemaComponents([
@ -32,9 +20,6 @@ describe('computeSchemaComponents', () => {
fieldText: {
type: 'string',
},
fieldPhone: {
type: 'string',
},
fieldPhones: {
properties: {
additionalPhones: {
@ -49,10 +34,6 @@ describe('computeSchemaComponents', () => {
},
type: 'object',
},
fieldEmail: {
type: 'string',
format: 'email',
},
fieldEmails: {
type: 'object',
properties: {
@ -216,9 +197,6 @@ describe('computeSchemaComponents', () => {
fieldText: {
type: 'string',
},
fieldPhone: {
type: 'string',
},
fieldPhones: {
properties: {
additionalPhones: {
@ -233,10 +211,6 @@ describe('computeSchemaComponents', () => {
},
type: 'object',
},
fieldEmail: {
type: 'string',
format: 'email',
},
fieldEmails: {
type: 'object',
properties: {
@ -399,9 +373,6 @@ describe('computeSchemaComponents', () => {
fieldText: {
type: 'string',
},
fieldPhone: {
type: 'string',
},
fieldPhones: {
properties: {
additionalPhones: {
@ -416,10 +387,6 @@ describe('computeSchemaComponents', () => {
},
type: 'object',
},
fieldEmail: {
type: 'string',
format: 'email',
},
fieldEmails: {
type: 'object',
properties: {

4
packages/twenty-server/src/engine/core-modules/open-api/utils/components.utils.ts
View File

@ -56,11 +56,8 @@ const getFieldProperties = (
case FieldMetadataType.UUID:
return { type: 'string', format: 'uuid' };
case FieldMetadataType.TEXT:
case FieldMetadataType.PHONE:
case FieldMetadataType.RICH_TEXT:
return { type: 'string' };
case FieldMetadataType.EMAIL:
return { type: 'string', format: 'email' };
case FieldMetadataType.DATE_TIME:
return { type: 'string', format: 'date-time' };
case FieldMetadataType.DATE:
@ -139,7 +136,6 @@ const getSchemaComponentsProperties = ({
enum: field.options.map((option: { value: string }) => option.value),
};
break;
case FieldMetadataType.LINK:
case FieldMetadataType.LINKS:
case FieldMetadataType.CURRENCY:
case FieldMetadataType.FULL_NAME: