Remove deprecated EMAIL, PHONE, LINK (#7551)

In this PR: - remove deprecated EMAIL, PHONE, LINK field types (except for Zapier package as there is another work ongoing) - remove composite currency filter on currencyCode, actor filter on name and workspaceMember as the UX is not great yet
2024-10-10 14:14:58 +02:00
parent a7d5aa933d
commit a58236e6da
87 changed files with 75 additions and 2746 deletions
--- a/packages/twenty-server/src/engine/metadata-modules/field-metadata/composite-types/index.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/field-metadata/composite-types/index.ts
@ -5,7 +5,6 @@ import { addressCompositeType } from 'src/engine/metadata-modules/field-metadata
 import { currencyCompositeType } from 'src/engine/metadata-modules/field-metadata/composite-types/currency.composite-type';
 import { emailsCompositeType } from 'src/engine/metadata-modules/field-metadata/composite-types/emails.composite-type';
 import { fullNameCompositeType } from 'src/engine/metadata-modules/field-metadata/composite-types/full-name.composite-type';
-import { linkCompositeType } from 'src/engine/metadata-modules/field-metadata/composite-types/link.composite-type';
 import { linksCompositeType } from 'src/engine/metadata-modules/field-metadata/composite-types/links.composite-type';
 import { phonesCompositeType } from 'src/engine/metadata-modules/field-metadata/composite-types/phones.composite-type';
 import { FieldMetadataType } from 'src/engine/metadata-modules/field-metadata/field-metadata.entity';
@ -14,7 +13,6 @@ export const compositeTypeDefinitions = new Map<
  FieldMetadataType,
  CompositeType
 >([
-  [FieldMetadataType.LINK, linkCompositeType],
  [FieldMetadataType.LINKS, linksCompositeType],
  [FieldMetadataType.CURRENCY, currencyCompositeType],
  [FieldMetadataType.FULL_NAME, fullNameCompositeType],
--- a/packages/twenty-server/src/engine/metadata-modules/field-metadata/composite-types/link.composite-type.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/field-metadata/composite-types/link.composite-type.ts
@ -1,26 +0,0 @@
-import { CompositeType } from 'src/engine/metadata-modules/field-metadata/interfaces/composite-type.interface';
-
-import { FieldMetadataType } from 'src/engine/metadata-modules/field-metadata/field-metadata.entity';
-
-export const linkCompositeType: CompositeType = {
-  type: FieldMetadataType.LINK,
-  properties: [
-    {
-      name: 'label',
-      type: FieldMetadataType.TEXT,
-      hidden: false,
-      isRequired: false,
-    },
-    {
-      name: 'url',
-      type: FieldMetadataType.TEXT,
-      hidden: false,
-      isRequired: false,
-    },
-  ],
-};
-
-export type LinkMetadata = {
-  label: string;
-  url: string;
-};
--- a/packages/twenty-server/src/engine/metadata-modules/field-metadata/dtos/default-value.input.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/field-metadata/dtos/default-value.input.ts
@ -71,16 +71,6 @@ export class FieldMetadataDefaultValueDate {
  value: Date | null;
 }

-export class FieldMetadataDefaultValueLink {
-  @ValidateIf((object, value) => value !== null)
-  @IsQuotedString()
-  label: string | null;
-
-  @ValidateIf((object, value) => value !== null)
-  @IsQuotedString()
-  url: string | null;
-}
-
 export class FieldMetadataDefaultValueCurrency {
  @ValidateIf((object, value) => value !== null)
  @IsNumberString()
--- a/packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.entity.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.entity.ts
@ -24,16 +24,13 @@ import { RelationMetadataEntity } from 'src/engine/metadata-modules/relation-met
 export enum FieldMetadataType {
  UUID = 'UUID',
  TEXT = 'TEXT',
-  PHONE = 'PHONE',
  PHONES = 'PHONES',
-  EMAIL = 'EMAIL',
  EMAILS = 'EMAILS',
  DATE_TIME = 'DATE_TIME',
  DATE = 'DATE',
  BOOLEAN = 'BOOLEAN',
  NUMBER = 'NUMBER',
  NUMERIC = 'NUMERIC',
-  LINK = 'LINK',
  LINKS = 'LINKS',
  CURRENCY = 'CURRENCY',
  FULL_NAME = 'FULL_NAME',
--- a/packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.service.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.service.ts
@ -145,20 +145,6 @@ export class FieldMetadataService extends TypeOrmQueryService<FieldMetadataEntit
        fieldMetadataInput.options = generateRatingOptions();
      }

-      if (fieldMetadataInput.type === FieldMetadataType.LINK) {
-        throw new FieldMetadataException(
-          '"Link" field types are being deprecated, please use Links type instead',
-          FieldMetadataExceptionCode.INVALID_FIELD_INPUT,
-        );
-      }
-
-      if (fieldMetadataInput.type === FieldMetadataType.EMAIL) {
-        throw new FieldMetadataException(
-          '"Email" field types are being deprecated, please use Emails type instead',
-          FieldMetadataExceptionCode.INVALID_FIELD_INPUT,
-        );
-      }
-
      const fieldMetadataForCreate = {
        id: v4(),
        createdAt: new Date(),
--- a/packages/twenty-server/src/engine/metadata-modules/field-metadata/interfaces/field-metadata-default-value.interface.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/field-metadata/interfaces/field-metadata-default-value.interface.ts
@ -6,7 +6,6 @@ import {
  FieldMetadataDefaultValueDateTime,
  FieldMetadataDefaultValueEmails,
  FieldMetadataDefaultValueFullName,
-  FieldMetadataDefaultValueLink,
  FieldMetadataDefaultValueLinks,
  FieldMetadataDefaultValueNowFunction,
  FieldMetadataDefaultValueNumber,
@ -27,9 +26,7 @@ type FieldMetadataDefaultValueMapping = {
    | FieldMetadataDefaultValueString
    | FieldMetadataDefaultValueUuidFunction;
  [FieldMetadataType.TEXT]: FieldMetadataDefaultValueString;
-  [FieldMetadataType.PHONE]: FieldMetadataDefaultValueString;
  [FieldMetadataType.PHONES]: FieldMetadataDefaultValuePhones;
-  [FieldMetadataType.EMAIL]: FieldMetadataDefaultValueString;
  [FieldMetadataType.EMAILS]: FieldMetadataDefaultValueEmails;
  [FieldMetadataType.DATE_TIME]:
    | FieldMetadataDefaultValueDateTime
@ -41,7 +38,6 @@ type FieldMetadataDefaultValueMapping = {
  [FieldMetadataType.NUMBER]: FieldMetadataDefaultValueNumber;
  [FieldMetadataType.POSITION]: FieldMetadataDefaultValueNumber;
  [FieldMetadataType.NUMERIC]: FieldMetadataDefaultValueString;
-  [FieldMetadataType.LINK]: FieldMetadataDefaultValueLink;
  [FieldMetadataType.LINKS]: FieldMetadataDefaultValueLinks;
  [FieldMetadataType.CURRENCY]: FieldMetadataDefaultValueCurrency;
  [FieldMetadataType.FULL_NAME]: FieldMetadataDefaultValueFullName;
--- a/packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/tests/generate-nullable.spec.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/tests/generate-nullable.spec.ts
@ -4,16 +4,10 @@ import { generateNullable } from 'src/engine/metadata-modules/field-metadata/uti
 describe('generateNullable', () => {
  it('should generate a nullable value false for TEXT, EMAIL, PHONE no matter what the input is', () => {
    expect(generateNullable(FieldMetadataType.TEXT, false)).toEqual(false);
-    expect(generateNullable(FieldMetadataType.PHONE, false)).toEqual(false);
-    expect(generateNullable(FieldMetadataType.EMAIL, false)).toEqual(false);

    expect(generateNullable(FieldMetadataType.TEXT, true)).toEqual(false);
-    expect(generateNullable(FieldMetadataType.PHONE, true)).toEqual(false);
-    expect(generateNullable(FieldMetadataType.EMAIL, true)).toEqual(false);

    expect(generateNullable(FieldMetadataType.TEXT)).toEqual(false);
-    expect(generateNullable(FieldMetadataType.PHONE)).toEqual(false);
-    expect(generateNullable(FieldMetadataType.EMAIL)).toEqual(false);
  });

  it('should should return true if no input is given', () => {
--- a/packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/tests/validate-default-value-based-on-type.spec.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/tests/validate-default-value-based-on-type.spec.ts
@ -40,32 +40,6 @@ describe('validateDefaultValueForType', () => {
    ).toBe(false);
  });

-  it('should validate string default value for PHONE type', () => {
-    expect(
-      validateDefaultValueForType(FieldMetadataType.PHONE, "'+123456789'")
-        .isValid,
-    ).toBe(true);
-  });
-
-  it('should return false for invalid string default value for PHONE type', () => {
-    expect(
-      validateDefaultValueForType(FieldMetadataType.PHONE, 123).isValid,
-    ).toBe(false);
-  });
-
-  it('should validate string default value for EMAIL type', () => {
-    expect(
-      validateDefaultValueForType(FieldMetadataType.EMAIL, "'test@example.com'")
-        .isValid,
-    ).toBe(true);
-  });
-
-  it('should return false for invalid string default value for EMAIL type', () => {
-    expect(
-      validateDefaultValueForType(FieldMetadataType.EMAIL, 123).isValid,
-    ).toBe(false);
-  });
-
  it('should validate number default value for NUMBER type', () => {
    expect(
      validateDefaultValueForType(FieldMetadataType.NUMBER, 100).isValid,
@ -90,27 +64,6 @@ describe('validateDefaultValueForType', () => {
    ).toBe(false);
  });

-  // LINK type
-  it('should validate LINK default value', () => {
-    expect(
-      validateDefaultValueForType(FieldMetadataType.LINK, {
-        label: "'http://example.com'",
-        url: "'Example'",
-      }).isValid,
-    ).toBe(true);
-  });
-
-  it('should return false for invalid LINK default value', () => {
-    expect(
-      validateDefaultValueForType(
-        // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-        // @ts-expect-error Just for testing purposes
-        { label: 123, url: {} },
-        FieldMetadataType.LINK,
-      ).isValid,
-    ).toBe(false);
-  });
-
  // CURRENCY type
  it('should validate CURRENCY default value', () => {
    expect(
--- a/packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/generate-default-value.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/generate-default-value.ts
@ -7,8 +7,6 @@ export function generateDefaultValue(
 ): FieldMetadataDefaultValue {
  switch (type) {
    case FieldMetadataType.TEXT:
-    case FieldMetadataType.PHONE:
-    case FieldMetadataType.EMAIL:
      return "''";
    case FieldMetadataType.EMAILS:
      return {
@ -31,11 +29,6 @@ export function generateDefaultValue(
        addressLat: null,
        addressLng: null,
      };
-    case FieldMetadataType.LINK:
-      return {
-        url: "''",
-        label: "''",
-      };
    case FieldMetadataType.CURRENCY:
      return {
        amountMicros: null,
--- a/packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/generate-nullable.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/generate-nullable.ts
@ -11,8 +11,6 @@ export function generateNullable(

  switch (type) {
    case FieldMetadataType.TEXT:
-    case FieldMetadataType.PHONE:
-    case FieldMetadataType.EMAIL:
      return false;
    default:
      return inputNullableValue ?? true;
--- a/packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/is-composite-field-metadata-type.util.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/is-composite-field-metadata-type.util.ts
@ -3,7 +3,6 @@ import { FieldMetadataType } from 'src/engine/metadata-modules/field-metadata/fi
 export const isCompositeFieldMetadataType = (
  type: FieldMetadataType,
 ): type is
-  | FieldMetadataType.LINK
  | FieldMetadataType.CURRENCY
  | FieldMetadataType.FULL_NAME
  | FieldMetadataType.ADDRESS
@ -12,7 +11,6 @@ export const isCompositeFieldMetadataType = (
  | FieldMetadataType.EMAILS
  | FieldMetadataType.PHONES => {
  return [
-    FieldMetadataType.LINK,
    FieldMetadataType.CURRENCY,
    FieldMetadataType.FULL_NAME,
    FieldMetadataType.ADDRESS,
--- a/packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/validate-default-value-for-type.util.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/validate-default-value-for-type.util.ts
@ -15,7 +15,6 @@ import {
  FieldMetadataDefaultValueDateTime,
  FieldMetadataDefaultValueEmails,
  FieldMetadataDefaultValueFullName,
-  FieldMetadataDefaultValueLink,
  FieldMetadataDefaultValueLinks,
  FieldMetadataDefaultValueNowFunction,
  FieldMetadataDefaultValueNumber,
@ -34,8 +33,6 @@ export const defaultValueValidatorsMap = {
    FieldMetadataDefaultValueUuidFunction,
  ],
  [FieldMetadataType.TEXT]: [FieldMetadataDefaultValueString],
-  [FieldMetadataType.PHONE]: [FieldMetadataDefaultValueString],
-  [FieldMetadataType.EMAIL]: [FieldMetadataDefaultValueString],
  [FieldMetadataType.DATE_TIME]: [
    FieldMetadataDefaultValueDateTime,
    FieldMetadataDefaultValueNowFunction,
@ -44,7 +41,6 @@ export const defaultValueValidatorsMap = {
  [FieldMetadataType.BOOLEAN]: [FieldMetadataDefaultValueBoolean],
  [FieldMetadataType.NUMBER]: [FieldMetadataDefaultValueNumber],
  [FieldMetadataType.NUMERIC]: [FieldMetadataDefaultValueString],
-  [FieldMetadataType.LINK]: [FieldMetadataDefaultValueLink],
  [FieldMetadataType.CURRENCY]: [FieldMetadataDefaultValueCurrency],
  [FieldMetadataType.FULL_NAME]: [FieldMetadataDefaultValueFullName],
  [FieldMetadataType.RATING]: [FieldMetadataDefaultValueString],
--- a/packages/twenty-server/src/engine/metadata-modules/workspace-migration/factories/basic-column-action.factory.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/workspace-migration/factories/basic-column-action.factory.ts
@ -21,8 +21,6 @@ import {
 export type BasicFieldMetadataType =
  | FieldMetadataType.UUID
  | FieldMetadataType.TEXT
-  | FieldMetadataType.PHONE
-  | FieldMetadataType.EMAIL
  | FieldMetadataType.NUMERIC
  | FieldMetadataType.NUMBER
  | FieldMetadataType.BOOLEAN
--- a/packages/twenty-server/src/engine/metadata-modules/workspace-migration/factories/composite-column-action.factory.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/workspace-migration/factories/composite-column-action.factory.ts
@ -23,7 +23,6 @@ export type CompositeFieldMetadataType =
  | FieldMetadataType.ADDRESS
  | FieldMetadataType.CURRENCY
  | FieldMetadataType.FULL_NAME
-  | FieldMetadataType.LINK
  | FieldMetadataType.LINKS
  | FieldMetadataType.EMAILS
  | FieldMetadataType.PHONES;
--- a/packages/twenty-server/src/engine/metadata-modules/workspace-migration/utils/field-metadata-type-to-column-type.util.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/workspace-migration/utils/field-metadata-type-to-column-type.util.ts
@ -18,9 +18,6 @@ export const fieldMetadataTypeToColumnType = <Type extends FieldMetadataType>(
    case FieldMetadataType.RICH_TEXT:
    case FieldMetadataType.ARRAY:
      return 'text';
-    case FieldMetadataType.PHONE:
-    case FieldMetadataType.EMAIL:
-      return 'varchar';
    case FieldMetadataType.NUMERIC:
      return 'numeric';
    case FieldMetadataType.NUMBER:
--- a/packages/twenty-server/src/engine/metadata-modules/workspace-migration/workspace-migration.factory.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/workspace-migration/workspace-migration.factory.ts
@ -52,24 +52,6 @@ export class WorkspaceMigrationFactory {
          },
        },
      ],
-      [
-        FieldMetadataType.PHONE,
-        {
-          factory: this.basicColumnActionFactory,
-          options: {
-            defaultValue: '',
-          },
-        },
-      ],
-      [
-        FieldMetadataType.EMAIL,
-        {
-          factory: this.basicColumnActionFactory,
-          options: {
-            defaultValue: '',
-          },
-        },
-      ],
      [FieldMetadataType.NUMERIC, { factory: this.basicColumnActionFactory }],
      [FieldMetadataType.NUMBER, { factory: this.basicColumnActionFactory }],
      [FieldMetadataType.POSITION, { factory: this.basicColumnActionFactory }],
@ -84,7 +66,6 @@ export class WorkspaceMigrationFactory {
        FieldMetadataType.MULTI_SELECT,
        { factory: this.enumColumnActionFactory },
      ],
-      [FieldMetadataType.LINK, { factory: this.compositeColumnActionFactory }],
      [
        FieldMetadataType.CURRENCY,
        { factory: this.compositeColumnActionFactory },