Remove deprecated EMAIL, PHONE, LINK (#7551)

In this PR:
- remove deprecated EMAIL, PHONE, LINK field types (except for Zapier
package as there is another work ongoing)
- remove composite currency filter on currencyCode, actor filter on name
and workspaceMember as the UX is not great yet

packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/__tests__/generate-nullable.spec.ts

@@ -4,16 +4,10 @@ import { generateNullable } from 'src/engine/metadata-modules/field-metadata/uti
 describe('generateNullable', () => {
   it('should generate a nullable value false for TEXT, EMAIL, PHONE no matter what the input is', () => {
     expect(generateNullable(FieldMetadataType.TEXT, false)).toEqual(false);
-    expect(generateNullable(FieldMetadataType.PHONE, false)).toEqual(false);
-    expect(generateNullable(FieldMetadataType.EMAIL, false)).toEqual(false);
 
     expect(generateNullable(FieldMetadataType.TEXT, true)).toEqual(false);
-    expect(generateNullable(FieldMetadataType.PHONE, true)).toEqual(false);
-    expect(generateNullable(FieldMetadataType.EMAIL, true)).toEqual(false);
 
     expect(generateNullable(FieldMetadataType.TEXT)).toEqual(false);
-    expect(generateNullable(FieldMetadataType.PHONE)).toEqual(false);
-    expect(generateNullable(FieldMetadataType.EMAIL)).toEqual(false);
   });
 
   it('should should return true if no input is given', () => {

packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/__tests__/validate-default-value-based-on-type.spec.ts

@@ -40,32 +40,6 @@ describe('validateDefaultValueForType', () => {
     ).toBe(false);
   });
 
-  it('should validate string default value for PHONE type', () => {
-    expect(
-      validateDefaultValueForType(FieldMetadataType.PHONE, "'+123456789'")
-        .isValid,
-    ).toBe(true);
-  });
-
-  it('should return false for invalid string default value for PHONE type', () => {
-    expect(
-      validateDefaultValueForType(FieldMetadataType.PHONE, 123).isValid,
-    ).toBe(false);
-  });
-
-  it('should validate string default value for EMAIL type', () => {
-    expect(
-      validateDefaultValueForType(FieldMetadataType.EMAIL, "'test@example.com'")
-        .isValid,
-    ).toBe(true);
-  });
-
-  it('should return false for invalid string default value for EMAIL type', () => {
-    expect(
-      validateDefaultValueForType(FieldMetadataType.EMAIL, 123).isValid,
-    ).toBe(false);
-  });
-
   it('should validate number default value for NUMBER type', () => {
     expect(
       validateDefaultValueForType(FieldMetadataType.NUMBER, 100).isValid,
@@ -90,27 +64,6 @@ describe('validateDefaultValueForType', () => {
     ).toBe(false);
   });
 
-  // LINK type
-  it('should validate LINK default value', () => {
-    expect(
-      validateDefaultValueForType(FieldMetadataType.LINK, {
-        label: "'http://example.com'",
-        url: "'Example'",
-      }).isValid,
-    ).toBe(true);
-  });
-
-  it('should return false for invalid LINK default value', () => {
-    expect(
-      validateDefaultValueForType(
-        // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-        // @ts-expect-error Just for testing purposes
-        { label: 123, url: {} },
-        FieldMetadataType.LINK,
-      ).isValid,
-    ).toBe(false);
-  });
-
   // CURRENCY type
   it('should validate CURRENCY default value', () => {
     expect(

packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/generate-default-value.ts

@@ -7,8 +7,6 @@ export function generateDefaultValue(
 ): FieldMetadataDefaultValue {
   switch (type) {
     case FieldMetadataType.TEXT:
-    case FieldMetadataType.PHONE:
-    case FieldMetadataType.EMAIL:
       return "''";
     case FieldMetadataType.EMAILS:
       return {
@@ -31,11 +29,6 @@ export function generateDefaultValue(
         addressLat: null,
         addressLng: null,
       };
-    case FieldMetadataType.LINK:
-      return {
-        url: "''",
-        label: "''",
-      };
     case FieldMetadataType.CURRENCY:
       return {
         amountMicros: null,

packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/generate-nullable.ts

@@ -11,8 +11,6 @@ export function generateNullable(
 
   switch (type) {
     case FieldMetadataType.TEXT:
-    case FieldMetadataType.PHONE:
-    case FieldMetadataType.EMAIL:
       return false;
     default:
       return inputNullableValue ?? true;

packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/is-composite-field-metadata-type.util.ts

@@ -3,7 +3,6 @@ import { FieldMetadataType } from 'src/engine/metadata-modules/field-metadata/fi
 export const isCompositeFieldMetadataType = (
   type: FieldMetadataType,
 ): type is
-  | FieldMetadataType.LINK
   | FieldMetadataType.CURRENCY
   | FieldMetadataType.FULL_NAME
   | FieldMetadataType.ADDRESS
@@ -12,7 +11,6 @@ export const isCompositeFieldMetadataType = (
   | FieldMetadataType.EMAILS
   | FieldMetadataType.PHONES => {
   return [
-    FieldMetadataType.LINK,
     FieldMetadataType.CURRENCY,
     FieldMetadataType.FULL_NAME,
     FieldMetadataType.ADDRESS,

packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/validate-default-value-for-type.util.ts

@@ -15,7 +15,6 @@ import {
   FieldMetadataDefaultValueDateTime,
   FieldMetadataDefaultValueEmails,
   FieldMetadataDefaultValueFullName,
-  FieldMetadataDefaultValueLink,
   FieldMetadataDefaultValueLinks,
   FieldMetadataDefaultValueNowFunction,
   FieldMetadataDefaultValueNumber,
@@ -34,8 +33,6 @@ export const defaultValueValidatorsMap = {
     FieldMetadataDefaultValueUuidFunction,
   ],
   [FieldMetadataType.TEXT]: [FieldMetadataDefaultValueString],
-  [FieldMetadataType.PHONE]: [FieldMetadataDefaultValueString],
-  [FieldMetadataType.EMAIL]: [FieldMetadataDefaultValueString],
   [FieldMetadataType.DATE_TIME]: [
     FieldMetadataDefaultValueDateTime,
     FieldMetadataDefaultValueNowFunction,
@@ -44,7 +41,6 @@ export const defaultValueValidatorsMap = {
   [FieldMetadataType.BOOLEAN]: [FieldMetadataDefaultValueBoolean],
   [FieldMetadataType.NUMBER]: [FieldMetadataDefaultValueNumber],
   [FieldMetadataType.NUMERIC]: [FieldMetadataDefaultValueString],
-  [FieldMetadataType.LINK]: [FieldMetadataDefaultValueLink],
   [FieldMetadataType.CURRENCY]: [FieldMetadataDefaultValueCurrency],
   [FieldMetadataType.FULL_NAME]: [FieldMetadataDefaultValueFullName],
   [FieldMetadataType.RATING]: [FieldMetadataDefaultValueString],