refactor: apply relation optimistic effects on record update (#3556)

* refactor: apply relation optimistic effects on record update

Related to #3509

* refactor: remove need to pass relation id field to create and update mutations

* fix: fix tests

* fix: fix SingleEntitySelect glitch

* fix: fix usePersistField tests

* fix: fix wrong import after rebase

* fix: fix several tests

* fix: fix test types

packages/twenty-front/src/modules/favorites/hooks/__mocks__/useFavorites.ts

@@ -5,7 +5,10 @@ import { ColorScheme } from '@/workspace-member/types/WorkspaceMember';
 
 export const mockId = '8f3b2121-f194-4ba4-9fbf-2d5a37126806';
 export const favoriteId = 'f088c8c9-05d2-4276-b065-b863cc7d0b33';
-export const mockRecord = { id: 'f088c8c9-05d2-4276-b065-b863cc7d0b33' };
+const favoriteTargetObjectId = 'f2d8b9e9-7932-4065-bc09-baf12388b75d';
+export const favoriteTargetObjectRecord = {
+  id: favoriteTargetObjectId,
+};
 
 export const initialFavorites = [
   {
@@ -88,8 +91,7 @@ export const mocks = [
       variables: {
         input: {
           id: mockId,
-          favoritesId: favoriteId,
-          favorites: { id: favoriteId },
+          personId: favoriteTargetObjectId,
           position: 4,
           workspaceMemberId: '1',
         },

packages/twenty-front/src/modules/favorites/hooks/__tests__/useFavorites.test.tsx

@@ -7,14 +7,15 @@ import { RecoilRoot, useSetRecoilState } from 'recoil';
 import { currentWorkspaceMemberState } from '@/auth/states/currentWorkspaceMemberState';
 import { useFavorites } from '@/favorites/hooks/useFavorites';
 import { objectMetadataItemsState } from '@/object-metadata/states/objectMetadataItemsState';
+import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
 import { getObjectMetadataItemsMock } from '@/object-metadata/utils/getObjectMetadataItemsMock';
 import { SnackBarProviderScope } from '@/ui/feedback/snack-bar-manager/scopes/SnackBarProviderScope';
 
 import {
   favoriteId,
+  favoriteTargetObjectRecord,
   initialFavorites,
   mockId,
-  mockRecord,
   mocks,
   mockWorkspaceMember,
   sortedFavorites,
@@ -84,7 +85,10 @@ describe('useFavorites', () => {
       },
     );
 
-    result.current.createFavorite(mockRecord, 'favorites');
+    result.current.createFavorite(
+      favoriteTargetObjectRecord,
+      CoreObjectNameSingular.Person,
+    );
 
     await waitFor(() => {
       expect(mocks[0].result).toHaveBeenCalled();

packages/twenty-front/src/modules/favorites/hooks/useFavorites.ts

@@ -95,8 +95,7 @@ export const useFavorites = () => {
     targetObjectNameSingular: string,
   ) => {
     createOneFavorite({
-      [`${targetObjectNameSingular}Id`]: targetRecord.id,
-      [`${targetObjectNameSingular}`]: targetRecord,
+      [targetObjectNameSingular]: targetRecord,
       position: favorites.length + 1,
       workspaceMemberId: currentWorkspaceMember?.id,
     });