Fix inline cell height issue and allow field settings update (#11248)

In this PR:
- allow to update settings on fields metadata (regression introduced by
a recent refactoring of fields-metadata update)
- revert changes introduced by
https://github.com/twentyhq/twenty/pull/11221
This commit is contained in:
Charles Bochet
2025-03-27 19:29:34 +01:00
committed by GitHub
parent e201da263d
commit a683827e4b
3 changed files with 25 additions and 17 deletions

View File

@ -75,7 +75,12 @@ export class BeforeUpdateOneField<T extends UpdateFieldInput>
locale?: keyof typeof APP_LOCALES,
): UpdateOneInputType<T> {
const update: StandardFieldUpdate = {};
const updatableFields = ['isActive', 'isLabelSyncedWithName', 'options'];
const updatableFields = [
'isActive',
'isLabelSyncedWithName',
'options',
'settings',
];
const overridableFields = ['label', 'icon', 'description'];
const nonUpdatableFields = Object.keys(instance.update).filter(
@ -110,6 +115,7 @@ export class BeforeUpdateOneField<T extends UpdateFieldInput>
this.handleLabelSyncedWithNameField(instance, update);
this.handleStandardOverrides(instance, fieldMetadata, update, locale);
this.handleOptionsField(instance, update);
this.handleSettingsField(instance, update);
return {
id: instance.id,
@ -128,6 +134,17 @@ export class BeforeUpdateOneField<T extends UpdateFieldInput>
update.options = instance.update.options;
}
private handleSettingsField(
instance: UpdateOneInputType<T>,
update: StandardFieldUpdate,
): void {
if (!isDefined(instance.update.settings)) {
return;
}
update.settings = instance.update.settings;
}
private handleActiveField(
instance: UpdateOneInputType<T>,
update: StandardFieldUpdate,