admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Deprecate old relations completely (#12482)

Browse Source 
# What

Fully deprecate old relations because we have one bug tied to it and it
make the codebase complex

# How I've made this PR:
1. remove metadata datasource (we only keep 'core') => this was causing
extra complexity in the refactor + flaky reset
2. merge dev and demo datasets => as I needed to update the tests which
is very painful, I don't want to do it twice
3. remove all code tied to RELATION_METADATA /
relation-metadata.resolver, or anything tied to the old relation system
4. Remove ONE_TO_ONE and MANY_TO_MANY that are not supported
5. fix impacts on the different areas : see functional testing below 

# Functional testing

## Functional testing from the front-end:
1. Database Reset ✅
2. Sign In ✅
3. Workspace sign-up ✅
5. Browsing table / kanban / show ✅
6. Assigning a record in a one to many / in a many to one ✅
7. Deleting a record involved in a relation ✅ => broken but not tied to
this PR
8. "Add new" from relation picker ✅ => broken but not tied to this PR
9. Creating a Task / Note, Updating a Task / Note relations, Deleting a
Task / Note (from table, show page, right drawer) ✅ => broken but not
tied to this PR
10. creating a relation from settings (custom / standard x oneToMany /
manyToOne) ✅
11. updating a relation from settings should not be possible ✅
12. deleting a relation from settings (custom / standard x oneToMany /
manyToOne) ✅
13. Make sure timeline activity still work (relation were involved
there), espacially with Task / Note => to be double checked ✅ => Cannot
convert undefined or null to object
14. Workspace deletion / User deletion ✅ 
15. CSV Import should keep working ✅ 
16. Permissions: I have tested without permissions V2 as it's still hard
to test v2 work and it's not in prod yet ✅
17. Workflows global test ✅ 

## From the API:
1. Review open-api documentation (REST) ✅ 
2. Make sure REST Api are still able to fetch relations ==> won't do, we
have a coupling Get/Update/Create there, this requires refactoring
3. Make sure REST Api is still able to update / remove relation => won't
do same

## Automated tests
1. lint + typescript ✅
2. front unit tests: ✅
3. server unit tests 2 ✅
4. front stories: ✅
5. server integration: ✅
6. chromatic check : expected 0
7. e2e check : expected no more that current failures

## Remove // Todos
1. All are captured by functional tests above, nothing additional to do

## (Un)related regressions
1. Table loading state is not working anymore, we see the empty state
before table content
2. Filtering by Creator Tim Ap return empty results
3. Not possible to add Tasks / Notes / Files from show page

# Result

## New seeds that can be easily extended
<img width="1920" alt="image"
src="https://github.com/user-attachments/assets/d290d130-2a5f-44e6-b419-7e42a89eec4b"
/>

## -5k lines of code
## No more 'metadata' dataSource (we only have 'core)
## No more relationMetadata (I haven't drop the table yet it's not
referenced in the code anymore)
## We are ready to fix the 6 months lag between current API results and
our mocked tests
## No more bug on relation creation / deletion

---------

Co-authored-by: Weiko <corentin@twenty.com>
Co-authored-by: Félix Malfait <felix@twenty.com>
This commit is contained in:
Charles Bochet
2025-06-10 16:45:27 +02:00
committed by GitHub
parent 264861e020
commit a68895189c
426 changed files with 48870 additions and 54125 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/twenty-front/src/modules/object-record/advanced-filter/utils/getAdvancedFilterInputPlacedholderText.ts
View File

@ -24,7 +24,7 @@ export const getAdvancedFilterInputPlaceholderText = (
case FieldMetadataType.ACTOR:
return 'Select actor';
case FieldMetadataType.RELATION:
return `Select ${fieldMetadataItem.relationDefinition?.targetObjectMetadata.nameSingular}`;
return `Select ${fieldMetadataItem.relation?.targetObjectMetadata.nameSingular}`;
case FieldMetadataType.SELECT:
case FieldMetadataType.MULTI_SELECT:
return `Select ${fieldMetadataItem.label}`;

14
packages/twenty-front/src/modules/object-record/cache/utils/__tests__/isObjectRecordConnection.test.ts vendored
View File

@ -1,12 +1,10 @@
import { FieldMetadataItem } from '@/object-metadata/types/FieldMetadataItem';
import { isObjectRecordConnection } from '@/object-record/cache/utils/isObjectRecordConnection';
import { RelationDefinitionType } from '~/generated-metadata/graphql';
import { RelationType } from '~/generated-metadata/graphql';
describe('isObjectRecordConnection', () => {
const relationDefinitionMap: { [K in RelationDefinitionType]: boolean } = {
[RelationDefinitionType.MANY_TO_MANY]: true,
[RelationDefinitionType.ONE_TO_MANY]: true,
[RelationDefinitionType.MANY_TO_ONE]: false,
[RelationDefinitionType.ONE_TO_ONE]: false,
const relationDefinitionMap: { [K in RelationType]: boolean } = {
[RelationType.ONE_TO_MANY]: true,
[RelationType.MANY_TO_ONE]: false,
};
it.each(Object.entries(relationDefinitionMap))(
@ -15,8 +13,8 @@ describe('isObjectRecordConnection', () => {
const emptyRecord = {};
const result = isObjectRecordConnection(
{
direction: relation,
} as NonNullable<FieldMetadataItem['relationDefinition']>,
type: relation,
} as NonNullable<FieldMetadataItem['relation']>,
emptyRecord,
);

16
packages/twenty-front/src/modules/object-record/cache/utils/getRecordNodeFromRecord.ts vendored
View File

@ -8,10 +8,7 @@ import { getRefName } from '@/object-record/cache/utils/getRefName';
import { RecordGqlNode } from '@/object-record/graphql/types/RecordGqlNode';
import { ObjectRecord } from '@/object-record/types/ObjectRecord';
import { isDefined } from 'twenty-shared/utils';
import {
FieldMetadataType,
RelationDefinitionType,
} from '~/generated-metadata/graphql';
import { FieldMetadataType, RelationType } from '~/generated-metadata/graphql';
import { pascalCase } from '~/utils/string/pascalCase';
export const getRecordNodeFromRecord = <T extends ObjectRecord>({
@ -63,13 +60,12 @@ export const getRecordNodeFromRecord = <T extends ObjectRecord>({
if (
field.type === FieldMetadataType.RELATION &&
field.relationDefinition?.direction ===
RelationDefinitionType.ONE_TO_MANY
field.relation?.type === RelationType.ONE_TO_MANY
) {
const oneToManyObjectMetadataItem = objectMetadataItems.find(
(item) =>
item.namePlural ===
field.relationDefinition?.targetObjectMetadata.namePlural,
field.relation?.targetObjectMetadata.namePlural,
);
if (!oneToManyObjectMetadataItem) {
@ -103,9 +99,7 @@ export const getRecordNodeFromRecord = <T extends ObjectRecord>({
}
if (
isUndefined(
field.relationDefinition?.targetObjectMetadata.nameSingular,
)
isUndefined(field.relation?.targetObjectMetadata.nameSingular)
) {
return undefined;
}
@ -119,7 +113,7 @@ export const getRecordNodeFromRecord = <T extends ObjectRecord>({
}
const typeName = getObjectTypename(
field.relationDefinition?.targetObjectMetadata.nameSingular,
field.relation?.targetObjectMetadata.nameSingular,
);
if (computeReferences) {

15
packages/twenty-front/src/modules/object-record/cache/utils/isObjectRecordConnection.ts vendored
View File

@ -1,23 +1,20 @@
import { FieldMetadataItem } from '@/object-metadata/types/FieldMetadataItem';
import { RecordGqlConnection } from '@/object-record/graphql/types/RecordGqlConnection';
import { assertUnreachable } from '@/workflow/utils/assertUnreachable';
import { RelationDefinitionType } from '~/generated-metadata/graphql';
import { RelationType } from '~/generated-metadata/graphql';
export const isObjectRecordConnection = (
relationDefinition: NonNullable<FieldMetadataItem['relationDefinition']>,
relation: NonNullable<FieldMetadataItem['relation']>,
value: unknown,
): value is RecordGqlConnection => {
switch (relationDefinition.direction) {
case RelationDefinitionType.MANY_TO_MANY:
case RelationDefinitionType.ONE_TO_MANY: {
switch (relation.type) {
case RelationType.ONE_TO_MANY: {
return true;
}
case RelationDefinitionType.MANY_TO_ONE:
case RelationDefinitionType.ONE_TO_ONE: {
case RelationType.MANY_TO_ONE:
return false;
}
default: {
return assertUnreachable(relationDefinition.direction);
return assertUnreachable(relation.type);
}
}
};

1
packages/twenty-front/src/modules/object-record/graphql/utils/__tests__/generateDepthOneWithoutRelationsRecordGqlFields.test.ts
View File

@ -11,7 +11,6 @@ describe('generateDepthOneWithoutRelationsRecordGqlFields', () => {
{
"avatarUrl": true,
"city": true,
"companyId": true,
"createdAt": true,
"createdBy": true,
"deletedAt": true,

6
packages/twenty-front/src/modules/object-record/hooks/__mocks__/personFragments.ts
View File

@ -67,6 +67,7 @@ export const PERSON_FRAGMENT_WITH_DEPTH_ONE_RELATIONS = `
opportunityId
personId
petId
rocketId
surveyResultId
taskId
type
@ -127,7 +128,6 @@ export const PERSON_FRAGMENT_WITH_DEPTH_ONE_RELATIONS = `
employees
id
idealCustomerProfile
internalCompetitions
introVideo {
primaryLinkUrl
primaryLinkLabel
@ -178,6 +178,7 @@ export const PERSON_FRAGMENT_WITH_DEPTH_ONE_RELATIONS = `
personId
petId
position
rocketId
surveyResultId
taskId
updatedAt
@ -229,6 +230,7 @@ export const PERSON_FRAGMENT_WITH_DEPTH_ONE_RELATIONS = `
opportunityId
personId
petId
rocketId
surveyResultId
updatedAt
}
@ -280,6 +282,7 @@ export const PERSON_FRAGMENT_WITH_DEPTH_ONE_RELATIONS = `
opportunityId
personId
petId
rocketId
surveyResultId
taskId
updatedAt
@ -304,6 +307,7 @@ export const PERSON_FRAGMENT_WITH_DEPTH_ONE_RELATIONS = `
personId
petId
properties
rocketId
surveyResultId
taskId
updatedAt

43
packages/twenty-front/src/modules/object-record/hooks/__tests__/useLazyLoadRecordIndexTable.test.tsx
View File

@ -40,7 +40,6 @@ const mocks: MockedResponse[] = [
__typename
avatarUrl
city
companyId
createdAt
createdBy {
source
@ -102,7 +101,6 @@ const mocks: MockedResponse[] = [
employees
id
idealCustomerProfile
internalCompetitions
introVideo {
primaryLinkUrl
primaryLinkLabel
@ -132,6 +130,10 @@ const mocks: MockedResponse[] = [
note {
__typename
body
bodyV2 {
blocknote
markdown
}
createdAt
createdBy {
source
@ -281,6 +283,22 @@ const mocks: MockedResponse[] = [
}
}
petId
rocket {
__typename
createdAt
createdBy {
source
workspaceMemberId
name
context
}
deletedAt
id
name
position
updatedAt
}
rocketId
surveyResult {
__typename
averageEstimatedNumberOfAtomsInTheUniverse
@ -352,7 +370,6 @@ const mocks: MockedResponse[] = [
employees
id
idealCustomerProfile
internalCompetitions
introVideo {
primaryLinkUrl
primaryLinkLabel
@ -514,6 +531,22 @@ const mocks: MockedResponse[] = [
}
}
petId
rocket {
__typename
createdAt
createdBy {
source
workspaceMemberId
name
context
}
deletedAt
id
name
position
updatedAt
}
rocketId
surveyResult {
__typename
averageEstimatedNumberOfAtomsInTheUniverse
@ -540,6 +573,10 @@ const mocks: MockedResponse[] = [
__typename
assigneeId
body
bodyV2 {
blocknote
markdown
}
createdAt
createdBy {
source

4
packages/twenty-front/src/modules/object-record/hooks/useAttachRelatedRecordFromRecord.ts
View File

@ -30,7 +30,7 @@ export const useAttachRelatedRecordFromRecord = ({
});
const relatedRecordObjectNameSingular =
fieldOnObject?.relationDefinition?.targetObjectMetadata.nameSingular;
fieldOnObject?.relation?.targetObjectMetadata.nameSingular;
if (!relatedRecordObjectNameSingular) {
throw new Error(
@ -43,7 +43,7 @@ export const useAttachRelatedRecordFromRecord = ({
});
const fieldOnRelatedObject =
fieldOnObject?.relationDefinition?.targetFieldMetadata.name;
fieldOnObject?.relation?.targetFieldMetadata.name;
if (!fieldOnRelatedObject) {
throw new Error(`Missing target field for ${fieldNameOnRecordObject}`);

4
packages/twenty-front/src/modules/object-record/hooks/useDetachRelatedRecordFromRecord.ts
View File

@ -25,10 +25,10 @@ export const useDetachRelatedRecordFromRecord = ({
});
const relatedRecordObjectNameSingular =
fieldOnObject?.relationDefinition?.targetObjectMetadata.nameSingular;
fieldOnObject?.relation?.targetObjectMetadata.nameSingular;
const fieldOnRelatedObject =
fieldOnObject?.relationDefinition?.targetFieldMetadata.name;
fieldOnObject?.relation?.targetFieldMetadata.name;
if (!relatedRecordObjectNameSingular) {
throw new Error(

7
packages/twenty-front/src/modules/object-record/record-field/hooks/__tests__/useToggleEditOnlyInput.test.tsx
View File

@ -40,6 +40,7 @@ const mocks: MockedResponse[] = [
firstName
lastName
}
position
timeFormat
timeZone
updatedAt
@ -76,6 +77,7 @@ const mocks: MockedResponse[] = [
opportunityId
personId
petId
rocketId
surveyResultId
taskId
type
@ -112,6 +114,7 @@ const mocks: MockedResponse[] = [
personId
petId
position
rocketId
surveyResultId
taskId
updatedAt
@ -124,7 +127,6 @@ const mocks: MockedResponse[] = [
}
id
idealCustomerProfile
internalCompetitions
introVideo {
primaryLinkUrl
primaryLinkLabel
@ -148,6 +150,7 @@ const mocks: MockedResponse[] = [
opportunityId
personId
petId
rocketId
surveyResultId
updatedAt
}
@ -248,6 +251,7 @@ const mocks: MockedResponse[] = [
opportunityId
personId
petId
rocketId
surveyResultId
taskId
updatedAt
@ -272,6 +276,7 @@ const mocks: MockedResponse[] = [
personId
petId
properties
rocketId
surveyResultId
taskId
updatedAt

4
packages/twenty-front/src/modules/object-record/record-field/meta-types/input/components/__stories__/RelationFromManyFieldInput.stories.tsx
View File

@ -22,7 +22,7 @@ import { RecordFieldComponentInstanceContext } from '@/object-record/record-fiel
import { MultipleRecordPickerHotkeyScope } from '@/object-record/record-picker/multiple-record-picker/types/MultipleRecordPickerHotkeyScope';
import { recordStoreFamilySelector } from '@/object-record/record-store/states/selectors/recordStoreFamilySelector';
import { FieldMetadataType } from 'twenty-shared/types';
import { RelationDefinitionType } from '~/generated-metadata/graphql';
import { RelationType } from '~/generated-metadata/graphql';
const RelationWorkspaceSetterEffect = () => {
const setCurrentWorkspace = useSetRecoilState(currentWorkspaceState);
@ -49,7 +49,7 @@ const RelationManyFieldInputWithContext = () => {
iconName: 'IconLink',
metadata: {
fieldName: 'people',
relationType: RelationDefinitionType.ONE_TO_MANY,
relationType: RelationType.ONE_TO_MANY,
relationObjectMetadataNamePlural: 'companies',
relationObjectMetadataNameSingular: CoreObjectNameSingular.Company,
objectMetadataNameSingular: 'company',

22
packages/twenty-front/src/modules/object-record/record-field/meta-types/input/hooks/useAddNewRecordAndOpenRightDrawer.ts
View File

@ -9,11 +9,8 @@ import { useCreateOneRecord } from '@/object-record/hooks/useCreateOneRecord';
import { useUpdateOneRecord } from '@/object-record/hooks/useUpdateOneRecord';
import { viewableRecordIdState } from '@/object-record/record-right-drawer/states/viewableRecordIdState';
import { viewableRecordNameSingularState } from '@/object-record/record-right-drawer/states/viewableRecordNameSingularState';
import {
FieldMetadataType,
RelationDefinitionType,
} from '~/generated-metadata/graphql';
import { isDefined } from 'twenty-shared/utils';
import { FieldMetadataType, RelationType } from '~/generated-metadata/graphql';
type RecordDetailRelationSectionProps = {
relationObjectMetadataNameSingular: string;
@ -38,8 +35,8 @@ export const useAddNewRecordAndOpenRightDrawer = ({
const { updateOneRecord } = useUpdateOneRecord({
objectNameSingular:
relationFieldMetadataItem?.relationDefinition?.targetObjectMetadata
.nameSingular ?? 'workspaceMember',
relationFieldMetadataItem?.relation?.targetObjectMetadata.nameSingular ??
'workspaceMember',
});
const { openRecordInCommandMenu } = useOpenRecordInCommandMenu();
@ -47,8 +44,7 @@ export const useAddNewRecordAndOpenRightDrawer = ({
if (
relationObjectMetadataNameSingular === 'workspaceMember' ||
!isDefined(
relationFieldMetadataItem?.relationDefinition?.targetObjectMetadata
.nameSingular,
relationFieldMetadataItem?.relation?.targetObjectMetadata.nameSingular,
)
) {
return {
@ -83,24 +79,22 @@ export const useAddNewRecordAndOpenRightDrawer = ({
: { id: newRecordId, name: searchInput ?? '' };
if (
relationFieldMetadataItem?.relationDefinition?.direction ===
RelationDefinitionType.MANY_TO_ONE
relationFieldMetadataItem?.relation?.type === RelationType.MANY_TO_ONE
) {
createRecordPayload[
`${relationFieldMetadataItem?.relationDefinition?.sourceFieldMetadata.name}Id`
`${relationFieldMetadataItem?.relation?.sourceFieldMetadata.name}Id`
] = recordId;
}
await createOneRecord(createRecordPayload);
if (
relationFieldMetadataItem?.relationDefinition?.direction ===
RelationDefinitionType.ONE_TO_MANY
relationFieldMetadataItem?.relation?.type === RelationType.ONE_TO_MANY
) {
await updateOneRecord({
idToUpdate: recordId,
updateOneRecordInput: {
[`${relationFieldMetadataItem?.relationDefinition?.targetFieldMetadata.name}Id`]:
[`${relationFieldMetadataItem?.relation?.targetFieldMetadata.name}Id`]:
newRecordId,
},
});

4
packages/twenty-front/src/modules/object-record/record-field/types/FieldMetadata.ts
View File

@ -4,7 +4,7 @@ import { ObjectRecord } from '@/object-record/types/ObjectRecord';
import { ConnectedAccountProvider } from 'twenty-shared/types';
import { ThemeColor } from 'twenty-ui/theme';
import { z } from 'zod';
import { RelationDefinitionType } from '~/generated-metadata/graphql';
import { RelationType } from '~/generated-metadata/graphql';
import { CurrencyCode } from './CurrencyCode';
type BaseFieldMetadata = {
@ -132,7 +132,7 @@ export type FieldRelationMetadata = BaseFieldMetadata & {
relationObjectMetadataNamePlural: string;
relationObjectMetadataNameSingular: string;
relationObjectMetadataId: string;
relationType?: RelationDefinitionType;
relationType?: RelationType;
targetFieldMetadataName?: string;
useEditButton?: boolean;
settings?: null;

4
packages/twenty-front/src/modules/object-record/record-field/types/guards/isFieldRelationFromManyObjects.ts
View File

@ -1,6 +1,6 @@
import { isFieldRelation } from '@/object-record/record-field/types/guards/isFieldRelation';
import { RelationDefinitionType } from '~/generated-metadata/graphql';
import { RelationType } from '~/generated-metadata/graphql';
import { FieldDefinition } from '../FieldDefinition';
import { FieldMetadata, FieldRelationMetadata } from '../FieldMetadata';
@ -8,4 +8,4 @@ export const isFieldRelationFromManyObjects = (
field: Pick<FieldDefinition<FieldMetadata>, 'type' | 'metadata'>,
): field is FieldDefinition<FieldRelationMetadata> =>
isFieldRelation(field) &&
field.metadata.relationType === RelationDefinitionType.ONE_TO_MANY;
field.metadata.relationType === RelationType.ONE_TO_MANY;

4
packages/twenty-front/src/modules/object-record/record-field/types/guards/isFieldRelationToOneObject.ts
View File

@ -1,6 +1,6 @@
import { isFieldRelation } from '@/object-record/record-field/types/guards/isFieldRelation';
import { RelationDefinitionType } from '~/generated-metadata/graphql';
import { RelationType } from '~/generated-metadata/graphql';
import { FieldDefinition } from '../FieldDefinition';
import { FieldMetadata, FieldRelationMetadata } from '../FieldMetadata';
@ -8,4 +8,4 @@ export const isFieldRelationToOneObject = (
field: Pick<FieldDefinition<FieldMetadata>, 'type' | 'metadata'>,
): field is FieldDefinition<FieldRelationMetadata> =>
isFieldRelation(field) &&
field.metadata.relationType === RelationDefinitionType.MANY_TO_ONE;
field.metadata.relationType === RelationType.MANY_TO_ONE;

24
packages/twenty-front/src/modules/object-record/record-filter/utils/__tests__/computeViewRecordGqlOperationFilter.test.ts
View File

@ -14,6 +14,10 @@ const companyMockObjectMetadataItem = generatedMockObjectMetadataItems.find(
(item) => item.nameSingular === 'company',
)!;
const petMockObjectMetadataItem = generatedMockObjectMetadataItems.find(
(item) => item.nameSingular === 'pet',
)!;
const personMockObjectMetadataItem = generatedMockObjectMetadataItems.find(
(item) => item.nameSingular === 'person',
)!;
@ -1364,21 +1368,21 @@ describe('should work as expected for the different field types', () => {
});
it('select field type with empty options', () => {
const selectFieldMetadata = companyMockObjectMetadataItem.fields.find(
const selectFieldMetadata = petMockObjectMetadataItem.fields.find(
(field) => field.type === FieldMetadataType.SELECT,
);
if (!selectFieldMetadata) {
throw new Error(
`Select field metadata not found ${companyMockObjectMetadataItem.fields.map((field) => [field.name, field.type])}`,
`Select field metadata not found ${petMockObjectMetadataItem.fields.map((field) => [field.name, field.type])}`,
);
}
const selectFilterIs: RecordFilter = {
id: 'company-select-filter-is',
value: '["option1",""]',
id: 'pet-select-filter-is',
value: '["DOG",""]',
fieldMetadataId: selectFieldMetadata?.id,
displayValue: '["option1",""]',
displayValue: '["Dog",""]',
operand: ViewFilterOperand.Is,
label: 'Select',
type: FieldMetadataType.SELECT,
@ -1386,9 +1390,9 @@ describe('should work as expected for the different field types', () => {
const selectFilterIsNot: RecordFilter = {
id: 'company-select-filter-is-not',
value: '["option1",""]',
value: '["DOG",""]',
fieldMetadataId: selectFieldMetadata.id,
displayValue: '["option1",""]',
displayValue: '["Dog",""]',
operand: ViewFilterOperand.IsNot,
label: 'Select',
type: FieldMetadataType.SELECT,
@ -1398,7 +1402,7 @@ describe('should work as expected for the different field types', () => {
filterValueDependencies: mockFilterValueDependencies,
recordFilters: [selectFilterIs, selectFilterIsNot],
recordFilterGroups: [],
fields: companyMockObjectMetadataItem.fields,
fields: petMockObjectMetadataItem.fields,
});
expect(result).toEqual({
@ -1407,7 +1411,7 @@ describe('should work as expected for the different field types', () => {
or: [
{
[selectFieldMetadata.name]: {
in: ['option1'],
in: ['DOG'],
},
},
{
@ -1422,7 +1426,7 @@ describe('should work as expected for the different field types', () => {
{
not: {
[selectFieldMetadata.name]: {
in: ['option1'],
in: ['DOG'],
},
},
},

62
packages/twenty-front/src/modules/object-record/record-index/export/hooks/__tests__/useExportFetchRecords.test.ts
View File

@ -17,52 +17,52 @@ import { generatedMockObjectMetadataItems } from '~/testing/mock-data/generatedM
const mockPerson = {
__typename: 'Person',
updatedAt: '2021-08-03T19:20:06.000Z',
whatsapp: {
primaryPhoneNumber: '+1',
primaryPhoneCountryCode: '234-567-890',
primaryPhoneCallingCode: '+33',
additionalPhones: [],
avatarUrl: 'avatarUrl',
city: 'city',
companyId: '1',
createdAt: '2021-08-03T19:20:06.000Z',
createdBy: {
name: 'name',
source: 'source',
workspaceMemberId: '1',
},
deletedAt: null,
emails: {
additionalEmails: [],
primaryEmail: 'email',
},
id: '123',
intro: 'intro',
jobTitle: 'jobTitle',
linkedinLink: {
primaryLinkUrl: 'https://www.linkedin.com',
primaryLinkLabel: 'linkedin',
primaryLinkUrl: 'https://www.linkedin.com',
secondaryLinks: ['https://www.linkedin.com'],
},
name: {
firstName: 'firstName',
lastName: 'lastName',
},
emails: {
primaryEmail: 'email',
additionalEmails: [],
performanceRating: 1,
phones: {
additionalPhones: [],
primaryPhoneCountryCode: '234-567-890',
primaryPhoneNumber: '+1',
},
position: 'position',
createdBy: {
source: 'source',
workspaceMemberId: '1',
name: 'name',
updatedAt: '2021-08-03T19:20:06.000Z',
whatsapp: {
additionalPhones: [],
primaryPhoneCallingCode: '+33',
primaryPhoneCountryCode: '234-567-890',
primaryPhoneNumber: '+1',
},
avatarUrl: 'avatarUrl',
jobTitle: 'jobTitle',
workPreference: 'workPreference',
xLink: {
primaryLinkUrl: 'https://www.linkedin.com',
primaryLinkLabel: 'linkedin',
primaryLinkUrl: 'https://www.linkedin.com',
secondaryLinks: ['https://www.linkedin.com'],
},
performanceRating: 1,
createdAt: '2021-08-03T19:20:06.000Z',
phones: {
primaryPhoneNumber: '+1',
primaryPhoneCountryCode: '234-567-890',
additionalPhones: [],
},
id: '123',
city: 'city',
companyId: '1',
intro: 'intro',
deletedAt: null,
workPreference: 'workPreference',
};
const Wrapper = getJestMetadataAndApolloMocksAndActionMenuWrapper({
@ -238,7 +238,7 @@ describe('useRecordData', () => {
displayFormat: 'RELATIVE',
},
},
position: 10,
position: 9,
showLabel: undefined,
size: 100,
type: 'DATE_TIME',

7
packages/twenty-front/src/modules/object-record/record-index/export/hooks/__tests__/useExportRecords.test.ts
View File

@ -1,10 +1,7 @@
import { FieldMetadata } from '@/object-record/record-field/types/FieldMetadata';
import { ColumnDefinition } from '@/object-record/record-table/types/ColumnDefinition';
import {
FieldMetadataType,
RelationDefinitionType,
} from '~/generated-metadata/graphql';
import { FieldMetadataType, RelationType } from '~/generated-metadata/graphql';
import { displayedExportProgress, generateCsv } from '../useExportRecords';
jest.useFakeTimers();
@ -23,7 +20,7 @@ describe('generateCsv', () => {
label: 'Relation',
metadata: {
fieldName: 'relation',
relationType: RelationDefinitionType.MANY_TO_ONE,
relationType: RelationType.MANY_TO_ONE,
},
},
] as ColumnDefinition<FieldMetadata>[];

4
packages/twenty-front/src/modules/object-record/record-index/export/hooks/useExportRecords.ts
View File

@ -15,7 +15,7 @@ import { COMPOSITE_FIELD_SUB_FIELD_LABELS } from '@/settings/data-model/constant
import { t } from '@lingui/core/macro';
import { saveAs } from 'file-saver';
import { isDefined } from 'twenty-shared/utils';
import { RelationDefinitionType } from '~/generated-metadata/graphql';
import { RelationType } from '~/generated-metadata/graphql';
import { FieldMetadataType } from '~/generated/graphql';
import { isUndefinedOrNull } from '~/utils/isUndefinedOrNull';
@ -39,7 +39,7 @@ export const generateCsv: GenerateExport = ({
const columnsToExport = columns.filter(
(col) =>
!('relationType' in col.metadata && col.metadata.relationType) ||
col.metadata.relationType === RelationDefinitionType.MANY_TO_ONE,
col.metadata.relationType === RelationType.MANY_TO_ONE,
);
const objectIdColumn: ColumnDefinition<FieldMetadata> = {

2
packages/twenty-front/src/modules/object-record/record-show/components/FieldsCard.tsx
View File

@ -96,7 +96,7 @@ export const FieldsCard = ({
) &&
getObjectPermissionsForObject(
objectPermissionsByObjectMetadataId,
fieldMetadataItem.relationDefinition?.targetObjectMetadata.id,
fieldMetadataItem.relation?.targetObjectMetadata.id,
).canReadObjectRecords,
);

4
packages/twenty-front/src/modules/object-record/record-show/record-detail-section/components/RecordDetailRelationRecordsListItem.tsx
View File

@ -47,7 +47,7 @@ import {
import { LightIconButton } from 'twenty-ui/input';
import { MenuItem } from 'twenty-ui/navigation';
import { AnimatedEaseInOut } from 'twenty-ui/utilities';
import { RelationDefinitionType } from '~/generated-metadata/graphql';
import { RelationType } from '~/generated-metadata/graphql';
const StyledListItem = styled(RecordDetailRecordsListItem)<{
isDropdownOpen?: boolean;
@ -113,7 +113,7 @@ export const RecordDetailRelationRecordsListItem = ({
relationType,
} = fieldDefinition.metadata as FieldRelationMetadata;
const isToOneObject = relationType === RelationDefinitionType.MANY_TO_ONE;
const isToOneObject = relationType === RelationType.MANY_TO_ONE;
const { objectMetadataItem: relationObjectMetadataItem } =
useObjectMetadataItem({
objectNameSingular: relationObjectMetadataNameSingular,

6
packages/twenty-front/src/modules/object-record/record-show/record-detail-section/components/RecordDetailRelationSection.tsx
View File

@ -21,7 +21,7 @@ import { useDropdown } from '@/ui/layout/dropdown/hooks/useDropdown';
import { useIsMobile } from '@/ui/utilities/responsive/hooks/useIsMobile';
import { ViewFilterOperand } from '@/views/types/ViewFilterOperand';
import { useLingui } from '@lingui/react/macro';
import { RelationDefinitionType } from '~/generated-metadata/graphql';
import { RelationType } from '~/generated-metadata/graphql';
import { getAppPath } from '~/utils/navigation/getAppPath';
type RecordDetailRelationSectionProps = {
@ -57,8 +57,8 @@ export const RecordDetailRelationSection = ({
>(recordStoreFamilySelector({ recordId, fieldName }));
// TODO: use new relation type
const isToOneObject = relationType === RelationDefinitionType.MANY_TO_ONE;
const isToManyObjects = relationType === RelationDefinitionType.ONE_TO_MANY;
const isToOneObject = relationType === RelationType.MANY_TO_ONE;
const isToManyObjects = relationType === RelationType.ONE_TO_MANY;
const relationRecords: ObjectRecord[] =
fieldValue && isToOneObject

6
packages/twenty-front/src/modules/object-record/record-show/record-detail-section/components/RecordDetailRelationSectionDropdown.tsx
View File

@ -28,7 +28,7 @@ import { DropdownScope } from '@/ui/layout/dropdown/scopes/DropdownScope';
import { useSetRecoilComponentStateV2 } from '@/ui/utilities/state/component-state/hooks/useSetRecoilComponentStateV2';
import { IconForbid, IconPencil, IconPlus } from 'twenty-ui/display';
import { LightIconButton } from 'twenty-ui/input';
import { RelationDefinitionType } from '~/generated-metadata/graphql';
import { RelationType } from '~/generated-metadata/graphql';
type RecordDetailRelationSectionDropdownProps = {
loading: boolean;
@ -61,8 +61,8 @@ export const RecordDetailRelationSectionDropdown = ({
>(recordStoreFamilySelector({ recordId, fieldName }));
// TODO: use new relation type
const isToOneObject = relationType === RelationDefinitionType.MANY_TO_ONE;
const isToManyObjects = relationType === RelationDefinitionType.ONE_TO_MANY;
const isToOneObject = relationType === RelationType.MANY_TO_ONE;
const isToManyObjects = relationType === RelationType.ONE_TO_MANY;
const relationRecords: ObjectRecord[] =
fieldValue && isToOneObject

58
packages/twenty-front/src/modules/object-record/record-table/components/__stories__/perf/mock.ts
View File

@ -36,8 +36,8 @@ export const mockPerformance = {
updatedAt: '2024-05-16T10:54:27.788Z',
defaultValue: null,
options: null,
relationDefinition: {
__typename: 'RelationDefinition',
relation: {
__typename: 'Relation',
relationId: '0cf72416-3d94-4d94-abf3-7dc9d734435b',
direction: 'MANY_TO_ONE',
sourceObjectMetadata: {
@ -80,7 +80,7 @@ export const mockPerformance = {
updatedAt: '2024-05-16T10:54:27.788Z',
defaultValue: "''",
options: null,
relationDefinition: null,
relation: null,
},
{
__typename: 'field',
@ -98,7 +98,7 @@ export const mockPerformance = {
updatedAt: '2024-05-16T10:54:27.788Z',
defaultValue: "''",
options: null,
relationDefinition: null,
relation: null,
},
{
__typename: 'field',
@ -116,8 +116,8 @@ export const mockPerformance = {
updatedAt: '2024-05-16T10:54:27.788Z',
defaultValue: null,
options: null,
relationDefinition: {
__typename: 'RelationDefinition',
relation: {
__typename: 'Relation',
relationId: 'd76f949d-023d-4b45-a71e-f39e3b1562ba',
direction: 'ONE_TO_MANY',
sourceObjectMetadata: {
@ -160,8 +160,8 @@ export const mockPerformance = {
updatedAt: '2024-05-16T10:54:27.788Z',
defaultValue: null,
options: null,
relationDefinition: {
__typename: 'RelationDefinition',
relation: {
__typename: 'Relation',
relationId: 'a5a61d23-8ac9-4014-9441-ec3a1781a661',
direction: 'ONE_TO_MANY',
sourceObjectMetadata: {
@ -204,8 +204,8 @@ export const mockPerformance = {
updatedAt: '2024-05-16T10:54:27.788Z',
defaultValue: null,
options: null,
relationDefinition: {
__typename: 'RelationDefinition',
relation: {
__typename: 'Relation',
relationId: '456f7875-b48c-4795-a0c7-a69d7339afee',
direction: 'ONE_TO_MANY',
sourceObjectMetadata: {
@ -248,7 +248,7 @@ export const mockPerformance = {
updatedAt: '2024-05-16T10:54:27.788Z',
defaultValue: 'now',
options: null,
relationDefinition: null,
relation: null,
},
{
__typename: 'field',
@ -266,8 +266,8 @@ export const mockPerformance = {
updatedAt: '2024-05-16T10:54:27.788Z',
defaultValue: null,
options: null,
relationDefinition: {
__typename: 'RelationDefinition',
relation: {
__typename: 'Relation',
relationId: '31542774-fb15-4d01-b00b-8fc94887f458',
direction: 'ONE_TO_MANY',
sourceObjectMetadata: {
@ -313,7 +313,7 @@ export const mockPerformance = {
primaryLinkLabel: "''",
},
options: null,
relationDefinition: null,
relation: null,
},
{
__typename: 'field',
@ -331,8 +331,8 @@ export const mockPerformance = {
updatedAt: '2024-05-16T10:54:27.788Z',
defaultValue: null,
options: null,
relationDefinition: {
__typename: 'RelationDefinition',
relation: {
__typename: 'Relation',
relationId: 'c0cc3456-afa4-46e0-820d-2db0b63a8273',
direction: 'ONE_TO_MANY',
sourceObjectMetadata: {
@ -375,7 +375,7 @@ export const mockPerformance = {
updatedAt: '2024-05-16T10:54:27.788Z',
defaultValue: "''",
options: null,
relationDefinition: null,
relation: null,
},
{
__typename: 'field',
@ -393,7 +393,7 @@ export const mockPerformance = {
updatedAt: '2024-05-16T10:54:27.788Z',
defaultValue: null,
options: null,
relationDefinition: null,
relation: null,
},
{
__typename: 'field',
@ -411,7 +411,7 @@ export const mockPerformance = {
updatedAt: '2024-05-16T10:54:27.788Z',
defaultValue: "''",
options: null,
relationDefinition: null,
relation: null,
},
{
__typename: 'field',
@ -429,7 +429,7 @@ export const mockPerformance = {
updatedAt: '2024-05-16T10:54:27.788Z',
defaultValue: "''",
options: null,
relationDefinition: null,
relation: null,
},
{
__typename: 'field',
@ -447,7 +447,7 @@ export const mockPerformance = {
updatedAt: '2024-05-16T10:54:27.788Z',
defaultValue: 'now',
options: null,
relationDefinition: null,
relation: null,
},
{
__typename: 'field',
@ -465,7 +465,7 @@ export const mockPerformance = {
updatedAt: '2024-05-16T10:54:27.788Z',
defaultValue: null,
options: null,
relationDefinition: null,
relation: null,
},
{
__typename: 'field',
@ -483,8 +483,8 @@ export const mockPerformance = {
updatedAt: '2024-05-16T10:54:27.788Z',
defaultValue: null,
options: null,
relationDefinition: {
__typename: 'RelationDefinition',
relation: {
__typename: 'Relation',
relationId: '25150feb-fcd7-407e-b5fa-ffe58a0450ac',
direction: 'ONE_TO_MANY',
sourceObjectMetadata: {
@ -530,7 +530,7 @@ export const mockPerformance = {
firstName: "''",
},
options: null,
relationDefinition: null,
relation: null,
},
{
__typename: 'field',
@ -551,7 +551,7 @@ export const mockPerformance = {
primaryLinkLabel: "''",
},
options: null,
relationDefinition: null,
relation: null,
},
{
__typename: 'field',
@ -569,8 +569,8 @@ export const mockPerformance = {
updatedAt: '2024-05-16T10:54:27.788Z',
defaultValue: null,
options: null,
relationDefinition: {
__typename: 'RelationDefinition',
relation: {
__typename: 'Relation',
relationId: 'e2eb7156-6e65-4bf8-922b-670179744f27',
direction: 'ONE_TO_MANY',
sourceObjectMetadata: {
@ -613,7 +613,7 @@ export const mockPerformance = {
updatedAt: '2024-05-16T10:54:27.788Z',
defaultValue: 'uuid',
options: null,
relationDefinition: null,
relation: null,
},
],
},

2
packages/twenty-front/src/modules/object-record/record-table/hooks/useBuildRecordInputFromFilters.ts
View File

@ -35,7 +35,7 @@ export const useBuildRecordInputFromFilters = ({
const value = buildValueFromFilter({
filter,
options: fieldMetadataItem.options ?? undefined,
relationType: fieldMetadataItem.relationDefinition?.direction,
relationType: fieldMetadataItem.relation?.type,
currentWorkspaceMember: currentWorkspaceMember ?? undefined,
label: filter.label,
});

12
packages/twenty-front/src/modules/object-record/record-table/utils/buildRecordInputFromFilter.spec.ts
View File

@ -3,7 +3,7 @@ import { FilterableFieldType } from '@/object-record/record-filter/types/Filtera
import { RecordFilter } from '@/object-record/record-filter/types/RecordFilter';
import { ViewFilterOperand } from '@/views/types/ViewFilterOperand';
import { ColorScheme } from '@/workspace-member/types/WorkspaceMember';
import { RelationDefinitionType } from '~/generated-metadata/graphql';
import { RelationType } from '~/generated-metadata/graphql';
import { buildValueFromFilter } from './buildRecordInputFromFilter';
// TODO: fix the dates, and test the not supported types
@ -238,7 +238,7 @@ describe('buildValueFromFilter', () => {
isCurrentWorkspaceMemberSelected: false,
selectedRecordIds: ['record-1'],
}),
relationType: RelationDefinitionType.MANY_TO_ONE,
relationType: RelationType.MANY_TO_ONE,
label: 'belongs to one',
expected: 'record-1',
},
@ -248,7 +248,7 @@ describe('buildValueFromFilter', () => {
isCurrentWorkspaceMemberSelected: true,
selectedRecordIds: ['record-1'],
}),
relationType: RelationDefinitionType.MANY_TO_ONE,
relationType: RelationType.MANY_TO_ONE,
label: 'Assignee',
expected: 'current-workspace-member-id',
},
@ -258,7 +258,7 @@ describe('buildValueFromFilter', () => {
isCurrentWorkspaceMemberSelected: false,
selectedRecordIds: ['record-1', 'record-2'],
}),
relationType: RelationDefinitionType.MANY_TO_MANY,
relationType: RelationType.ONE_TO_MANY,
label: 'hasmany',
expected: undefined,
},
@ -268,7 +268,7 @@ describe('buildValueFromFilter', () => {
isCurrentWorkspaceMemberSelected: false,
selectedRecordIds: ['record-1'],
}),
relationType: RelationDefinitionType.MANY_TO_ONE,
relationType: RelationType.MANY_TO_ONE,
label: 'Assignee',
expected: undefined,
},
@ -278,7 +278,7 @@ describe('buildValueFromFilter', () => {
isCurrentWorkspaceMemberSelected: false,
selectedRecordIds: ['record-1'],
}),
relationType: RelationDefinitionType.MANY_TO_ONE,
relationType: RelationType.MANY_TO_ONE,
label: 'Assignee',
expected: undefined,
},

11
packages/twenty-front/src/modules/object-record/record-table/utils/buildRecordInputFromFilter.ts
View File

@ -9,7 +9,7 @@ import {
import { FILTER_OPERANDS_MAP } from '@/object-record/record-filter/utils/getRecordFilterOperands';
import { ViewFilterOperand } from '@/views/types/ViewFilterOperand';
import { assertUnreachable, parseJson } from 'twenty-shared/utils';
import { RelationDefinitionType } from '~/generated-metadata/graphql';
import { RelationType } from '~/generated-metadata/graphql';
export const buildValueFromFilter = ({
filter,
@ -20,7 +20,7 @@ export const buildValueFromFilter = ({
}: {
filter: RecordFilter;
options?: FieldMetadataItemOption[];
relationType?: RelationDefinitionType;
relationType?: RelationType;
currentWorkspaceMember?: CurrentWorkspaceMember;
label?: string;
}) => {
@ -269,7 +269,7 @@ const computeValueFromFilterMultiSelect = (
const computeValueFromFilterRelation = (
operand: RecordFilterToRecordInputOperand<'RELATION'>,
value: string,
relationType?: RelationDefinitionType,
relationType?: RelationType,
currentWorkspaceMember?: CurrentWorkspaceMember,
label?: string,
) => {
@ -279,10 +279,7 @@ const computeValueFromFilterRelation = (
isCurrentWorkspaceMemberSelected: boolean;
selectedRecordIds: string[];
}>(value);
if (
relationType === RelationDefinitionType.MANY_TO_ONE ||
relationType === RelationDefinitionType.ONE_TO_ONE
) {
if (relationType === RelationType.MANY_TO_ONE) {
if (label === 'Assignee') {
return parsedValue?.isCurrentWorkspaceMemberSelected
? currentWorkspaceMember?.id

7
packages/twenty-front/src/modules/object-record/spreadsheet-import/hooks/__tests__/useOpenObjectRecordsSpreadsheetImportDialog.test.ts
View File

@ -40,6 +40,7 @@ const companyMocks = [
firstName
lastName
}
position
timeFormat
timeZone
updatedAt
@ -76,6 +77,7 @@ const companyMocks = [
opportunityId
personId
petId
rocketId
surveyResultId
taskId
type
@ -112,6 +114,7 @@ const companyMocks = [
personId
petId
position
rocketId
surveyResultId
taskId
updatedAt
@ -124,7 +127,6 @@ const companyMocks = [
}
id
idealCustomerProfile
internalCompetitions
introVideo {
primaryLinkUrl
primaryLinkLabel
@ -148,6 +150,7 @@ const companyMocks = [
opportunityId
personId
petId
rocketId
surveyResultId
updatedAt
}
@ -248,6 +251,7 @@ const companyMocks = [
opportunityId
personId
petId
rocketId
surveyResultId
taskId
updatedAt
@ -272,6 +276,7 @@ const companyMocks = [
personId
petId
properties
rocketId
surveyResultId
taskId
updatedAt

8
packages/twenty-front/src/modules/object-record/spreadsheet-import/hooks/useOpenObjectRecordsSpreadsheetImportDialog.ts
View File

@ -6,10 +6,7 @@ import { useOpenSpreadsheetImportDialog } from '@/spreadsheet-import/hooks/useOp
import { SpreadsheetImportDialogOptions } from '@/spreadsheet-import/types';
import { SnackBarVariant } from '@/ui/feedback/snack-bar-manager/components/SnackBar';
import { useSnackBar } from '@/ui/feedback/snack-bar-manager/hooks/useSnackBar';
import {
FieldMetadataType,
RelationDefinitionType,
} from '~/generated-metadata/graphql';
import { FieldMetadataType, RelationType } from '~/generated-metadata/graphql';
export const useOpenObjectRecordsSpreadsheetImportDialog = (
objectNameSingular: string,
@ -41,8 +38,7 @@ export const useOpenObjectRecordsSpreadsheetImportDialog = (
fieldMetadataItem.name !== 'createdAt' &&
fieldMetadataItem.name !== 'updatedAt' &&
(fieldMetadataItem.type !== FieldMetadataType.RELATION ||
fieldMetadataItem.relationDefinition?.direction ===
RelationDefinitionType.MANY_TO_ONE),
fieldMetadataItem.relation?.type === RelationType.MANY_TO_ONE),
)
.sort((fieldMetadataItemA, fieldMetadataItemB) =>
fieldMetadataItemA.name.localeCompare(fieldMetadataItemB.name),

18
packages/twenty-front/src/modules/object-record/utils/computeOptimisticRecordFromInput.ts
View File

@ -15,7 +15,7 @@ import { ObjectRecord } from '@/object-record/types/ObjectRecord';
import { buildOptimisticActorFieldValueFromCurrentWorkspaceMember } from '@/object-record/utils/buildOptimisticActorFieldValueFromCurrentWorkspaceMember';
import { getForeignKeyNameFromRelationFieldName } from '@/object-record/utils/getForeignKeyNameFromRelationFieldName';
import { isDefined } from 'twenty-shared/utils';
import { RelationDefinitionType } from '~/generated-metadata/graphql';
import { RelationType } from '~/generated-metadata/graphql';
import { FieldMetadataType } from '~/generated/graphql';
type ComputeOptimisticCacheRecordInputArgs = {
@ -67,16 +67,16 @@ export const computeOptimisticRecordFromInput = ({
if (isFieldUuid(fieldMetadataItem)) {
const isRelationFieldId = objectMetadataItem.fields.some(
({ type, relationDefinition }) => {
({ type, relation }) => {
if (type !== FieldMetadataType.RELATION) {
return false;
}
if (!isDefined(relationDefinition)) {
if (!isDefined(relation)) {
return false;
}
const sourceFieldName = relationDefinition.sourceFieldMetadata.name;
const sourceFieldName = relation.sourceFieldMetadata.name;
return (
getForeignKeyNameFromRelationFieldName(sourceFieldName) ===
fieldMetadataItem.name
@ -115,16 +115,12 @@ export const computeOptimisticRecordFromInput = ({
continue;
}
if (
fieldMetadataItem.relationDefinition?.direction ===
RelationDefinitionType.ONE_TO_MANY
) {
if (fieldMetadataItem.relation?.type === RelationType.ONE_TO_MANY) {
continue;
}
const isManyToOneRelation =
fieldMetadataItem.relationDefinition?.direction ===
RelationDefinitionType.MANY_TO_ONE;
fieldMetadataItem.relation?.type === RelationType.MANY_TO_ONE;
if (!isManyToOneRelation) {
continue;
}
@ -166,7 +162,7 @@ export const computeOptimisticRecordFromInput = ({
}
const targetNameSingular =
fieldMetadataItem.relationDefinition?.targetObjectMetadata.nameSingular;
fieldMetadataItem.relation?.targetObjectMetadata.nameSingular;
const targetObjectMetataDataItem = objectMetadataItems.find(
({ nameSingular }) => nameSingular === targetNameSingular,
);

10
packages/twenty-front/src/modules/object-record/utils/filterAvailableTableColumns.ts
View File

@ -1,20 +1,10 @@
import { TABLE_COLUMNS_DENY_LIST } from '@/object-record/constants/TableColumnsDenyList';
import { FieldMetadata } from '@/object-record/record-field/types/FieldMetadata';
import { isFieldRelation } from '@/object-record/record-field/types/guards/isFieldRelation';
import { ColumnDefinition } from '@/object-record/record-table/types/ColumnDefinition';
import { RelationDefinitionType } from '~/generated-metadata/graphql';
export const filterAvailableTableColumns = (
columnDefinition: ColumnDefinition<FieldMetadata>,
): boolean => {
if (
isFieldRelation(columnDefinition) &&
columnDefinition.metadata?.relationType ===
RelationDefinitionType.MANY_TO_MANY
) {
return false;
}
if (TABLE_COLUMNS_DENY_LIST.includes(columnDefinition.metadata.fieldName)) {
return false;
}

12
packages/twenty-front/src/modules/object-record/utils/generateEmptyFieldValue.ts
View File

@ -1,13 +1,10 @@
import { FieldMetadataItem } from '@/object-metadata/types/FieldMetadataItem';
import { FieldActorValue } from '@/object-record/record-field/types/FieldMetadata';
import { assertUnreachable } from '@/workflow/utils/assertUnreachable';
import {
FieldMetadataType,
RelationDefinitionType,
} from '~/generated-metadata/graphql';
import { FieldMetadataType, RelationType } from '~/generated-metadata/graphql';
export type GenerateEmptyFieldValueArgs = {
fieldMetadataItem: Pick<FieldMetadataItem, 'type' | 'relationDefinition'>;
fieldMetadataItem: Pick<FieldMetadataItem, 'type' | 'relation'>;
};
// TODO strictly type each fieldValue following their FieldMetadataType
export const generateEmptyFieldValue = ({
@ -60,10 +57,7 @@ export const generateEmptyFieldValue = ({
return true;
}
case FieldMetadataType.RELATION: {
if (
fieldMetadataItem.relationDefinition?.direction ===
RelationDefinitionType.MANY_TO_ONE
) {
if (fieldMetadataItem.relation?.type === RelationType.MANY_TO_ONE) {
return null;
}

4
packages/twenty-front/src/modules/object-record/utils/getRecordChipGenerators.ts
View File

@ -48,8 +48,8 @@ export const getRecordChipGenerators = (
const currentObjectNameSingular = objectMetadataItem.nameSingular;
const fieldObjectNameSingular =
fieldMetadataItem.relationDefinition?.targetObjectMetadata
.nameSingular ?? undefined;
fieldMetadataItem.relation?.targetObjectMetadata.nameSingular ??
undefined;
const objectNameSingularToFind = isLabelIdentifier
? currentObjectNameSingular

28
packages/twenty-front/src/modules/object-record/utils/isFieldCellSupported.ts
View File

@ -2,10 +2,7 @@ import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSi
import { FieldMetadataItem } from '@/object-metadata/types/FieldMetadataItem';
import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem';
import { isObjectMetadataAvailableForRelation } from '@/object-metadata/utils/isObjectMetadataAvailableForRelation';
import {
FieldMetadataType,
RelationDefinitionType,
} from '~/generated-metadata/graphql';
import { FieldMetadataType } from '~/generated-metadata/graphql';
export const isFieldCellSupported = (
fieldMetadataItem: FieldMetadataItem,
@ -23,7 +20,7 @@ export const isFieldCellSupported = (
if (fieldMetadataItem.type === FieldMetadataType.RELATION) {
const relationObjectMetadataItemId =
fieldMetadataItem.relationDefinition?.targetObjectMetadata.id;
fieldMetadataItem.relation?.targetObjectMetadata.id;
const relationObjectMetadataItem = objectMetadataItems.find(
(item) => item.id === relationObjectMetadataItemId,
@ -31,28 +28,25 @@ export const isFieldCellSupported = (
// Hack to display targets on Notes and Tasks
if (
fieldMetadataItem.relationDefinition?.targetObjectMetadata
?.nameSingular === CoreObjectNameSingular.NoteTarget &&
fieldMetadataItem.relationDefinition?.sourceObjectMetadata
.nameSingular === CoreObjectNameSingular.Note
fieldMetadataItem.relation?.targetObjectMetadata?.nameSingular ===
CoreObjectNameSingular.NoteTarget &&
fieldMetadataItem.relation?.sourceObjectMetadata.nameSingular ===
CoreObjectNameSingular.Note
) {
return true;
}
if (
fieldMetadataItem.relationDefinition?.targetObjectMetadata
?.nameSingular === CoreObjectNameSingular.TaskTarget &&
fieldMetadataItem.relationDefinition?.sourceObjectMetadata
.nameSingular === CoreObjectNameSingular.Task
fieldMetadataItem.relation?.targetObjectMetadata?.nameSingular ===
CoreObjectNameSingular.TaskTarget &&
fieldMetadataItem.relation?.sourceObjectMetadata.nameSingular ===
CoreObjectNameSingular.Task
) {
return true;
}
if (
!fieldMetadataItem.relationDefinition ||
// TODO: Many to many relations are not supported yet.
fieldMetadataItem.relationDefinition.direction ===
RelationDefinitionType.MANY_TO_MANY ||
!fieldMetadataItem.relation ||
!relationObjectMetadataItem ||
!isObjectMetadataAvailableForRelation(relationObjectMetadataItem)
) {

27
packages/twenty-front/src/modules/object-record/utils/prefillRecord.ts
View File

@ -5,7 +5,7 @@ import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem';
import { ObjectRecord } from '@/object-record/types/ObjectRecord';
import { generateEmptyFieldValue } from '@/object-record/utils/generateEmptyFieldValue';
import { isDefined } from 'twenty-shared/utils';
import { FieldMetadataType, RelationDefinitionType } from '~/generated/graphql';
import { FieldMetadataType, RelationType } from '~/generated/graphql';
type PrefillRecordArgs = {
objectMetadataItem: ObjectMetadataItem;
@ -19,19 +19,26 @@ export const prefillRecord = <T extends ObjectRecord>({
objectMetadataItem.fields
.map((fieldMetadataItem) => {
const inputValue = input[fieldMetadataItem.name];
if (
fieldMetadataItem.type === FieldMetadataType.RELATION &&
fieldMetadataItem.relationDefinition?.direction ===
RelationDefinitionType.MANY_TO_ONE
) {
throwIfInputRelationDataIsInconsistent(input, fieldMetadataItem);
}
const fieldValue = isUndefined(inputValue)
? generateEmptyFieldValue({ fieldMetadataItem })
: inputValue;
return [fieldMetadataItem.name, fieldValue];
if (
fieldMetadataItem.type === FieldMetadataType.RELATION &&
fieldMetadataItem.relation?.type === RelationType.MANY_TO_ONE
) {
const joinColumnValue =
input[fieldMetadataItem.settings?.joinColumnName];
throwIfInputRelationDataIsInconsistent(input, fieldMetadataItem);
return [
[fieldMetadataItem.name, fieldValue],
[fieldMetadataItem.settings?.joinColumnName, joinColumnValue],
];
}
return [[fieldMetadataItem.name, fieldValue]];
})
.flat()
.filter(isDefined),
) as T;
};

8
packages/twenty-front/src/modules/object-record/utils/sanitizeRecordInput.ts
View File

@ -2,7 +2,7 @@ import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem';
import { ObjectRecord } from '@/object-record/types/ObjectRecord';
import { isSystemSearchVectorField } from '@/object-record/utils/isSystemSearchVectorField';
import { isDefined } from 'twenty-shared/utils';
import { RelationDefinitionType } from '~/generated-metadata/graphql';
import { RelationType } from '~/generated-metadata/graphql';
import { FieldMetadataType } from '~/generated/graphql';
export const sanitizeRecordInput = ({
@ -43,8 +43,7 @@ export const sanitizeRecordInput = ({
if (
isDefined(fieldMetadataItem) &&
fieldMetadataItem.type === FieldMetadataType.RELATION &&
fieldMetadataItem.relationDefinition?.direction ===
RelationDefinitionType.MANY_TO_ONE
fieldMetadataItem.relation?.type === RelationType.MANY_TO_ONE
) {
const relationIdFieldName = `${fieldMetadataItem.name}Id`;
const relationIdFieldMetadataItem = objectMetadataItem.fields.find(
@ -61,8 +60,7 @@ export const sanitizeRecordInput = ({
if (
isDefined(fieldMetadataItem) &&
fieldMetadataItem.type === FieldMetadataType.RELATION &&
fieldMetadataItem.relationDefinition?.direction ===
RelationDefinitionType.ONE_TO_MANY
fieldMetadataItem.relation?.type === RelationType.ONE_TO_MANY
) {
return undefined;
}