admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Deprecate old relations completely (#12482)

Browse Source 
# What

Fully deprecate old relations because we have one bug tied to it and it
make the codebase complex

# How I've made this PR:
1. remove metadata datasource (we only keep 'core') => this was causing
extra complexity in the refactor + flaky reset
2. merge dev and demo datasets => as I needed to update the tests which
is very painful, I don't want to do it twice
3. remove all code tied to RELATION_METADATA /
relation-metadata.resolver, or anything tied to the old relation system
4. Remove ONE_TO_ONE and MANY_TO_MANY that are not supported
5. fix impacts on the different areas : see functional testing below 

# Functional testing

## Functional testing from the front-end:
1. Database Reset ✅
2. Sign In ✅
3. Workspace sign-up ✅
5. Browsing table / kanban / show ✅
6. Assigning a record in a one to many / in a many to one ✅
7. Deleting a record involved in a relation ✅ => broken but not tied to
this PR
8. "Add new" from relation picker ✅ => broken but not tied to this PR
9. Creating a Task / Note, Updating a Task / Note relations, Deleting a
Task / Note (from table, show page, right drawer) ✅ => broken but not
tied to this PR
10. creating a relation from settings (custom / standard x oneToMany /
manyToOne) ✅
11. updating a relation from settings should not be possible ✅
12. deleting a relation from settings (custom / standard x oneToMany /
manyToOne) ✅
13. Make sure timeline activity still work (relation were involved
there), espacially with Task / Note => to be double checked ✅ => Cannot
convert undefined or null to object
14. Workspace deletion / User deletion ✅ 
15. CSV Import should keep working ✅ 
16. Permissions: I have tested without permissions V2 as it's still hard
to test v2 work and it's not in prod yet ✅
17. Workflows global test ✅ 

## From the API:
1. Review open-api documentation (REST) ✅ 
2. Make sure REST Api are still able to fetch relations ==> won't do, we
have a coupling Get/Update/Create there, this requires refactoring
3. Make sure REST Api is still able to update / remove relation => won't
do same

## Automated tests
1. lint + typescript ✅
2. front unit tests: ✅
3. server unit tests 2 ✅
4. front stories: ✅
5. server integration: ✅
6. chromatic check : expected 0
7. e2e check : expected no more that current failures

## Remove // Todos
1. All are captured by functional tests above, nothing additional to do

## (Un)related regressions
1. Table loading state is not working anymore, we see the empty state
before table content
2. Filtering by Creator Tim Ap return empty results
3. Not possible to add Tasks / Notes / Files from show page

# Result

## New seeds that can be easily extended
<img width="1920" alt="image"
src="https://github.com/user-attachments/assets/d290d130-2a5f-44e6-b419-7e42a89eec4b"
/>

## -5k lines of code
## No more 'metadata' dataSource (we only have 'core)
## No more relationMetadata (I haven't drop the table yet it's not
referenced in the code anymore)
## We are ready to fix the 6 months lag between current API results and
our mocked tests
## No more bug on relation creation / deletion

---------

Co-authored-by: Weiko <corentin@twenty.com>
Co-authored-by: Félix Malfait <felix@twenty.com>
This commit is contained in:
Charles Bochet
2025-06-10 16:45:27 +02:00
committed by GitHub
parent 264861e020
commit a68895189c
426 changed files with 48870 additions and 54125 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/twenty-server/test/integration/graphql/suites/object-generated/__snapshots__/calendar-events.integration-spec.ts.snap
View File

@ -6,7 +6,7 @@ exports[`calendarEventsResolver (e2e) should find many calendarEvents 1`] = `
"deletedAt": null,
"description": "Discuss project progress",
"endsAt": Any<String>,
"id": "86083141-1c0e-494c-a1b6-85b1c6fefaa5",
"id": "20202020-1c0e-494c-a1b6-85b1c6fefaa5",
"startsAt": Any<String>,
"title": "Meeting with Christoph",
"updatedAt": Any<String>,
@ -19,7 +19,7 @@ exports[`calendarEventsResolver (e2e) should find one calendarEvent 1`] = `
"deletedAt": null,
"description": "Discuss project progress",
"endsAt": Any<String>,
"id": "86083141-1c0e-494c-a1b6-85b1c6fefaa5",
"id": "20202020-1c0e-494c-a1b6-85b1c6fefaa5",
"startsAt": Any<String>,
"title": "Meeting with Christoph",
"updatedAt": Any<String>,

4
packages/twenty-server/test/integration/graphql/suites/object-generated/calendar-events.integration-spec.ts
View File

@ -3,7 +3,7 @@ import { findManyOperationFactory } from 'test/integration/graphql/utils/find-ma
import { findOneOperationFactory } from 'test/integration/graphql/utils/find-one-operation-factory.util';
import { makeGraphqlAPIRequest } from 'test/integration/graphql/utils/make-graphql-api-request.util';
import { DEV_SEED_CALENDAR_EVENT_IDS } from 'src/database/typeorm-seeds/workspace/calendar-events';
import { CALENDAR_EVENT_DATA_SEED_IDS } from 'src/engine/workspace-manager/dev-seeder/data/constants/calendar-event-data-seeds.constant';
describe('calendarEventsResolver (e2e)', () => {
it('should find many calendarEvents', async () => {
@ -37,7 +37,7 @@ describe('calendarEventsResolver (e2e)', () => {
it('should find one calendarEvent', async () => {
const graphqlOperation = findOneOperationFactory({
objectMetadataSingularName: 'calendarEvent',
filter: { id: { eq: DEV_SEED_CALENDAR_EVENT_IDS.CALENDAR_EVENT_1 } },
filter: { id: { eq: CALENDAR_EVENT_DATA_SEED_IDS.ID_1 } },
gqlFields: CALENDAR_EVENT_GQL_FIELDS,
});

4
packages/twenty-server/test/integration/graphql/suites/object-generated/messages.integration-spec.ts
View File

@ -3,7 +3,7 @@ import { findManyOperationFactory } from 'test/integration/graphql/utils/find-ma
import { findOneOperationFactory } from 'test/integration/graphql/utils/find-one-operation-factory.util';
import { makeGraphqlAPIRequest } from 'test/integration/graphql/utils/make-graphql-api-request.util';
import { DEV_SEED_MESSAGE_IDS } from 'src/database/typeorm-seeds/workspace/messages';
import { MESSAGE_DATA_SEED_IDS } from 'src/engine/workspace-manager/dev-seeder/data/constants/message-data-seeds.constant';
describe('messagesResolver (e2e)', () => {
it('should find many messages', async () => {
@ -35,7 +35,7 @@ describe('messagesResolver (e2e)', () => {
it('should find one message', async () => {
const graphqlOperation = findOneOperationFactory({
objectMetadataSingularName: 'message',
filter: { id: { eq: DEV_SEED_MESSAGE_IDS.MESSAGE_1 } },
filter: { id: { eq: MESSAGE_DATA_SEED_IDS.ID_1 } },
gqlFields: MESSAGE_GQL_FIELDS,
});

2
packages/twenty-server/test/integration/graphql/suites/object-records-permissions/create-one-object-records-permissions.integration-spec.ts
View File

@ -7,9 +7,9 @@ import { makeGraphqlAPIRequestWithGuestRole } from 'test/integration/graphql/uti
import { makeGraphqlAPIRequest } from 'test/integration/graphql/utils/make-graphql-api-request.util';
import { updateFeatureFlagFactory } from 'test/integration/graphql/utils/update-feature-flag-factory.util';
import { SEED_APPLE_WORKSPACE_ID } from 'src/database/typeorm-seeds/core/workspaces';
import { ErrorCode } from 'src/engine/core-modules/graphql/utils/graphql-errors.util';
import { PermissionsExceptionMessage } from 'src/engine/metadata-modules/permissions/permissions.exception';
import { SEED_APPLE_WORKSPACE_ID } from 'src/engine/workspace-manager/dev-seeder/core/utils/seed-workspaces.util';
describe('createOneObjectRecordsPermissions', () => {
describe('permissions V2 disabled', () => {

2
packages/twenty-server/test/integration/graphql/suites/object-records-permissions/delete-many-object-records-permissions.integration-spec.ts
View File

@ -8,9 +8,9 @@ import { makeGraphqlAPIRequestWithGuestRole } from 'test/integration/graphql/uti
import { makeGraphqlAPIRequest } from 'test/integration/graphql/utils/make-graphql-api-request.util';
import { updateFeatureFlagFactory } from 'test/integration/graphql/utils/update-feature-flag-factory.util';
import { SEED_APPLE_WORKSPACE_ID } from 'src/database/typeorm-seeds/core/workspaces';
import { ErrorCode } from 'src/engine/core-modules/graphql/utils/graphql-errors.util';
import { PermissionsExceptionMessage } from 'src/engine/metadata-modules/permissions/permissions.exception';
import { SEED_APPLE_WORKSPACE_ID } from 'src/engine/workspace-manager/dev-seeder/core/utils/seed-workspaces.util';
describe('deleteManyObjectRecordsPermissions', () => {
describe('permissions V2 disabled', () => {

2
packages/twenty-server/test/integration/graphql/suites/object-records-permissions/delete-one-object-records-permissions.integration-spec.ts
View File

@ -8,9 +8,9 @@ import { makeGraphqlAPIRequestWithGuestRole } from 'test/integration/graphql/uti
import { makeGraphqlAPIRequest } from 'test/integration/graphql/utils/make-graphql-api-request.util';
import { updateFeatureFlagFactory } from 'test/integration/graphql/utils/update-feature-flag-factory.util';
import { SEED_APPLE_WORKSPACE_ID } from 'src/database/typeorm-seeds/core/workspaces';
import { ErrorCode } from 'src/engine/core-modules/graphql/utils/graphql-errors.util';
import { PermissionsExceptionMessage } from 'src/engine/metadata-modules/permissions/permissions.exception';
import { SEED_APPLE_WORKSPACE_ID } from 'src/engine/workspace-manager/dev-seeder/core/utils/seed-workspaces.util';
describe('deleteOneObjectRecordsPermissions', () => {
describe('permissions V2 disabled', () => {

2
packages/twenty-server/test/integration/graphql/suites/object-records-permissions/destroy-many-object-records-permissions.integration-spec.ts
View File

@ -7,9 +7,9 @@ import { makeGraphqlAPIRequestWithGuestRole } from 'test/integration/graphql/uti
import { makeGraphqlAPIRequest } from 'test/integration/graphql/utils/make-graphql-api-request.util';
import { updateFeatureFlagFactory } from 'test/integration/graphql/utils/update-feature-flag-factory.util';
import { SEED_APPLE_WORKSPACE_ID } from 'src/database/typeorm-seeds/core/workspaces';
import { ErrorCode } from 'src/engine/core-modules/graphql/utils/graphql-errors.util';
import { PermissionsExceptionMessage } from 'src/engine/metadata-modules/permissions/permissions.exception';
import { SEED_APPLE_WORKSPACE_ID } from 'src/engine/workspace-manager/dev-seeder/core/utils/seed-workspaces.util';
describe('destroyManyObjectRecordsPermissions', () => {
describe('permissions V2 disabled', () => {

2
packages/twenty-server/test/integration/graphql/suites/object-records-permissions/destroy-one-object-records-permissions.integration-spec.ts
View File

@ -7,9 +7,9 @@ import { makeGraphqlAPIRequestWithGuestRole } from 'test/integration/graphql/uti
import { makeGraphqlAPIRequest } from 'test/integration/graphql/utils/make-graphql-api-request.util';
import { updateFeatureFlagFactory } from 'test/integration/graphql/utils/update-feature-flag-factory.util';
import { SEED_APPLE_WORKSPACE_ID } from 'src/database/typeorm-seeds/core/workspaces';
import { ErrorCode } from 'src/engine/core-modules/graphql/utils/graphql-errors.util';
import { PermissionsExceptionMessage } from 'src/engine/metadata-modules/permissions/permissions.exception';
import { SEED_APPLE_WORKSPACE_ID } from 'src/engine/workspace-manager/dev-seeder/core/utils/seed-workspaces.util';
describe('destroyOneObjectRecordsPermissions', () => {
describe('permissions V2 disabled', () => {

2
packages/twenty-server/test/integration/graphql/suites/object-records-permissions/restore-many-object-records-permissions.integration-spec.ts
View File

@ -8,9 +8,9 @@ import { makeGraphqlAPIRequest } from 'test/integration/graphql/utils/make-graph
import { restoreManyOperationFactory } from 'test/integration/graphql/utils/restore-many-operation-factory.util';
import { updateFeatureFlagFactory } from 'test/integration/graphql/utils/update-feature-flag-factory.util';
import { SEED_APPLE_WORKSPACE_ID } from 'src/database/typeorm-seeds/core/workspaces';
import { ErrorCode } from 'src/engine/core-modules/graphql/utils/graphql-errors.util';
import { PermissionsExceptionMessage } from 'src/engine/metadata-modules/permissions/permissions.exception';
import { SEED_APPLE_WORKSPACE_ID } from 'src/engine/workspace-manager/dev-seeder/core/utils/seed-workspaces.util';
describe('restoreManyObjectRecordsPermissions', () => {
describe('permissions V2 disabled', () => {

2
packages/twenty-server/test/integration/graphql/suites/object-records-permissions/update-many-object-records-permissions.integration-spec.ts
View File

@ -8,9 +8,9 @@ import { makeGraphqlAPIRequest } from 'test/integration/graphql/utils/make-graph
import { updateFeatureFlagFactory } from 'test/integration/graphql/utils/update-feature-flag-factory.util';
import { updateManyOperationFactory } from 'test/integration/graphql/utils/update-many-operation-factory.util';
import { SEED_APPLE_WORKSPACE_ID } from 'src/database/typeorm-seeds/core/workspaces';
import { ErrorCode } from 'src/engine/core-modules/graphql/utils/graphql-errors.util';
import { PermissionsExceptionMessage } from 'src/engine/metadata-modules/permissions/permissions.exception';
import { SEED_APPLE_WORKSPACE_ID } from 'src/engine/workspace-manager/dev-seeder/core/utils/seed-workspaces.util';
describe('updateManyObjectRecordsPermissions', () => {
describe('permissions V2 disabled', () => {

2
packages/twenty-server/test/integration/graphql/suites/object-records-permissions/update-one-object-records-permissions.integration-spec.ts
View File

@ -9,9 +9,9 @@ import { makeGraphqlAPIRequest } from 'test/integration/graphql/utils/make-graph
import { updateFeatureFlagFactory } from 'test/integration/graphql/utils/update-feature-flag-factory.util';
import { updateOneOperationFactory } from 'test/integration/graphql/utils/update-one-operation-factory.util';
import { SEED_APPLE_WORKSPACE_ID } from 'src/database/typeorm-seeds/core/workspaces';
import { ErrorCode } from 'src/engine/core-modules/graphql/utils/graphql-errors.util';
import { PermissionsExceptionMessage } from 'src/engine/metadata-modules/permissions/permissions.exception';
import { SEED_APPLE_WORKSPACE_ID } from 'src/engine/workspace-manager/dev-seeder/core/utils/seed-workspaces.util';
describe('updateOneObjectRecordsPermissions', () => {
describe('permissions V2 disabled', () => {

8
packages/twenty-server/test/integration/graphql/suites/settings-permissions/granular-settings-permissions.ts
View File

@ -7,11 +7,11 @@ import { updateWorkspaceMemberRole } from 'test/integration/graphql/utils/update
import { createOneObjectMetadataQueryFactory } from 'test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata-query-factory.util';
import { deleteOneObjectMetadataQueryFactory } from 'test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata-query-factory.util';
import { SEED_APPLE_WORKSPACE_ID } from 'src/database/typeorm-seeds/core/workspaces';
import { DEV_SEED_WORKSPACE_MEMBER_IDS } from 'src/database/typeorm-seeds/workspace/workspace-members';
import { ErrorCode } from 'src/engine/core-modules/graphql/utils/graphql-errors.util';
import { SettingPermissionType } from 'src/engine/metadata-modules/permissions/constants/setting-permission-type.constants';
import { PermissionsExceptionMessage } from 'src/engine/metadata-modules/permissions/permissions.exception';
import { SEED_APPLE_WORKSPACE_ID } from 'src/engine/workspace-manager/dev-seeder/core/utils/seed-workspaces.util';
import { WORKSPACE_MEMBER_DATA_SEED_IDS } from 'src/engine/workspace-manager/dev-seeder/data/constants/workspace-member-data-seeds.constant';
const client = request(`http://localhost:${APP_PORT}`);
@ -103,7 +103,7 @@ describe('Granular settings permissions', () => {
await updateWorkspaceMemberRole({
client,
roleId: customRoleId,
workspaceMemberId: DEV_SEED_WORKSPACE_MEMBER_IDS.JONY,
workspaceMemberId: WORKSPACE_MEMBER_DATA_SEED_IDS.JONY,
});
});
@ -113,7 +113,7 @@ describe('Granular settings permissions', () => {
query: `
mutation UpdateWorkspaceMemberRole {
updateWorkspaceMemberRole(
workspaceMemberId: "${DEV_SEED_WORKSPACE_MEMBER_IDS.JONY}"
workspaceMemberId: "${WORKSPACE_MEMBER_DATA_SEED_IDS.JONY}"
roleId: "${originalMemberRoleId}"
) {
id

14
packages/twenty-server/test/integration/graphql/suites/settings-permissions/roles.integration-spec.ts
View File

@ -5,11 +5,11 @@ import { updateFeatureFlagFactory } from 'test/integration/graphql/utils/update-
import { createOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata.util';
import { deleteOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata.util';
import { SEED_APPLE_WORKSPACE_ID } from 'src/database/typeorm-seeds/core/workspaces';
import { DEV_SEED_WORKSPACE_MEMBER_IDS } from 'src/database/typeorm-seeds/workspace/workspace-members';
import { ErrorCode } from 'src/engine/core-modules/graphql/utils/graphql-errors.util';
import { SettingPermissionType } from 'src/engine/metadata-modules/permissions/constants/setting-permission-type.constants';
import { PermissionsExceptionMessage } from 'src/engine/metadata-modules/permissions/permissions.exception';
import { SEED_APPLE_WORKSPACE_ID } from 'src/engine/workspace-manager/dev-seeder/core/utils/seed-workspaces.util';
import { WORKSPACE_MEMBER_DATA_SEED_IDS } from 'src/engine/workspace-manager/dev-seeder/data/constants/workspace-member-data-seeds.constant';
const client = request(`http://localhost:${APP_PORT}`);
@ -192,7 +192,7 @@ describe('roles permissions', () => {
const query = {
query: `
mutation UpdateWorkspaceMemberRole {
updateWorkspaceMemberRole(workspaceMemberId: "${DEV_SEED_WORKSPACE_MEMBER_IDS.TIM}", roleId: "test-role-id") {
updateWorkspaceMemberRole(workspaceMemberId: "${WORKSPACE_MEMBER_DATA_SEED_IDS.TIM}", roleId: "test-role-id") {
id
}
}
@ -245,7 +245,7 @@ describe('roles permissions', () => {
const updateRoleQuery = {
query: `
mutation UpdateWorkspaceMemberRole {
updateWorkspaceMemberRole(workspaceMemberId: "${DEV_SEED_WORKSPACE_MEMBER_IDS.PHIL}", roleId: "${memberRoleId}") {
updateWorkspaceMemberRole(workspaceMemberId: "${WORKSPACE_MEMBER_DATA_SEED_IDS.PHIL}", roleId: "${memberRoleId}") {
id
}
}
@ -262,7 +262,7 @@ describe('roles permissions', () => {
expect(res.body.data).toBeDefined();
expect(res.body.errors).toBeUndefined();
expect(res.body.data.updateWorkspaceMemberRole.id).toBe(
DEV_SEED_WORKSPACE_MEMBER_IDS.PHIL,
WORKSPACE_MEMBER_DATA_SEED_IDS.PHIL,
);
});
@ -270,7 +270,7 @@ describe('roles permissions', () => {
const rollbackRoleUpdateQuery = {
query: `
mutation UpdateWorkspaceMemberRole {
updateWorkspaceMemberRole(workspaceMemberId: "${DEV_SEED_WORKSPACE_MEMBER_IDS.PHIL}", roleId: "${guestRoleId}") {
updateWorkspaceMemberRole(workspaceMemberId: "${WORKSPACE_MEMBER_DATA_SEED_IDS.PHIL}", roleId: "${guestRoleId}") {
id
}
}
@ -286,7 +286,7 @@ describe('roles permissions', () => {
expect(res.body.data).toBeDefined();
expect(res.body.errors).toBeUndefined();
expect(res.body.data.updateWorkspaceMemberRole.id).toBe(
DEV_SEED_WORKSPACE_MEMBER_IDS.PHIL,
WORKSPACE_MEMBER_DATA_SEED_IDS.PHIL,
);
});
});

2
packages/twenty-server/test/integration/graphql/suites/settings-permissions/security.integration-spec.ts
View File

@ -3,9 +3,9 @@ import request from 'supertest';
import { makeGraphqlAPIRequest } from 'test/integration/graphql/utils/make-graphql-api-request.util';
import { updateFeatureFlagFactory } from 'test/integration/graphql/utils/update-feature-flag-factory.util';
import { SEED_APPLE_WORKSPACE_ID } from 'src/database/typeorm-seeds/core/workspaces';
import { ErrorCode } from 'src/engine/core-modules/graphql/utils/graphql-errors.util';
import { PermissionsExceptionMessage } from 'src/engine/metadata-modules/permissions/permissions.exception';
import { SEED_APPLE_WORKSPACE_ID } from 'src/engine/workspace-manager/dev-seeder/core/utils/seed-workspaces.util';
const client = request(`http://localhost:${APP_PORT}`);

22
packages/twenty-server/test/integration/graphql/suites/settings-permissions/workspace-members.integration-spec.ts
View File

@ -5,9 +5,9 @@ import { makeGraphqlAPIRequest } from 'test/integration/graphql/utils/make-graph
import { restoreOneOperationFactory } from 'test/integration/graphql/utils/restore-one-operation-factory.util';
import { updateOneOperationFactory } from 'test/integration/graphql/utils/update-one-operation-factory.util';
import { DEV_SEED_WORKSPACE_MEMBER_IDS } from 'src/database/typeorm-seeds/workspace/workspace-members';
import { ErrorCode } from 'src/engine/core-modules/graphql/utils/graphql-errors.util';
import { PermissionsExceptionMessage } from 'src/engine/metadata-modules/permissions/permissions.exception';
import { WORKSPACE_MEMBER_DATA_SEED_IDS } from 'src/engine/workspace-manager/dev-seeder/data/constants/workspace-member-data-seeds.constant';
const WORKSPACE_MEMBER_GQL_FIELDS = `
id
@ -22,7 +22,7 @@ describe('workspace members permissions', () => {
const graphqlOperation = updateOneOperationFactory({
objectMetadataSingularName: 'workspaceMember',
gqlFields: WORKSPACE_MEMBER_GQL_FIELDS,
recordId: DEV_SEED_WORKSPACE_MEMBER_IDS.JONY,
recordId: WORKSPACE_MEMBER_DATA_SEED_IDS.JONY,
data: {
name: {
firstName: 'Jony',
@ -35,7 +35,7 @@ describe('workspace members permissions', () => {
expect(response.body.data).toStrictEqual({
updateWorkspaceMember: {
id: DEV_SEED_WORKSPACE_MEMBER_IDS.JONY,
id: WORKSPACE_MEMBER_DATA_SEED_IDS.JONY,
name: {
firstName: 'Jony',
},
@ -47,7 +47,7 @@ describe('workspace members permissions', () => {
const graphqlOperation = updateOneOperationFactory({
objectMetadataSingularName: 'workspaceMember',
gqlFields: WORKSPACE_MEMBER_GQL_FIELDS,
recordId: DEV_SEED_WORKSPACE_MEMBER_IDS.TIM,
recordId: WORKSPACE_MEMBER_DATA_SEED_IDS.TIM,
data: {
name: {
firstName: 'Not Tim',
@ -73,7 +73,7 @@ describe('workspace members permissions', () => {
const restoreOperation = restoreOneOperationFactory({
objectMetadataSingularName: 'workspaceMember',
gqlFields: WORKSPACE_MEMBER_GQL_FIELDS,
recordId: DEV_SEED_WORKSPACE_MEMBER_IDS.JONY,
recordId: WORKSPACE_MEMBER_DATA_SEED_IDS.JONY,
});
await makeGraphqlAPIRequest(restoreOperation);
@ -82,7 +82,7 @@ describe('workspace members permissions', () => {
const deleteOperation = deleteOneOperationFactory({
objectMetadataSingularName: 'workspaceMember',
gqlFields: WORKSPACE_MEMBER_GQL_FIELDS,
recordId: DEV_SEED_WORKSPACE_MEMBER_IDS.JONY,
recordId: WORKSPACE_MEMBER_DATA_SEED_IDS.JONY,
});
const deleteResponse =
@ -90,7 +90,7 @@ describe('workspace members permissions', () => {
expect(deleteResponse.body.data).toStrictEqual({
deleteWorkspaceMember: {
id: DEV_SEED_WORKSPACE_MEMBER_IDS.JONY,
id: WORKSPACE_MEMBER_DATA_SEED_IDS.JONY,
name: {
firstName: 'Jony',
},
@ -103,7 +103,7 @@ describe('workspace members permissions', () => {
const graphqlOperation = deleteOneOperationFactory({
objectMetadataSingularName: 'workspaceMember',
gqlFields: WORKSPACE_MEMBER_GQL_FIELDS,
recordId: DEV_SEED_WORKSPACE_MEMBER_IDS.TIM,
recordId: WORKSPACE_MEMBER_DATA_SEED_IDS.TIM,
});
const response =
@ -123,7 +123,7 @@ describe('workspace members permissions', () => {
const restoreOperation = restoreOneOperationFactory({
objectMetadataSingularName: 'workspaceMember',
gqlFields: WORKSPACE_MEMBER_GQL_FIELDS,
recordId: DEV_SEED_WORKSPACE_MEMBER_IDS.JONY,
recordId: WORKSPACE_MEMBER_DATA_SEED_IDS.JONY,
});
const response =
@ -131,7 +131,7 @@ describe('workspace members permissions', () => {
expect(response.body.data).toStrictEqual({
restoreWorkspaceMember: {
id: DEV_SEED_WORKSPACE_MEMBER_IDS.JONY,
id: WORKSPACE_MEMBER_DATA_SEED_IDS.JONY,
name: {
firstName: 'Jony',
},
@ -144,7 +144,7 @@ describe('workspace members permissions', () => {
const restoreOperation = restoreOneOperationFactory({
objectMetadataSingularName: 'workspaceMember',
gqlFields: WORKSPACE_MEMBER_GQL_FIELDS,
recordId: DEV_SEED_WORKSPACE_MEMBER_IDS.TIM,
recordId: WORKSPACE_MEMBER_DATA_SEED_IDS.TIM,
});
const response =

2
packages/twenty-server/test/integration/graphql/suites/settings-permissions/workspace.integration-spec.ts
View File

@ -3,10 +3,10 @@ import request from 'supertest';
import { makeGraphqlAPIRequest } from 'test/integration/graphql/utils/make-graphql-api-request.util';
import { updateFeatureFlagFactory } from 'test/integration/graphql/utils/update-feature-flag-factory.util';
import { SEED_APPLE_WORKSPACE_ID } from 'src/database/typeorm-seeds/core/workspaces';
import { BillingPlanKey } from 'src/engine/core-modules/billing/enums/billing-plan-key.enum';
import { ErrorCode } from 'src/engine/core-modules/graphql/utils/graphql-errors.util';
import { PermissionsExceptionMessage } from 'src/engine/metadata-modules/permissions/permissions.exception';
import { SEED_APPLE_WORKSPACE_ID } from 'src/engine/workspace-manager/dev-seeder/core/utils/seed-workspaces.util';
const client = request(`http://localhost:${APP_PORT}`);

66
packages/twenty-server/test/integration/metadata/suites/object-metadata/rename-custom-object.integration-spec.ts
View File

@ -3,12 +3,9 @@ import { createOneObjectMetadata } from 'test/integration/metadata/suites/object
import { deleteOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata.util';
import { findManyObjectMetadataQueryFactory } from 'test/integration/metadata/suites/object-metadata/utils/find-many-object-metadata-query-factory.util';
import { updateOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/update-one-object-metadata.util';
import { createOneRelationMetadataFactory } from 'test/integration/metadata/suites/utils/create-one-relation-metadata-factory.util';
import { makeMetadataAPIRequest } from 'test/integration/metadata/suites/utils/make-metadata-api-request.util';
import { FieldMetadataType } from 'twenty-shared/types';
import { RelationMetadataType } from 'src/engine/metadata-modules/relation-metadata/relation-metadata.entity';
const LISTING_NAME_SINGULAR = 'listing';
describe('Custom object renaming', () => {
@ -137,52 +134,7 @@ describe('Custom object renaming', () => {
});
});
let relationFieldMetadataOnPersonId = '';
const RELATION_FROM_NAME = 'guest';
it('2. should create a custom relation with the custom object', async () => {
// Arrange
const standardObjects = await makeMetadataAPIRequest(
standardObjectsGraphqlOperation,
);
const personObjectId = standardObjects.body.data.objects.edges.find(
// @ts-expect-error legacy noImplicitAny
(object) => object.node.nameSingular === 'person',
).node.id;
// Act
const createRelationGraphqlOperation = createOneRelationMetadataFactory({
input: {
relationMetadata: {
fromDescription: '',
fromIcon: 'IconRelationOneToMany',
fromLabel: 'Guest',
fromName: RELATION_FROM_NAME,
fromObjectMetadataId: listingObjectId,
relationType: RelationMetadataType.ONE_TO_MANY,
toDescription: undefined,
toIcon: 'IconListNumbers',
toLabel: 'Property',
toName: 'property',
toObjectMetadataId: personObjectId,
},
},
gqlFields: `
id
fromFieldMetadataId
`,
});
const relationResponse = await makeMetadataAPIRequest(
createRelationGraphqlOperation,
);
// Assert
relationFieldMetadataOnPersonId =
relationResponse.body.data.createOneRelationMetadata.fromFieldMetadataId;
});
it('3. should rename custom object', async () => {
it('2. should rename custom object', async () => {
// Arrange
const HOUSE_NAME_SINGULAR = 'house';
const HOUSE_NAME_PLURAL = 'houses';
@ -228,25 +180,17 @@ describe('Custom object renaming', () => {
// @ts-expect-error legacy noImplicitAny
standardObjectRelationsMap[relation].relationFieldMetadataId;
const updatedRelationFieldMetadataId = fieldsMetadata.find(
const updatedRelationFieldMetadata = fieldsMetadata.find(
// @ts-expect-error legacy noImplicitAny
(field) => field.id === relationFieldMetadataId,
);
expect(updatedRelationFieldMetadataId.name).toBe(HOUSE_NAME_SINGULAR);
expect(updatedRelationFieldMetadataId.label).toBe(HOUSE_LABEL_SINGULAR);
expect(updatedRelationFieldMetadata.name).toBe(HOUSE_NAME_SINGULAR);
expect(updatedRelationFieldMetadata.label).toBe(HOUSE_LABEL_SINGULAR);
});
// custom relation are unchanged
const updatedRelationFieldMetadata = fieldsMetadata.find(
// @ts-expect-error legacy noImplicitAny
(field) => field.id === relationFieldMetadataOnPersonId,
);
expect(updatedRelationFieldMetadata.name).toBe(RELATION_FROM_NAME);
});
it('4. should delete custom object', async () => {
it('3. should delete custom object', async () => {
const { data } = await deleteOneObjectMetadata({
input: {
idToDelete: listingObjectId,

26
packages/twenty-server/test/integration/metadata/suites/utils/create-one-relation-metadata-factory.util.ts
View File

@ -1,26 +0,0 @@
import gql from 'graphql-tag';
import { CreateRelationInput } from 'src/engine/metadata-modules/relation-metadata/dtos/create-relation.input';
type CreateOneRelationFactoryParams = {
gqlFields: string;
input?: {
relationMetadata: Omit<CreateRelationInput, 'workspaceId'>;
};
};
export const createOneRelationMetadataFactory = ({
gqlFields,
input,
}: CreateOneRelationFactoryParams) => ({
query: gql`
mutation CreateOneRelationMetadata($input: CreateOneRelationMetadataInput!) {
createOneRelationMetadata(input: $input) {
${gqlFields}
}
}
`,
variables: {
input,
},
});

22
packages/twenty-server/test/integration/metadata/suites/utils/delete-one-relation-metadata-factory.util.ts
View File

@ -1,22 +0,0 @@
import gql from 'graphql-tag';
type DeleteOneRelationFactoryParams = {
idToDelete: string;
};
export const deleteOneRelationMetadataItemFactory = ({
idToDelete,
}: DeleteOneRelationFactoryParams) => ({
query: gql`
mutation DeleteOneRelation($input: DeleteOneRelationInput!) {
deleteOneRelation(input: $input) {
id
}
}
`,
variables: {
input: {
id: idToDelete,
},
},
});