[QRQC_2] No explicit any in twenty-server (#12068)
# Introduction Added a no-explicit-any rule to the twenty-server, not applicable to tests and integration tests folder Related to https://github.com/twentyhq/core-team-issues/issues/975 Discussed with Charles ## In case of conflicts Until this is approved I won't rebased and handle conflict, just need to drop two latest commits and re run the scripts etc ## Legacy We decided not to handle the existing lint error occurrences and programmatically ignored them through a disable next line rule comment ## Open question We might wanna activate the [no-explicit-any](https://typescript-eslint.io/rules/no-explicit-any/) `ignoreRestArgs` for our use case ? ``` ignoreRestArgs?: boolean; ``` --------- Co-authored-by: etiennejouan <jouan.etienne@gmail.com>
This commit is contained in:
@ -111,6 +111,7 @@ export class WorkspaceHealthCommand extends CommandRunner {
|
||||
required: false,
|
||||
})
|
||||
fix(value: string): WorkspaceHealthFixKind {
|
||||
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||
if (!Object.values(WorkspaceHealthFixKind).includes(value as any)) {
|
||||
throw new Error(`Invalid fix kind ${value}`);
|
||||
}
|
||||
@ -125,6 +126,7 @@ export class WorkspaceHealthCommand extends CommandRunner {
|
||||
defaultValue: WorkspaceHealthMode.All,
|
||||
})
|
||||
parseMode(value: string): WorkspaceHealthMode {
|
||||
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||
if (!Object.values(WorkspaceHealthMode).includes(value as any)) {
|
||||
throw new Error(`Invalid mode ${value}`);
|
||||
}
|
||||
|
||||
@ -146,7 +146,9 @@ export class WorkspaceDefaultValueFixer extends AbstractWorkspaceFixer<Workspace
|
||||
: value;
|
||||
|
||||
alteredDefaultValue = {
|
||||
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||
...(currentDefaultValue as any),
|
||||
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||
...(alteredDefaultValue as any),
|
||||
[key]: newValue,
|
||||
};
|
||||
|
||||
@ -250,6 +250,7 @@ export class DatabaseStructureService {
|
||||
const typeORMType = fieldMetadataTypeToColumnType(type) as ColumnType;
|
||||
const mainDataSource = this.typeORMService.getMainDataSource();
|
||||
|
||||
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||
let value: any =
|
||||
// Old formart default values
|
||||
defaultValue &&
|
||||
|
||||
Reference in New Issue
Block a user