From abc05fafd7757de676fd35ee0627f9effdf4ad1f Mon Sep 17 00:00:00 2001 From: Paul Rastoin <45004772+prastoin@users.noreply.github.com> Date: Fri, 2 May 2025 16:40:56 +0200 Subject: [PATCH] Redis max memory limit and eviction policy (#11836) # Introduction Redis [eviction policy](https://redis.io/docs/latest/operate/rs/databases/memory-performance/eviction-policy/) and [Key eviction](https://redis.io/docs/latest/develop/reference/eviction/) [Bullmq eviction recommendations](https://docs.bullmq.io/guide/going-to-production#max-memory-policy) We might need a dedicated bullmq redis instance, as sharing engine/metadata keys and bull will someday become problematic close https://github.com/twentyhq/core-team-issues/issues/452 About to open a PR for our internal IaC Ps: Did not set a `--maxmemory` that could be leading to undetermined OOOM errors at runtime. Should be user provided or should define a default value ? --- packages/twenty-docker/docker-compose.yml | 1 + packages/twenty-docker/k8s/manifests/deployment-redis.yaml | 3 ++- packages/twenty-docker/podman/podman-compose.yml | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/twenty-docker/docker-compose.yml b/packages/twenty-docker/docker-compose.yml index a9429b543..c883e75c8 100644 --- a/packages/twenty-docker/docker-compose.yml +++ b/packages/twenty-docker/docker-compose.yml @@ -134,6 +134,7 @@ services: redis: image: redis restart: always + command: ["--maxmemory-policy", "noeviction"] volumes: docker-data: diff --git a/packages/twenty-docker/k8s/manifests/deployment-redis.yaml b/packages/twenty-docker/k8s/manifests/deployment-redis.yaml index e09874aac..bd7aaa3cf 100644 --- a/packages/twenty-docker/k8s/manifests/deployment-redis.yaml +++ b/packages/twenty-docker/k8s/manifests/deployment-redis.yaml @@ -25,9 +25,10 @@ spec: - name: redis image: redis/redis-stack-server:latest imagePullPolicy: Always + args: ["--maxmemory-policy", "noeviction"] env: - name: PORT - value: 6379 + value: "6379" ports: - containerPort: 6379 name: redis diff --git a/packages/twenty-docker/podman/podman-compose.yml b/packages/twenty-docker/podman/podman-compose.yml index 826e1e962..3e2848313 100644 --- a/packages/twenty-docker/podman/podman-compose.yml +++ b/packages/twenty-docker/podman/podman-compose.yml @@ -14,6 +14,7 @@ services: redis: container_name: twenty-redis image: redis:latest + command: ["--maxmemory-policy", "noeviction"] volumes: - twenty-redis-data:/data:Z