admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix secondary links default value and types (#8532)

Browse Source 
Fixes broken companies view
This commit is contained in:
ad-elias
2024-11-17 15:18:02 +01:00
committed by GitHub
parent 8c33e4cdae
commit ac1197afe1
7 changed files with 25 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/twenty-server/src/modules/contact-creation-manager/services/create-company.service.ts
View File

@ -2,7 +2,7 @@ import { Injectable } from '@nestjs/common';
import axios, { AxiosInstance } from 'axios';
import uniqBy from 'lodash.uniqby';
import { EntityManager, ILike } from 'typeorm';
import { DeepPartial, EntityManager, ILike } from 'typeorm';
import { FieldActorSource } from 'src/engine/metadata-modules/field-metadata/composite-types/actor.composite-type';
import { WorkspaceRepository } from 'src/engine/twenty-orm/repository/workspace.repository';
@ -90,11 +90,7 @@ export class CreateCompanyService {
);
// Create new companies
const createdCompanies = await companyRepository.save(
newCompaniesData,
undefined,
transactionManager,
);
const createdCompanies = await companyRepository.save(newCompaniesData);
const createdCompanyIdsMap = this.createCompanyMap(createdCompanies);
return {
@ -157,10 +153,10 @@ export class CreateCompanyService {
};
}
private createCompanyMap(companies: CompanyWorkspaceEntity[]) {
private createCompanyMap(companies: DeepPartial<CompanyWorkspaceEntity>[]) {
return companies.reduce(
(acc, company) => {
if (!company.domainName) {
if (!company.domainName?.primaryLinkUrl || !company.id) {
return acc;
}
const key = extractDomainFromLink(company.domainName.primaryLinkUrl);

2
packages/twenty-server/src/modules/contact-creation-manager/services/create-contact.service.ts
View File

@ -1,6 +1,6 @@
import { Injectable } from '@nestjs/common';
import { EntityManager } from 'typeorm';
import { DeepPartial, EntityManager } from 'typeorm';
import { v4 } from 'uuid';
import { FieldActorSource } from 'src/engine/metadata-modules/field-metadata/composite-types/actor.composite-type';