Replaced eslint rule twenty/no-spread-props to react/jsx-props-no-spreading (#1976)

* Replaced eslint rule twenty/no-spread-props to react/jsx-props-no-spreading

* Disable props spread on external libraries

---------

Co-authored-by: Charles Bochet <charles@twenty.com>

packages/eslint-plugin-twenty/src/rules/no-spread-props.ts

@@ -1,36 +0,0 @@
-import { ESLintUtils } from "@typescript-eslint/utils";
-
-const createRule = ESLintUtils.RuleCreator(
-  () =>
-    "https://docs.twenty.com/contributor/frontend/style-guide#no-single-variable-prop-spreading-in-jsx-elements",
-);
-
-const noSpreadPropsRule = createRule({
-  create: (context) => ({
-    JSXSpreadAttribute: (node) => {
-      if (node.argument.type === "Identifier") {
-        context.report({
-          node,
-          messageId: "noSpreadProps",
-        });
-      }
-    },
-  }),
-  name: "no-spread-props",
-  meta: {
-    docs: {
-      description: "Disallow passing props as {...props} in React components.",
-    },
-    messages: {
-      noSpreadProps: `Single variable prop spreading is disallowed in JSX elements.\nPrefer explicitly listing out all props or using an object expression like so: \`{...{ prop1, prop2 }}\`.\nSee https://docs.twenty.com/contributor/frontend/style-guide#no-single-variable-prop-spreading-in-jsx-elements for more information.`,
-    },
-    type: "suggestion",
-    schema: [],
-    fixable: "code",
-  },
-  defaultOptions: [],
-});
-
-module.exports = noSpreadPropsRule;
-
-export default noSpreadPropsRule;

packages/eslint-plugin-twenty/src/tests/no-spread-props.spec.ts

@@ -1,35 +0,0 @@
-import { RuleTester } from "@typescript-eslint/rule-tester";
-
-import noSpreadPropsRule from "../rules/no-spread-props";
-
-const ruleTester = new RuleTester({
-  parser: "@typescript-eslint/parser",
-  parserOptions: {
-    project: "./tsconfig.json",
-    tsconfigRootDir: __dirname,
-    ecmaFeatures: {
-      jsx: true,
-    },
-  },
-});
-
-ruleTester.run("no-spread-props", noSpreadPropsRule, {
-  valid: [
-    {
-      code: "<MyComponent prop1={value} prop2={value} />",
-    },
-    {
-      code: "<MyComponent {...{prop1, prop2}} />",
-    },
-  ],
-  invalid: [
-    {
-      code: "<MyComponent {...props} />",
-      errors: [
-        {
-          messageId: "noSpreadProps",
-        },
-      ],
-    },
-  ],
-});