Fix e2e tests (#10289)

- Remove the demo test as I don't think it provides much value
- Re-run a test that was discarded because it failed due to a bug;
modified the test so the bug doesn't make the test fail
- Fixed all workflow tests

packages/twenty-e2e-testing/tests/demo/demo_basic.spec.ts

@@ -1,16 +0,0 @@
-import { expect, test } from '@playwright/test';
-
-test.fixme(
-  'Check if demo account is working properly @demo-only',
-  async ({ page }) => {
-    await page.goto('https://app.twenty-next.com/');
-    await page.getByRole('button', { name: 'Continue with Email' }).click();
-    await page.getByRole('button', { name: 'Continue', exact: true }).click();
-    await page.getByRole('button', { name: 'Sign in' }).click();
-    await expect(page.getByText('Welcome to Twenty')).not.toBeVisible();
-    await page.waitForTimeout(5000);
-    await expect(page.getByText('Server’s on a coffee break')).not.toBeVisible({
-      timeout: 5000,
-    });
-  },
-);

packages/twenty-e2e-testing/tests/workflow-creation.spec.ts

@@ -23,10 +23,13 @@ test('Create workflow', async ({ page }) => {
       return requestBody.operationName === 'CreateOneWorkflow';
     }),
 
-    await createWorkflowButton.click(),
+    createWorkflowButton.click(),
   ]);
 
-  const nameInput = page.getByRole('textbox');
+  const recordName = page.getByTestId('top-bar-title').getByTestId('tooltip');
+  await recordName.click();
+
+  const nameInput = page.getByTestId('top-bar-title').getByRole('textbox');
   await nameInput.fill(NEW_WORKFLOW_NAME);
 
   const workflowDiagramContainer = page.locator('.react-flow__renderer');
@@ -36,7 +39,9 @@ test('Create workflow', async ({ page }) => {
   const newWorkflowId = body.data.createWorkflow.id;
 
   try {
-    const workflowName = page.getByRole('button', { name: NEW_WORKFLOW_NAME });
+    const workflowName = page
+      .getByTestId('top-bar-title')
+      .getByText(NEW_WORKFLOW_NAME);
 
     await expect(workflowName).toBeVisible();
 

packages/twenty-e2e-testing/tests/workflow-use-as-draft.spec.ts

@@ -86,90 +86,92 @@ test('Use an old version as draft', async ({ workflowVisualizer, page }) => {
   await expect(workflowVisualizer.getAllStepNodes()).toHaveCount(1);
 });
 
-test.fixme(
-  'Use an old version as draft while having a pending draft version',
-  async ({ workflowVisualizer, page }) => {
-    await workflowVisualizer.createInitialTrigger('record-created');
+test('Use an old version as draft while having a pending draft version', async ({
+  workflowVisualizer,
+  page,
+}) => {
+  await workflowVisualizer.createInitialTrigger('record-created');
 
-    await workflowVisualizer.createStep('create-record');
+  await workflowVisualizer.createStep('create-record');
 
-    await workflowVisualizer.background.click();
+  await workflowVisualizer.background.click();
 
-    await Promise.all([
-      expect(workflowVisualizer.workflowStatus).toHaveText('Active'),
+  await Promise.all([
+    expect(workflowVisualizer.workflowStatus).toHaveText('Active'),
 
-      workflowVisualizer.activateWorkflowButton.click(),
-    ]);
+    workflowVisualizer.activateWorkflowButton.click(),
+  ]);
 
-    await Promise.all([
-      expect(workflowVisualizer.workflowStatus).toHaveText('Draft'),
+  await Promise.all([
+    expect(workflowVisualizer.workflowStatus).toHaveText('Draft'),
 
-      workflowVisualizer.createStep('delete-record'),
-    ]);
+    workflowVisualizer.createStep('delete-record'),
+  ]);
 
-    await expect(workflowVisualizer.triggerNode).toContainText(
-      'Record is Created',
-    );
-    await expect(workflowVisualizer.getAllStepNodes()).toContainText([
-      'Create Record',
-      'Delete Record',
-    ]);
-    await expect(workflowVisualizer.getAllStepNodes()).toHaveCount(2);
-    await expect(workflowVisualizer.useAsDraftButton).not.toBeVisible();
+  await expect(workflowVisualizer.triggerNode).toContainText(
+    'Record is Created',
+  );
+  await expect(workflowVisualizer.getAllStepNodes()).toContainText([
+    'Create Record',
+    'Delete Record',
+  ]);
+  await expect(workflowVisualizer.getAllStepNodes()).toHaveCount(2);
+  await expect(workflowVisualizer.useAsDraftButton).not.toBeVisible();
 
-    const workflowsLink = page.getByRole('link', { name: 'Workflows' });
-    await workflowsLink.click();
+  await workflowVisualizer.closeSidePanel();
 
-    const recordTableRowForWorkflow = page.getByRole('row', {
-      name: workflowVisualizer.workflowName,
-    });
+  const workflowsLink = page.getByRole('link', { name: 'Workflows' });
+  await workflowsLink.click();
 
-    const linkToWorkflow = recordTableRowForWorkflow.getByRole('link', {
-      name: workflowVisualizer.workflowName,
-    });
-    expect(linkToWorkflow).toBeVisible();
+  const recordTableRowForWorkflow = page.getByRole('row', {
+    name: workflowVisualizer.workflowName,
+  });
 
-    const linkToFirstWorkflowVersion = recordTableRowForWorkflow.getByRole(
-      'link',
-      {
-        name: 'v1',
-      },
-    );
+  const linkToWorkflow = recordTableRowForWorkflow.getByRole('link', {
+    name: workflowVisualizer.workflowName,
+  });
+  expect(linkToWorkflow).toBeVisible();
 
-    await linkToFirstWorkflowVersion.click();
+  const linkToFirstWorkflowVersion = recordTableRowForWorkflow.getByRole(
+    'link',
+    {
+      name: 'v1',
+    },
+  );
 
-    await expect(workflowVisualizer.workflowStatus).toHaveText('Active');
-    await expect(workflowVisualizer.useAsDraftButton).toBeVisible();
-    await expect(workflowVisualizer.triggerNode).toContainText(
-      'Record is Created',
-    );
-    await expect(workflowVisualizer.getAllStepNodes()).toContainText([
-      'Create Record',
-    ]);
-    await expect(workflowVisualizer.getAllStepNodes()).toHaveCount(1);
+  await linkToFirstWorkflowVersion.click();
 
-    await Promise.all([
-      expect(workflowVisualizer.overrideDraftButton).toBeVisible(),
+  await expect(workflowVisualizer.workflowStatus).toHaveText('Active');
+  await expect(workflowVisualizer.useAsDraftButton).toBeVisible();
+  await expect(workflowVisualizer.triggerNode).toContainText(
+    'Record is Created',
+  );
+  await expect(workflowVisualizer.getAllStepNodes()).toContainText([
+    'Create Record',
+  ]);
+  await expect(workflowVisualizer.getAllStepNodes()).toHaveCount(1);
 
-      workflowVisualizer.useAsDraftButton.click(),
-    ]);
+  await Promise.all([
+    expect(workflowVisualizer.overrideDraftButton).toBeVisible(),
 
-    await Promise.all([
-      page.waitForURL(`/object/workflow/${workflowVisualizer.workflowId}`),
+    workflowVisualizer.useAsDraftButton.click(),
+  ]);
 
-      workflowVisualizer.overrideDraftButton.click(),
-    ]);
+  await Promise.all([
+    page.waitForURL(`/object/workflow/${workflowVisualizer.workflowId}`),
 
-    await expect(workflowVisualizer.workflowStatus).toHaveText('Draft');
-    await expect(workflowVisualizer.useAsDraftButton).not.toBeVisible();
-    await expect(workflowVisualizer.triggerNode).toContainText(
-      'Record is Created',
-    );
-    await expect(workflowVisualizer.getAllStepNodes()).toContainText([
-      'Create Record',
-    ]);
-    await expect(workflowVisualizer.getAllStepNodes()).toHaveCount(1);
-    await expect(workflowVisualizer.activateWorkflowButton).toBeVisible();
-    await expect(workflowVisualizer.discardDraftButton).toBeVisible();
-  },
-);
+    workflowVisualizer.overrideDraftButton.click(),
+  ]);
+
+  await expect(workflowVisualizer.workflowStatus).toHaveText('Draft');
+  await expect(workflowVisualizer.useAsDraftButton).not.toBeVisible();
+  await expect(workflowVisualizer.triggerNode).toContainText(
+    'Record is Created',
+  );
+  await expect(workflowVisualizer.getAllStepNodes()).toContainText([
+    'Create Record',
+  ]);
+  await expect(workflowVisualizer.getAllStepNodes()).toHaveCount(1);
+  await expect(workflowVisualizer.activateWorkflowButton).toBeVisible();
+  await expect(workflowVisualizer.discardDraftButton).toBeVisible();
+});