From afacec699437e6eb7413dd9a8bc9e0358adf0c2e Mon Sep 17 00:00:00 2001 From: GARY <108233340+GARY121github@users.noreply.github.com> Date: Thu, 11 Jan 2024 16:30:11 +0530 Subject: [PATCH] Finish Implementing Select/MultiSelect #3166 (#3226) * Fixed #3166 * refactor: improve generateEmptyFieldValue function - Optimize handling of MultiSelect and Select cases - Provide a default value for Select based on FieldSelectValue - Enhance code readability and maintainability * Fixed #3166 - Introduce MultiSelect-specific logic with a backend support check - Implement Select-specific logic with a default value - Throw an error for unhandled FieldMetadataType --------- Co-authored-by: Lucas Bordeau Co-authored-by: Charles Bochet --- .../object-record/utils/generateEmptyFieldValue.ts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/twenty-front/src/modules/object-record/utils/generateEmptyFieldValue.ts b/packages/twenty-front/src/modules/object-record/utils/generateEmptyFieldValue.ts index 1ec69ee22..c69c49b71 100644 --- a/packages/twenty-front/src/modules/object-record/utils/generateEmptyFieldValue.ts +++ b/packages/twenty-front/src/modules/object-record/utils/generateEmptyFieldValue.ts @@ -41,9 +41,6 @@ export const generateEmptyFieldValue = ( case FieldMetadataType.Relation: { return null; } - case FieldMetadataType.Select: { - return null; - } case FieldMetadataType.Currency: { return { amountMicros: null, @@ -51,9 +48,14 @@ export const generateEmptyFieldValue = ( __typename: 'Currency', }; } - + case FieldMetadataType.Select: { + return null; + } case FieldMetadataType.MultiSelect: { throw new Error('Not implemented yet'); } + default: { + throw new Error('Unhandled FieldMetadataType'); + } } };