Feat/activities custom objects (#3213)

* WIP

* WIP - MultiObjectSearch

* WIP

* WIP

* Finished working version

* Fix

* Fixed and cleaned

* Fix

* Disabled files and emails for custom objects

* Cleaned console.log

* Fixed attachment

* Fixed

* fix lint

---------

Co-authored-by: Charles Bochet <charles@twenty.com>

packages/twenty-front/src/modules/activities/timeline/components/Timeline.tsx

@@ -1,10 +1,12 @@
 import React from 'react';
 import styled from '@emotion/styled';
+import { isNonEmptyString } from '@sniptt/guards';
 
 import { ActivityCreateButton } from '@/activities/components/ActivityCreateButton';
+import { useActivityTargets } from '@/activities/hooks/useActivityTargets';
 import { useOpenCreateActivityDrawer } from '@/activities/hooks/useOpenCreateActivityDrawer';
 import { Activity } from '@/activities/types/Activity';
-import { ActivityTargetableEntity } from '@/activities/types/ActivityTargetableEntity';
+import { ActivityTargetableObject } from '@/activities/types/ActivityTargetableEntity';
 import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
 import { useFindManyRecords } from '@/object-record/hooks/useFindManyRecords';
 import { useIsMobile } from '@/ui/utilities/responsive/hooks/useIsMobile';
@@ -48,20 +50,21 @@ const StyledEmptyTimelineSubTitle = styled.div`
   margin-bottom: ${({ theme }) => theme.spacing(2)};
 `;
 
-export const Timeline = ({ entity }: { entity: ActivityTargetableEntity }) => {
-  const { records: activityTargets, loading } = useFindManyRecords({
-    objectNameSingular: CoreObjectNameSingular.ActivityTarget,
-    filter: {
-      [entity.type === 'Company' ? 'companyId' : 'personId']: { eq: entity.id },
-    },
-  });
+export const Timeline = ({
+  targetableObject,
+}: {
+  targetableObject: ActivityTargetableObject;
+}) => {
+  const { activityTargets } = useActivityTargets({ targetableObject });
 
   const { records: activities } = useFindManyRecords({
     skip: !activityTargets?.length,
     objectNameSingular: CoreObjectNameSingular.Activity,
     filter: {
       id: {
-        in: activityTargets?.map((activityTarget) => activityTarget.activityId),
+        in: activityTargets
+          ?.map((activityTarget) => activityTarget.activityId)
+          .filter(isNonEmptyString),
       },
     },
     orderBy: {
@@ -71,10 +74,6 @@ export const Timeline = ({ entity }: { entity: ActivityTargetableEntity }) => {
 
   const openCreateActivity = useOpenCreateActivityDrawer();
 
-  if (loading || entity.type === 'Custom') {
-    return <></>;
-  }
-
   if (!activities.length) {
     return (
       <StyledTimelineEmptyContainer>
@@ -84,13 +83,13 @@ export const Timeline = ({ entity }: { entity: ActivityTargetableEntity }) => {
           onNoteClick={() =>
             openCreateActivity({
               type: 'Note',
-              targetableEntities: [entity],
+              targetableObjects: [targetableObject],
             })
           }
           onTaskClick={() =>
             openCreateActivity({
               type: 'Task',
-              targetableEntities: [entity],
+              targetableObjects: [targetableObject],
             })
           }
         />

packages/twenty-front/src/modules/activities/timeline/components/TimelineActivity.tsx

@@ -145,7 +145,7 @@ type TimelineActivityProps = {
     | 'type'
     | 'comments'
     | 'dueAt'
-  > & { author: Pick<WorkspaceMember, 'name' | 'avatarUrl'> } & {
+  > & { author?: Pick<WorkspaceMember, 'name' | 'avatarUrl'> } & {
     assignee?: Pick<WorkspaceMember, 'id' | 'name' | 'avatarUrl'> | null;
   };
   isLastActivity?: boolean;
@@ -165,8 +165,8 @@ export const TimelineActivity = ({
       <StyledTimelineItemContainer>
         <StyledAvatarContainer>
           <Avatar
-            avatarUrl={activity.author.avatarUrl}
-            placeholder={activity.author.name.firstName ?? ''}
+            avatarUrl={activity.author?.avatarUrl}
+            placeholder={activity.author?.name.firstName ?? ''}
             size="sm"
             type="rounded"
           />
@@ -175,7 +175,8 @@ export const TimelineActivity = ({
           <StyledItemTitleContainer>
             <StyledItemAuthorText>
               <span>
-                {activity.author.name.firstName} {activity.author.name.lastName}
+                {activity.author?.name.firstName}{' '}
+                {activity.author?.name.lastName}
               </span>
               created a {activity.type.toLowerCase()}
             </StyledItemAuthorText>