Feat/activities custom objects (#3213)

* WIP

* WIP - MultiObjectSearch

* WIP

* WIP

* Finished working version

* Fix

* Fixed and cleaned

* Fix

* Disabled files and emails for custom objects

* Cleaned console.log

* Fixed attachment

* Fixed

* fix lint

---------

Co-authored-by: Charles Bochet <charles@twenty.com>

packages/twenty-front/src/modules/object-metadata/utils/getBasePathToShowPage.ts

@@ -0,0 +1,11 @@
+import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem';
+
+export const getBasePathToShowPage = ({
+  objectMetadataItem,
+}: {
+  objectMetadataItem: ObjectMetadataItem;
+}) => {
+  const basePathToShowPage = `/object/${objectMetadataItem.nameSingular}/`;
+
+  return basePathToShowPage;
+};

packages/twenty-front/src/modules/object-metadata/utils/getLabelIdentifierFieldMetadataItem.ts

@@ -0,0 +1,12 @@
+import { FieldMetadataItem } from '@/object-metadata/types/FieldMetadataItem';
+import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem';
+
+export const getLabelIdentifierFieldMetadataItem = (
+  objectMetadataItem: ObjectMetadataItem,
+): FieldMetadataItem | undefined => {
+  return objectMetadataItem.fields.find(
+    (field) =>
+      field.id === objectMetadataItem.labelIdentifierFieldMetadataId ||
+      field.name === 'name',
+  );
+};

packages/twenty-front/src/modules/object-metadata/utils/getObjectOrderByField.ts

@@ -5,7 +5,7 @@ import { FieldMetadataType } from '~/generated-metadata/graphql';
 
 export const getObjectOrderByField = (
   objectMetadataItem: ObjectMetadataItem,
-  orderBy: OrderBy,
+  orderBy?: OrderBy | null,
 ): OrderByField => {
   const labelIdentifierFieldMetadata = objectMetadataItem.fields.find(
     (field) =>
@@ -18,18 +18,18 @@ export const getObjectOrderByField = (
       case FieldMetadataType.FullName:
         return {
           [labelIdentifierFieldMetadata.name]: {
-            firstName: orderBy,
-            lastName: orderBy,
+            firstName: orderBy ?? 'AscNullsLast',
+            lastName: orderBy ?? 'AscNullsLast',
           },
         };
       default:
         return {
-          [labelIdentifierFieldMetadata.name]: orderBy,
+          [labelIdentifierFieldMetadata.name]: orderBy ?? 'AscNullsLast',
         };
     }
   } else {
     return {
-      createdAt: orderBy,
+      createdAt: orderBy ?? 'DescNullsLast',
     };
   }
 };

packages/twenty-front/src/modules/object-metadata/utils/getObjectRecordIdentifier.ts

@@ -1,7 +1,10 @@
 import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
 import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem';
+import { getBasePathToShowPage } from '@/object-metadata/utils/getBasePathToShowPage';
+import { getLabelIdentifierFieldMetadataItem } from '@/object-metadata/utils/getLabelIdentifierFieldMetadataItem';
+import { ObjectRecord } from '@/object-record/types/ObjectRecord';
 import { ObjectRecordIdentifier } from '@/object-record/types/ObjectRecordIdentifier';
-import { FieldMetadataType } from '~/generated/graphql';
+import { FieldMetadataType } from '~/generated-metadata/graphql';
 import { getLogoUrlFromDomainName } from '~/utils';
 
 export const getObjectRecordIdentifier = ({
@@ -9,30 +12,24 @@ export const getObjectRecordIdentifier = ({
   record,
 }: {
   objectMetadataItem: ObjectMetadataItem;
-  record: any;
+  record: ObjectRecord;
 }): ObjectRecordIdentifier => {
-  const basePathToShowPage = `/object/${objectMetadataItem.nameSingular}/`;
-  const linkToShowPage = `${basePathToShowPage}${record.id}`;
-
-  if (objectMetadataItem.nameSingular === CoreObjectNameSingular.Opportunity) {
-    return {
-      id: record.id,
-      name: record?.company?.name,
-      avatarUrl: record.avatarUrl,
-      avatarType: 'rounded',
-      linkToShowPage,
-    };
+  switch (objectMetadataItem.nameSingular) {
+    case CoreObjectNameSingular.Opportunity:
+      return {
+        id: record.id,
+        name: record?.company?.name,
+        avatarUrl: record.avatarUrl,
+        avatarType: 'rounded',
+      };
   }
 
-  const labelIdentifierFieldMetadata = objectMetadataItem.fields.find(
-    (field) =>
-      field.id === objectMetadataItem.labelIdentifierFieldMetadataId ||
-      field.name === 'name',
-  );
+  const labelIdentifierFieldMetadataItem =
+    getLabelIdentifierFieldMetadataItem(objectMetadataItem);
 
   let labelIdentifierFieldValue = '';
 
-  switch (labelIdentifierFieldMetadata?.type) {
+  switch (labelIdentifierFieldMetadataItem?.type) {
     case FieldMetadataType.FullName: {
       labelIdentifierFieldValue = `${record.name?.firstName ?? ''} ${
         record.name?.lastName ?? ''
@@ -40,8 +37,8 @@ export const getObjectRecordIdentifier = ({
       break;
     }
     default:
-      labelIdentifierFieldValue = labelIdentifierFieldMetadata
-        ? record[labelIdentifierFieldMetadata.name]
+      labelIdentifierFieldValue = labelIdentifierFieldMetadataItem
+        ? record[labelIdentifierFieldMetadataItem.name]
         : '';
   }
 
@@ -63,11 +60,17 @@ export const getObjectRecordIdentifier = ({
       ? getLogoUrlFromDomainName(record['domainName'] ?? '')
       : imageIdentifierFieldValue ?? null;
 
+  const basePathToShowPage = getBasePathToShowPage({
+    objectMetadataItem,
+  });
+
+  const linkToEntity = `${basePathToShowPage}${record.id}`;
+
   return {
     id: record.id,
     name: labelIdentifierFieldValue,
     avatarUrl,
     avatarType,
-    linkToShowPage,
+    linkToEntity,
   };
 };