From b24588d648eafa84356eaee90310095ac851bf55 Mon Sep 17 00:00:00 2001 From: Lucas Bordeau Date: Fri, 4 Jul 2025 18:43:05 +0200 Subject: [PATCH] Fix workflow title cell not opening (#13052) This PR fixes a bug that forced all title cell to behave as if they were in a show page, but we have workflow page breadcrumb that is not a show page title. Fixes https://github.com/twentyhq/twenty/issues/13041 --- .../record-title-cell/components/RecordTitleCell.tsx | 1 + .../components/RecordTitleCellContext.tsx | 12 +++--------- .../components/RecordTitleCellTextFieldDisplay.tsx | 6 ++++-- 3 files changed, 8 insertions(+), 11 deletions(-) diff --git a/packages/twenty-front/src/modules/object-record/record-title-cell/components/RecordTitleCell.tsx b/packages/twenty-front/src/modules/object-record/record-title-cell/components/RecordTitleCell.tsx index a949f89e8..76e2d5938 100644 --- a/packages/twenty-front/src/modules/object-record/record-title-cell/components/RecordTitleCell.tsx +++ b/packages/twenty-front/src/modules/object-record/record-title-cell/components/RecordTitleCell.tsx @@ -97,6 +97,7 @@ export const RecordTitleCell = ({ editModeContentOnly: isFieldInputOnly, loading: loading, isReadOnly, + containerType, }; return ( diff --git a/packages/twenty-front/src/modules/object-record/record-title-cell/components/RecordTitleCellContext.tsx b/packages/twenty-front/src/modules/object-record/record-title-cell/components/RecordTitleCellContext.tsx index 186dd3644..aade75fea 100644 --- a/packages/twenty-front/src/modules/object-record/record-title-cell/components/RecordTitleCellContext.tsx +++ b/packages/twenty-front/src/modules/object-record/record-title-cell/components/RecordTitleCellContext.tsx @@ -1,3 +1,4 @@ +import { RecordTitleCellContainerType } from '@/object-record/record-title-cell/types/RecordTitleCellContainerType'; import { createContext, ReactElement } from 'react'; export type RecordTitleCellContextProps = { @@ -6,15 +7,8 @@ export type RecordTitleCellContextProps = { displayModeContent?: ReactElement; loading?: boolean; isReadOnly?: boolean; -}; - -const defaultRecordTitleCellContextProp: RecordTitleCellContextProps = { - editModeContent: undefined, - editModeContentOnly: false, - displayModeContent: undefined, - loading: false, - isReadOnly: false, + containerType: RecordTitleCellContainerType; }; export const RecordTitleCellContext = - createContext(defaultRecordTitleCellContextProp); + createContext({} as RecordTitleCellContextProps); diff --git a/packages/twenty-front/src/modules/object-record/record-title-cell/components/RecordTitleCellTextFieldDisplay.tsx b/packages/twenty-front/src/modules/object-record/record-title-cell/components/RecordTitleCellTextFieldDisplay.tsx index 5e11ae18d..56095428a 100644 --- a/packages/twenty-front/src/modules/object-record/record-title-cell/components/RecordTitleCellTextFieldDisplay.tsx +++ b/packages/twenty-front/src/modules/object-record/record-title-cell/components/RecordTitleCellTextFieldDisplay.tsx @@ -1,7 +1,7 @@ import { FieldContext } from '@/object-record/record-field/contexts/FieldContext'; import { recordStoreFamilyState } from '@/object-record/record-store/states/recordStoreFamilyState'; +import { RecordTitleCellContext } from '@/object-record/record-title-cell/components/RecordTitleCellContext'; import { useRecordTitleCell } from '@/object-record/record-title-cell/hooks/useRecordTitleCell'; -import { RecordTitleCellContainerType } from '@/object-record/record-title-cell/types/RecordTitleCellContainerType'; import { Theme, withTheme } from '@emotion/react'; import styled from '@emotion/styled'; import { useContext } from 'react'; @@ -40,13 +40,15 @@ export const RecordTitleCellSingleTextDisplayMode = () => { const { openRecordTitleCell } = useRecordTitleCell(); + const { containerType } = useContext(RecordTitleCellContext); + return ( { openRecordTitleCell({ recordId, fieldMetadataId: fieldDefinition.fieldMetadataId, - containerType: RecordTitleCellContainerType.ShowPage, + containerType, }); }} >